From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412 Date: Fri, 02 May 2014 20:00:06 +0200 Message-ID: <5363DD26.1020704@gmail.com> References: <53633D4B.9070500@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53633D4B.9070500@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Beomho Seo , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Tomasz Figa , Kukjin Kim Cc: Myungjoo Ham , Chanwoo Choi , Jaehoon Chung List-Id: devicetree@vger.kernel.org Hi Beomho, On 02.05.2014 08:38, Beomho Seo wrote: > This patch fixed gpio key device node. > First, fix incorrect gpio property. > And then, add ok-key node where locate bottom center. > I have tested on exynos4412-trats2 board. While at it, could you also remove interrupt-parent and interrupts properties from nodes of the keys? They have been added here by a mistake and they are not part of the gpio-keys device tree bindings. Best regards, Tomasz