From: Roger Quadros <rogerq@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: rydberg@euromail.se, balbi@ti.com, dmurphy@ti.com,
mugunthanvnm@ti.com, nsekhar@ti.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode
Date: Tue, 6 May 2014 11:31:45 +0300 [thread overview]
Message-ID: <53689DF1.4070008@ti.com> (raw)
In-Reply-To: <20140506051922.GA2608@core.coreip.homeip.net>
Dmitry,
On 05/06/2014 08:19 AM, Dmitry Torokhov wrote:
> Hi Roger,
>
> On Mon, May 05, 2014 at 12:04:33PM +0300, Roger Quadros wrote:
>> @@ -192,8 +364,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client *client)
>>
>> device_init_wakeup(&client->dev, 0);
>>
>> - tsdata->exiting = true;
>> - mb();
>> + if (!tsdata->exiting)
>> + pixcir_stop(tsdata);
>>
>
> I think if we change tsdata->exiting to tsdata->running we won't have to
> do it here. Does the version of the patch below work for you?
>
The call to pixcir_stop() was not required in the original version as well. It seems
that the root of the problem for remove() and suspend() that I was trying to solve
was in the pixcir_stop() function. i.e. the order of mb() and synchronize_irq();
But I like your version more since "running" reflects the behaviour more accurately
than "exiting".
cheers,
-roger
next prev parent reply other threads:[~2014-05-06 8:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 9:04 [PATCH v4 0/7] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support Roger Quadros
2014-05-05 9:04 ` [PATCH v4 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode Roger Quadros
[not found] ` <1399280678-23925-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-06 5:19 ` Dmitry Torokhov
2014-05-06 8:31 ` Roger Quadros [this message]
[not found] ` <1399280678-23925-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-05 9:04 ` [PATCH v4 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations Roger Quadros
2014-05-05 9:04 ` [PATCH v4 3/7] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val() Roger Quadros
2014-05-05 9:04 ` [PATCH v4 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs Roger Quadros
2014-05-05 9:04 ` [PATCH v4 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend Roger Quadros
2014-05-06 5:21 ` Dmitry Torokhov
[not found] ` <20140506052148.GB2608-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-05-06 8:33 ` Roger Quadros
2014-05-05 9:04 ` [PATCH v4 7/7] Input: pixcir_i2c_ts: Add device tree support Roger Quadros
2014-05-05 9:04 ` [PATCH v4 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53689DF1.4070008@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).