devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Roger Quadros <rogerq@ti.com>,
	kishon@ti.com, tony@atomide.com, balbi@ti.com,
	bcousson@baylibre.com
Cc: george.cherian@ti.com, sergei.shtylyov@cogentembedded.com,
	nm@ti.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 4/7] ARM: dts: dra7-clock: Add "l3init_960m_gfclk" clock gate
Date: Tue, 6 May 2014 13:10:33 +0300	[thread overview]
Message-ID: <5368B519.6030600@ti.com> (raw)
In-Reply-To: <1399283686-6127-5-git-send-email-rogerq@ti.com>

On 05/05/2014 12:54 PM, Roger Quadros wrote:
> This clock gate description is missing in the older Reference manuals.
> It is present on the SoC to provide 960MHz reference clock to the
> internal USB PHYs.
>
> Reference: DRA75x_DRA74x_ES1.1_NDA_TRM_vO.pdf, pg. 900,
> Table 3-812. CM_COREAON_L3INIT_60M_GFCLK_CLKCTRL
>
> Use l3init_960m_gfclk as parent of usb_otg_ss1_refclk960m and
> usb_otg_ss2_refclk960m.
>
> CC: Benoît Cousson <bcousson@baylibre.com>
> CC: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Got myself to download the latest copy of the TRM, so this patch looks 
valid.

Acked-by: Tero Kristo <t-kristo@ti.com>

> ---
>   arch/arm/boot/dts/dra7xx-clocks.dtsi | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> index cfb8fc7..c767687 100644
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -1386,6 +1386,14 @@
>   		ti,dividers = <1>, <8>;
>   	};
>
> +	l3init_960m_gfclk: l3init_960m_gfclk {
> +		#clock-cells = <0>;
> +		compatible = "ti,gate-clock";
> +		clocks = <&dpll_usb_clkdcoldo>;
> +		ti,bit-shift = <8>;
> +		reg = <0x06c0>;
> +	};
> +
>   	dss_32khz_clk: dss_32khz_clk {
>   		#clock-cells = <0>;
>   		compatible = "ti,gate-clock";
> @@ -1533,7 +1541,7 @@
>   	usb_otg_ss1_refclk960m: usb_otg_ss1_refclk960m {
>   		#clock-cells = <0>;
>   		compatible = "ti,gate-clock";
> -		clocks = <&dpll_usb_clkdcoldo>;
> +		clocks = <&l3init_960m_gfclk>;
>   		ti,bit-shift = <8>;
>   		reg = <0x13f0>;
>   	};
> @@ -1541,7 +1549,7 @@
>   	usb_otg_ss2_refclk960m: usb_otg_ss2_refclk960m {
>   		#clock-cells = <0>;
>   		compatible = "ti,gate-clock";
> -		clocks = <&dpll_usb_clkdcoldo>;
> +		clocks = <&l3init_960m_gfclk>;
>   		ti,bit-shift = <8>;
>   		reg = <0x1340>;
>   	};
>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-05-06 10:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05  9:54 [PATCH v3 0/7] USB support for DRA7-evm Roger Quadros
2014-05-05  9:54 ` [PATCH v3 2/7] phy: omap-usb2: Add clock names to Documentation binding Roger Quadros
     [not found] ` <1399283686-6127-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-05  9:54   ` [PATCH v3 1/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk" Roger Quadros
     [not found]     ` <1399283686-6127-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-05 18:14       ` Felipe Balbi
2014-05-05  9:54   ` [PATCH v3 3/7] ARM: dts: omap4+: Add clocks to USB2 PHY node Roger Quadros
2014-05-05  9:54   ` [PATCH v3 5/7] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Roger Quadros
2014-06-13 19:08     ` Paul Walmsley
2014-06-18 11:10     ` Roger Quadros
2014-06-18 11:19       ` Rajendra Nayak
     [not found]         ` <53A175DC.8080709-l0cyMroinI0@public.gmane.org>
2014-06-18 11:24           ` Roger Quadros
2014-07-02 11:26         ` Roger Quadros
2014-07-03 10:42           ` Sekhar Nori
2014-05-05  9:54   ` [PATCH v3 6/7] ARM: dts: dra7: Add USB related nodes Roger Quadros
     [not found]     ` <1399283686-6127-7-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-07  8:45       ` Roger Quadros
2014-05-07 11:55       ` [PATCH v4 " Roger Quadros
2014-05-06  7:19   ` [PATCH v3 0/7] USB support for DRA7-evm Roger Quadros
2014-05-06  8:19     ` Kishon Vijay Abraham I
2014-05-05  9:54 ` [PATCH v3 4/7] ARM: dts: dra7-clock: Add "l3init_960m_gfclk" clock gate Roger Quadros
2014-05-06 10:10   ` Tero Kristo [this message]
2014-05-05  9:54 ` [PATCH v3 7/7] dts: dra7-evm: add USB support Roger Quadros
2014-05-13 17:18   ` Tony Lindgren
     [not found]     ` <20140513171802.GG16837-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-14  7:53       ` Roger Quadros
     [not found]   ` <1399283686-6127-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-14  7:58     ` [PATCH v4 " Roger Quadros
     [not found]       ` <53732215.8050608-l0cyMroinI0@public.gmane.org>
2014-05-14 21:27         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368B519.6030600@ti.com \
    --to=t-kristo@ti.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rogerq@ti.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).