From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>
Cc: Bastian Hecht <hechtb+renesas@gmail.com>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support
Date: Thu, 08 May 2014 17:00:03 +0400 [thread overview]
Message-ID: <536B7FD3.5090506@cogentembedded.com> (raw)
In-Reply-To: <1399494750-31996-2-git-send-email-geert+renesas@glider.be>
Hello.
On 05/08/2014 12:32 AM, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> The "clocks" entry should be uncommented after the conversion to CCF is
> integrated.
> arch/arm/boot/dts/r8a7740.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index 3834b94dc02a..560d8d71cea4 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -122,6 +122,19 @@
> 0 149 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + ether: ethernet@e9a00000 {
Are you really going to refer to this node somewhere, using its label?
> + compatible = "renesas,gether-r8a7740";
> + reg = <0xe9a00000 0x800>,
> + <0xe9a01800 0x800>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */
This property is mandatory, according to the bindings.
WBR, Sergei
next prev parent reply other threads:[~2014-05-08 13:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 20:32 [PATCH 1/3] ARM: shmobile: r8a7740: Correct name of DT Ethernet clock Geert Uytterhoeven
[not found] ` <1399494750-31996-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-05-07 20:32 ` [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support Geert Uytterhoeven
2014-05-08 13:00 ` Sergei Shtylyov [this message]
[not found] ` <536B7FD3.5090506-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-08 13:06 ` Geert Uytterhoeven
2014-05-08 13:14 ` Sergei Shtylyov
2014-05-08 13:21 ` Geert Uytterhoeven
2014-05-08 17:52 ` Sergei Shtylyov
2014-05-08 18:46 ` Geert Uytterhoeven
2014-05-08 18:52 ` Sergei Shtylyov
2014-05-08 19:01 ` Geert Uytterhoeven
2014-05-11 1:00 ` Simon Horman
2014-05-11 13:48 ` Sergei Shtylyov
[not found] ` <536F7FB6.5090508-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-11 22:49 ` Simon Horman
2014-05-11 2:25 ` Simon Horman
2014-05-07 20:32 ` [PATCH 3/3] ARM: shmobile: armadillo-reference dts: " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B7FD3.5090506@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=hechtb+renesas@gmail.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).