From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support Date: Thu, 08 May 2014 17:14:40 +0400 Message-ID: <536B8340.4010901@cogentembedded.com> References: <1399494750-31996-1-git-send-email-geert+renesas@glider.be> <1399494750-31996-2-git-send-email-geert+renesas@glider.be> <536B7FD3.5090506@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , Bastian Hecht , Linux-sh list , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 05/08/2014 05:06 PM, Geert Uytterhoeven wrote: >>> + ether: ethernet@e9a00000 { >> Are you really going to refer to this node somewhere, using its label? > Yes, from r8a7740-armadillo800eva-reference.dts Ah, I completely forgot that there should be a board specific part of the node. Sorry. >>> + compatible = "renesas,gether-r8a7740"; >>> + reg = <0xe9a00000 0x800>, >>> + <0xe9a01800 0x800>; >>> + interrupt-parent = <&gic>; >>> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>; >>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */ >> This property is mandatory, according to the bindings. > Indeed, but you cannot put anything there until the platform has CCF, as > mstp3_clks doesn't exist yet. Yes, that was the main obstacle to accepting those bindings sooner. This patch therefore seems somewhat premature. > Gr{oetje,eeting}s, > Geert WBR, Sergei