From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v5 0/3] ARM: sunxi: Add support for consumer infrared devices Date: Thu, 08 May 2014 15:55:41 +0200 Message-ID: <536B8CDD.7040600@redhat.com> References: <1398871010-30681-1-git-send-email-bay@hackerdom.ru> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1398871010-30681-1-git-send-email-bay-d8LqKIyZzER6k2ZkT/Rh8A@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Alexander Bersenev , linux-sunxi , david-0WFrdVpeebksCylrc8G9yg@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sean-hENCXIMQXOg@public.gmane.org, srinivas.kandagatla-qxv4g6HH51o@public.gmane.org, wingrime-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 04/30/2014 05:16 PM, Alexander Bersenev wrote: > This patch introduces Consumer IR(CIR) support for sunxi boards. > > This is based on Alexsey Shestacov's work based on the original driver > supplied by Allwinner. > > Signed-off-by: Alexander Bersenev > Signed-off-by: Alexsey Shestacov Alexander, v5 still has various issues which need fixing, do you plan to do a v6 soon ? Regards, Hans > > --- > Changes since version 1: > - Fix timer memory leaks > - Fix race condition when driver unloads while interrupt handler is active > - Support Cubieboard 2(need testing) > > Changes since version 2: > - More reliable keydown events > - Documentation fixes > - Rename registers accurding to A20 user manual > - Remove some includes, order includes alphabetically > - Use BIT macro > - Typo fixes > > Changes since version 3: > - Split the patch on smaller parts > - More documentation fixes > - Add clock-names in DT > - Use devm_clk_get function to get the clocks > - Removed gpios property from ir's DT > - Changed compatible from allwinner,sunxi-ir to allwinner,sun7i-a20-ir in DT > - Use spin_lock_irq instead spin_lock_irqsave in interrupt handler > - Add myself in the copyright ;) > - Coding style and indentation fixes > > Changes since version 4: > - Try to fix indentation errors by sending patches with git send-mail > > Alexander Bersenev (3): > ARM: sunxi: Add documentation for sunxi consumer infrared devices > ARM: sunxi: Add driver for sunxi IR controller > ARM: sunxi: Add IR controller support in DT on A20 > > .../devicetree/bindings/media/sunxi-ir.txt | 23 ++ > arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 6 + > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 + > arch/arm/boot/dts/sun7i-a20.dtsi | 31 +++ > drivers/media/rc/Kconfig | 10 + > drivers/media/rc/Makefile | 1 + > drivers/media/rc/sunxi-ir.c | 303 +++++++++++++++++++++ > 7 files changed, 380 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/sunxi-ir.txt > create mode 100644 drivers/media/rc/sunxi-ir.c >