From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH 1/4] of/selftest: add testcase for nodes with same name and address Date: Thu, 08 May 2014 12:44:47 -0700 Message-ID: <536BDEAF.5030602@gmail.com> References: <1399499298-8830-1-git-send-email-robherring2@gmail.com> <1399499298-8830-2-git-send-email-robherring2@gmail.com> <536AF13F.6000502@gmail.com> Reply-To: frowand.list@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely Cc: Rob Herring , Linux Kernel Mailing List , "devicetree@vger.kernel.org" , "Ivan T. Ivanov" , Josh Cartwright , Courtney Cavin , Bjorn Andersson , Rob Herring List-Id: devicetree@vger.kernel.org On 5/8/2014 1:59 AM, Grant Likely wrote: > On Thu, May 8, 2014 at 3:51 AM, Frank Rowand wrote: >> On 5/7/2014 2:48 PM, Rob Herring wrote: >>> From: Rob Herring >>> >>> Add a test case for nodes which have the same name and same >>> non-translatable unit address. >> >> If I apply patch 1 and 2 without applying 3 and 4 then console >> warnings are printed, but from a different area of code than >> the original problem reported. This probably is not a big deal, >> but I'm trying to figure out if I can modify the test to also >> show the original problem. >> >> The test case also properly reports the failure. >> >> Once all 4 patches are applied, then the test case passes. > > When adding testcases I do prefer the addition of the test to appear > before the fix while the patch is under review. Makes it easy to see > that, yes the bug exists, and yes the later patch resolves it. > > When the patches are actually committed for merging then it is > probably a good idea to reverse them. Thanks for the testing. In this case, the test case has to be patch #2, if you want to be able to verify that the test case catches the bug, because patch #1 added code to allow the error return value to propagate all the way out to the API called by the test code. So the patch ordering is correct. > > g. > >> >> Thus: >> >> Tested-by: Frank Rowand >> >>> >>> Signed-off-by: Rob Herring >>> --- >>> drivers/of/selftest.c | 23 ++++++++++++++++++ >>> drivers/of/testcase-data/testcases.dtsi | 1 + >>> drivers/of/testcase-data/tests-platform.dtsi | 35 ++++++++++++++++++++++++++++ >>> 3 files changed, 59 insertions(+) >>> create mode 100644 drivers/of/testcase-data/tests-platform.dtsi >>> >> >> < snip > >> > . >