From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v5 0/3] ARM: sunxi: Add support for consumer infrared devices Date: Fri, 09 May 2014 15:26:52 +0200 Message-ID: <536CD79C.8080800@redhat.com> References: <1398871010-30681-1-git-send-email-bay@hackerdom.ru> <536B8CDD.7040600@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Alexander Bersenev Cc: linux-sunxi , "david-0WFrdVpeebksCylrc8G9yg@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi, On 05/09/2014 03:21 PM, Alexander Bersenev wrote: > Hello, I am in Austria/Germany in 1-11 may. I plan to make v6 after retur= ning back to Russia. Ok, when you do please also pick up this fix: https://github.com/jwrdegoede/linux-sunxi/commit/180a3e59361ceddeed26543529= ca757cc8112fb0 Which fixes an oops at startup. Other then needing that fix + coding style fixes it works well for me on the cubietruck. I'll try to also test it on sun4i and sun5i if I can find s= ome time to do so. Regards, Hans >=20 > Best, > Alexander Bersenev >=20 >> 08 =D0=BC=D0=B0=D1=8F 2014 =D0=B3., =D0=B2 15:55, Hans de Goede =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >> >> Hi, >> >>> On 04/30/2014 05:16 PM, Alexander Bersenev wrote: >>> This patch introduces Consumer IR(CIR) support for sunxi boards. >>> >>> This is based on Alexsey Shestacov's work based on the original driver= =20 >>> supplied by Allwinner. >>> >>> Signed-off-by: Alexander Bersenev >>> Signed-off-by: Alexsey Shestacov >> >> Alexander, v5 still has various issues which need fixing, >> do you plan to do a v6 soon ? >> >> Regards, >> >> Hans >> >>> >>> --- >>> Changes since version 1:=20 >>> - Fix timer memory leaks=20 >>> - Fix race condition when driver unloads while interrupt handler is act= ive >>> - Support Cubieboard 2(need testing) >>> >>> Changes since version 2: >>> - More reliable keydown events >>> - Documentation fixes >>> - Rename registers accurding to A20 user manual >>> - Remove some includes, order includes alphabetically >>> - Use BIT macro >>> - Typo fixes >>> >>> Changes since version 3: >>> - Split the patch on smaller parts >>> - More documentation fixes >>> - Add clock-names in DT >>> - Use devm_clk_get function to get the clocks >>> - Removed gpios property from ir's DT >>> - Changed compatible from allwinner,sunxi-ir to allwinner,sun7i-a20-ir = in DT >>> - Use spin_lock_irq instead spin_lock_irqsave in interrupt handler >>> - Add myself in the copyright ;) >>> - Coding style and indentation fixes >>> >>> Changes since version 4: >>> - Try to fix indentation errors by sending patches with git send-mail >>> >>> Alexander Bersenev (3): >>> ARM: sunxi: Add documentation for sunxi consumer infrared devices >>> ARM: sunxi: Add driver for sunxi IR controller >>> ARM: sunxi: Add IR controller support in DT on A20 >>> >>> .../devicetree/bindings/media/sunxi-ir.txt | 23 ++ >>> arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 6 + >>> arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 + >>> arch/arm/boot/dts/sun7i-a20.dtsi | 31 +++ >>> drivers/media/rc/Kconfig | 10 + >>> drivers/media/rc/Makefile | 1 + >>> drivers/media/rc/sunxi-ir.c | 303 ++++++++++++++= +++++++ >>> 7 files changed, 380 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/sunxi-ir.txt >>> create mode 100644 drivers/media/rc/sunxi-ir.c >>> --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.