From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms@verge.net.au>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa@sang-engineering.com>
Subject: Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt
Date: Mon, 12 May 2014 16:10:51 +0400 [thread overview]
Message-ID: <5370BA4B.6070003@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdX_19vLyO7fqaBO7=WpdoZ8fYm9BU9Zmj6cXSNDNYE+Kw@mail.gmail.com>
Hello.
On 05/12/2014 11:35 AM, Geert Uytterhoeven wrote:
>>>>>> + eeprom@50 {
>>>>>> + compatible = "renesas,24c02";
>>>>> This is not quite right: Renesas' part is called differently, and
>>>>> you're carrying the other vendor's naming onto Renesas parts. I'd
>>>>> just say "24c02" (which I'll do in the Henninger board patch).
>>>> What about "generic"?
>>> I don't know, really. However, you're right in that there should
>>> be some vendor prefix -- I've just seen
>>> Documentation/devicetree/bindings/eeprom.txt.
>> A quick survey of arch/arm/boot/dts/ yields:
>> "atmel,24c02" (22 times)
>> "microchip,24c02" (once)
>> "mcp,24c02" (once)
>> So it seems to me that precedence is in favour of using "renesas,24c02".
> Except that the Renesas part is called differently (as Sergei already pointed
> out), unlike the Atmel and Microchip parts.
> So it should be:
> compatible = "renesas,r1ex24002", "<something>,24c02";
Unfortunately, that way the legacy I2C driver matching used now won't work
anymore. :-(
> Unfortunately the datasheet doesn't mention compatibility with parts from
> other manufacturers.
> So let's <something> be "atmel"?
Yes, probably. But the "renesas,r1ex24002" part have to be dropped.
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
next prev parent reply other threads:[~2014-05-12 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 10:44 [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Wolfram Sang
2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang
2014-02-17 12:07 ` Magnus Damm
2014-02-18 0:34 ` Simon Horman
2014-05-08 23:54 ` Sergei Shtylyov
2014-05-09 5:06 ` Wolfram Sang
2014-05-09 22:59 ` Sergei Shtylyov
[not found] ` <536D5DC3.3070409-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-11 0:08 ` Simon Horman
2014-05-12 7:35 ` Geert Uytterhoeven
2014-05-12 12:10 ` Sergei Shtylyov [this message]
2014-05-13 0:07 ` Simon Horman
2014-02-17 12:06 ` [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Magnus Damm
2014-02-18 0:29 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370BA4B.6070003@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).