From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch
 dt
Date: Mon, 12 May 2014 16:10:51 +0400
Message-ID: <5370BA4B.6070003@cogentembedded.com>
References: <1392633882-12142-1-git-send-email-wsa@the-dreams.de>	<1392633882-12142-2-git-send-email-wsa@the-dreams.de>	<536C1945.1000601@cogentembedded.com>	<20140509050610.GB2624@katana>	<536D5DC3.3070409@cogentembedded.com>	<20140511000834.GM31760@verge.net.au> <CAMuHMdX_19vLyO7fqaBO7=WpdoZ8fYm9BU9Zmj6cXSNDNYE+Kw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-sh-owner@vger.kernel.org>
In-Reply-To: <CAMuHMdX_19vLyO7fqaBO7=WpdoZ8fYm9BU9Zmj6cXSNDNYE+Kw@mail.gmail.com>
Sender: linux-sh-owner@vger.kernel.org
To: Geert Uytterhoeven <geert@linux-m68k.org>, Simon Horman <horms@verge.net.au>
Cc: Wolfram Sang <wsa@the-dreams.de>, Linux-sh list <linux-sh@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Wolfram Sang <wsa@sang-engineering.com>
List-Id: devicetree@vger.kernel.org

Hello.

On 05/12/2014 11:35 AM, Geert Uytterhoeven wrote:

>>>>>> +  eeprom@50 {
>>>>>> +          compatible = "renesas,24c02";

>>>>>     This is not quite right: Renesas' part is called differently, and
>>>>> you're carrying the other vendor's naming onto Renesas parts. I'd
>>>>> just say "24c02" (which I'll do in the Henninger board patch).

>>>> What about "generic"?

>>>     I don't know, really. However, you're right in that there should
>>> be some vendor prefix -- I've just seen
>>> Documentation/devicetree/bindings/eeprom.txt.

>> A quick survey of arch/arm/boot/dts/ yields:

>> "atmel,24c02" (22 times)
>> "microchip,24c02" (once)
>> "mcp,24c02" (once)

>> So it seems to me that precedence is in favour of using "renesas,24c02".

> Except that the Renesas part is called differently (as Sergei already pointed
> out), unlike the Atmel and Microchip parts.

> So it should be:

>          compatible = "renesas,r1ex24002", "<something>,24c02";

    Unfortunately, that way the legacy I2C driver matching used now won't work 
anymore. :-(

> Unfortunately the datasheet doesn't mention compatibility with parts from
> other manufacturers.

> So let's <something> be "atmel"?

    Yes, probably. But the "renesas,r1ex24002" part have to be dropped.

> Gr{oetje,eeting}s,
>                          Geert

WBR, Sergei