* [PATCH] ARM: shmobile: henninger: add QSPI DT support
@ 2014-05-05 22:45 Sergei Shtylyov
2014-05-11 0:26 ` Simon Horman
2014-05-11 18:17 ` Sergei Shtylyov
0 siblings, 2 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2014-05-05 22:45 UTC (permalink / raw)
To: horms, linux-sh, devicetree
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
magnus.damm, linux, linux-arm-kernel
Define the Henninger board dependent part of the QSPI device node.
Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
@@ -109,6 +109,11 @@
renesas,groups = "sdhi2_data4", "sdhi2_ctrl";
renesas,function = "sdhi2";
};
+
+ qspi_pins: spi0 {
+ renesas,groups = "qspi_ctrl", "qspi_data4";
+ renesas,function = "qspi";
+ };
};
&scif0 {
@@ -158,3 +163,36 @@
cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
status = "okay";
};
+
+&qspi {
+ pinctrl-0 = <&qspi_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "spansion,s25fl512s";
+ reg = <0>;
+ spi-max-frequency = <30000000>;
+ spi-tx-bus-width = <4>;
+ spi-rx-bus-width = <4>;
+ m25p,fast-read;
+
+ partition@0 {
+ label = "loader_prg";
+ reg = <0x00000000 0x00040000>;
+ read-only;
+ };
+ partition@40000 {
+ label = "user_prg";
+ reg = <0x00040000 0x00400000>;
+ read-only;
+ };
+ partition@440000 {
+ label = "flash_fs";
+ reg = <0x00440000 0x03bc0000>;
+ };
+ };
+};
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
2014-05-05 22:45 [PATCH] ARM: shmobile: henninger: add QSPI DT support Sergei Shtylyov
@ 2014-05-11 0:26 ` Simon Horman
2014-05-11 18:17 ` Sergei Shtylyov
1 sibling, 0 replies; 7+ messages in thread
From: Simon Horman @ 2014-05-11 0:26 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
On Tue, May 06, 2014 at 02:45:31AM +0400, Sergei Shtylyov wrote:
> Define the Henninger board dependent part of the QSPI device node.
> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
> 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
>
> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
2014-05-05 22:45 [PATCH] ARM: shmobile: henninger: add QSPI DT support Sergei Shtylyov
2014-05-11 0:26 ` Simon Horman
@ 2014-05-11 18:17 ` Sergei Shtylyov
2014-05-11 22:53 ` Simon Horman
1 sibling, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2014-05-11 18:17 UTC (permalink / raw)
To: horms, linux-sh, devicetree
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
magnus.damm, linux, linux-arm-kernel
Hello.
On 05/06/2014 02:45 AM, Sergei Shtylyov wrote:
> Define the Henninger board dependent part of the QSPI device node.
> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
> 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
> +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
[...]
> @@ -158,3 +163,36 @@
> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
> +
> +&qspi {
> + pinctrl-0 = <&qspi_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "spansion,s25fl512s";
> + reg = <0>;
> + spi-max-frequency = <30000000>;
> + spi-tx-bus-width = <4>;
> + spi-rx-bus-width = <4>;
> + m25p,fast-read;
> +
> + partition@0 {
> + label = "loader_prg";
> + reg = <0x00000000 0x00040000>;
> + read-only;
> + };
> + partition@40000 {
> + label = "user_prg";
> + reg = <0x00040000 0x00400000>;
> + read-only;
Oops, there shouldn't be "read-only" here, I forgot to refresh the patch
as I'm now seeing... too bad it's too late to resend now. :-(
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
2014-05-11 18:17 ` Sergei Shtylyov
@ 2014-05-11 22:53 ` Simon Horman
2014-05-12 11:53 ` Sergei Shtylyov
2014-05-12 22:57 ` Sergei Shtylyov
0 siblings, 2 replies; 7+ messages in thread
From: Simon Horman @ 2014-05-11 22:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
On Sun, May 11, 2014 at 10:17:27PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/06/2014 02:45 AM, Sergei Shtylyov wrote:
>
> >Define the Henninger board dependent part of the QSPI device node.
> >Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>
> >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >---
> >This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
> >'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
>
> > arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
>
> >Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> >===================================================================
> >--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
> >+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> [...]
> >@@ -158,3 +163,36 @@
> > cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
> > status = "okay";
> > };
> >+
> >+&qspi {
> >+ pinctrl-0 = <&qspi_pins>;
> >+ pinctrl-names = "default";
> >+
> >+ status = "okay";
> >+
> >+ flash@0 {
> >+ #address-cells = <1>;
> >+ #size-cells = <1>;
> >+ compatible = "spansion,s25fl512s";
> >+ reg = <0>;
> >+ spi-max-frequency = <30000000>;
> >+ spi-tx-bus-width = <4>;
> >+ spi-rx-bus-width = <4>;
> >+ m25p,fast-read;
> >+
> >+ partition@0 {
> >+ label = "loader_prg";
> >+ reg = <0x00000000 0x00040000>;
> >+ read-only;
> >+ };
> >+ partition@40000 {
> >+ label = "user_prg";
> >+ reg = <0x00040000 0x00400000>;
> >+ read-only;
>
> Oops, there shouldn't be "read-only" here, I forgot to refresh
> the patch as I'm now seeing... too bad it's too late to resend now.
> :-(
Could you send an incremental fix for me to queue up?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
2014-05-11 22:53 ` Simon Horman
@ 2014-05-12 11:53 ` Sergei Shtylyov
2014-05-12 22:57 ` Sergei Shtylyov
1 sibling, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2014-05-12 11:53 UTC (permalink / raw)
To: Simon Horman
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
Hello.
On 05/12/2014 02:53 AM, Simon Horman wrote:
>>> Define the Henninger board dependent part of the QSPI device node.
>>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>> ---
>>> This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
>>> 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
>>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
>>> 1 file changed, 38 insertions(+)
>>> Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
>>> ===================================================================
>>> --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
>>> +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
>> [...]
>>> @@ -158,3 +163,36 @@
>>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
>>> status = "okay";
>>> };
>>> +
>>> +&qspi {
>>> + pinctrl-0 = <&qspi_pins>;
>>> + pinctrl-names = "default";
>>> +
>>> + status = "okay";
>>> +
>>> + flash@0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "spansion,s25fl512s";
>>> + reg = <0>;
>>> + spi-max-frequency = <30000000>;
>>> + spi-tx-bus-width = <4>;
>>> + spi-rx-bus-width = <4>;
>>> + m25p,fast-read;
>>> +
>>> + partition@0 {
>>> + label = "loader_prg";
>>> + reg = <0x00000000 0x00040000>;
>>> + read-only;
>>> + };
>>> + partition@40000 {
>>> + label = "user_prg";
>>> + reg = <0x00040000 0x00400000>;
>>> + read-only;
>> Oops, there shouldn't be "read-only" here, I forgot to refresh
>> the patch as I'm now seeing... too bad it's too late to resend now.
>> :-(
> Could you send an incremental fix for me to queue up?
Yes, I will.
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
2014-05-11 22:53 ` Simon Horman
2014-05-12 11:53 ` Sergei Shtylyov
@ 2014-05-12 22:57 ` Sergei Shtylyov
2014-05-13 0:10 ` Simon Horman
1 sibling, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2014-05-12 22:57 UTC (permalink / raw)
To: Simon Horman
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
Hello.
On 05/12/2014 02:53 AM, Simon Horman wrote:
>>> Define the Henninger board dependent part of the QSPI device node.
>>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>> ---
>>> This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
>>> 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
>>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
>>> 1 file changed, 38 insertions(+)
>>> Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
>>> ===================================================================
>>> --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
>>> +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
>> [...]
>>> @@ -158,3 +163,36 @@
>>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
>>> status = "okay";
>>> };
>>> +
>>> +&qspi {
>>> + pinctrl-0 = <&qspi_pins>;
>>> + pinctrl-names = "default";
>>> +
>>> + status = "okay";
>>> +
>>> + flash@0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "spansion,s25fl512s";
>>> + reg = <0>;
>>> + spi-max-frequency = <30000000>;
>>> + spi-tx-bus-width = <4>;
>>> + spi-rx-bus-width = <4>;
>>> + m25p,fast-read;
>>> +
>>> + partition@0 {
>>> + label = "loader_prg";
>>> + reg = <0x00000000 0x00040000>;
>>> + read-only;
>>> + };
>>> + partition@40000 {
>>> + label = "user_prg";
>>> + reg = <0x00040000 0x00400000>;
>>> + read-only;
>> Oops, there shouldn't be "read-only" here, I forgot to refresh
>> the patch as I'm now seeing... too bad it's too late to resend now.
>> :-(
> Could you send an incremental fix for me to queue up?
Oops, I've rechecked and it should indeed be read-only, so the patch was
correct. Sorry. :-)
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
2014-05-12 22:57 ` Sergei Shtylyov
@ 2014-05-13 0:10 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2014-05-13 0:10 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
On Tue, May 13, 2014 at 02:57:30AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/12/2014 02:53 AM, Simon Horman wrote:
>
> >>>Define the Henninger board dependent part of the QSPI device node.
> >>>Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>>---
> >>>This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
> >>>'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
>
> >>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
> >>> 1 file changed, 38 insertions(+)
>
> >>>Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> >>>===================================================================
> >>>--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
> >>>+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> >>[...]
> >>>@@ -158,3 +163,36 @@
> >>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
> >>> status = "okay";
> >>> };
> >>>+
> >>>+&qspi {
> >>>+ pinctrl-0 = <&qspi_pins>;
> >>>+ pinctrl-names = "default";
> >>>+
> >>>+ status = "okay";
> >>>+
> >>>+ flash@0 {
> >>>+ #address-cells = <1>;
> >>>+ #size-cells = <1>;
> >>>+ compatible = "spansion,s25fl512s";
> >>>+ reg = <0>;
> >>>+ spi-max-frequency = <30000000>;
> >>>+ spi-tx-bus-width = <4>;
> >>>+ spi-rx-bus-width = <4>;
> >>>+ m25p,fast-read;
> >>>+
> >>>+ partition@0 {
> >>>+ label = "loader_prg";
> >>>+ reg = <0x00000000 0x00040000>;
> >>>+ read-only;
> >>>+ };
> >>>+ partition@40000 {
> >>>+ label = "user_prg";
> >>>+ reg = <0x00040000 0x00400000>;
> >>>+ read-only;
>
> >> Oops, there shouldn't be "read-only" here, I forgot to refresh
> >>the patch as I'm now seeing... too bad it's too late to resend now.
> >>:-(
>
> >Could you send an incremental fix for me to queue up?
>
> Oops, I've rechecked and it should indeed be read-only, so the
> patch was correct. Sorry. :-)
Thanks for double checking.
I think we can safely do nothing for now :-)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-13 0:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-05 22:45 [PATCH] ARM: shmobile: henninger: add QSPI DT support Sergei Shtylyov
2014-05-11 0:26 ` Simon Horman
2014-05-11 18:17 ` Sergei Shtylyov
2014-05-11 22:53 ` Simon Horman
2014-05-12 11:53 ` Sergei Shtylyov
2014-05-12 22:57 ` Sergei Shtylyov
2014-05-13 0:10 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).