devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels
@ 2014-05-15 10:25 Philipp Zabel
  2014-05-15 10:54 ` Thierry Reding
  0 siblings, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2014-05-15 10:25 UTC (permalink / raw)
  To: Thierry Reding; +Cc: devicetree, Stefan Agner, kernel, dri-devel

The EDT ETM0700G0DH6 and ET070080DH6 are 7" 800x480 panels,
which can be supported by the simple panel driver.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Changes since v2:
 - Added device tree binding documentation. Do we really want to add one little
   file for each panel?
---
 .../devicetree/bindings/panel/edt,et070080dh6.txt  | 10 ++++++++
 .../devicetree/bindings/panel/edt,etm0700g0dh6.txt | 10 ++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 29 ++++++++++++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/panel/edt,et070080dh6.txt
 create mode 100644 Documentation/devicetree/bindings/panel/edt,etm0700g0dh6.txt

diff --git a/Documentation/devicetree/bindings/panel/edt,et070080dh6.txt b/Documentation/devicetree/bindings/panel/edt,et070080dh6.txt
new file mode 100644
index 0000000..20cb38e
--- /dev/null
+++ b/Documentation/devicetree/bindings/panel/edt,et070080dh6.txt
@@ -0,0 +1,10 @@
+Emerging Display Technology Corp. ET070080DH6 7.0" WVGA TFT LCD panel
+
+Required properties:
+- compatible: should be "edt,et070080dh6"
+
+This panel is the same as ETM0700G0DH6 except for the touchscreen.
+ET070080DH6 is the model with resistive touch.
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/Documentation/devicetree/bindings/panel/edt,etm0700g0dh6.txt b/Documentation/devicetree/bindings/panel/edt,etm0700g0dh6.txt
new file mode 100644
index 0000000..ee4b180
--- /dev/null
+++ b/Documentation/devicetree/bindings/panel/edt,etm0700g0dh6.txt
@@ -0,0 +1,10 @@
+Emerging Display Technology Corp. ETM0700G0DH6 7.0" WVGA TFT LCD panel
+
+Required properties:
+- compatible: should be "edt,etm0700g0dh6"
+
+This panel is the same as ET070080DH6 except for the touchscreen.
+ETM0700G0DH6 is the model with capacitive multitouch.
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 309f29e..72da48c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -328,6 +328,29 @@ static const struct panel_desc chunghwa_claa101wb01 = {
 	},
 };
 
+static const struct drm_display_mode edt_etm0700g0dh6_mode = {
+	.clock = 33260,
+	.hdisplay = 800,
+	.hsync_start = 800 + 40,
+	.hsync_end = 800 + 40 + 128,
+	.htotal = 800 + 40 + 128 + 88,
+	.vdisplay = 480,
+	.vsync_start = 480 + 10,
+	.vsync_end = 480 + 10 + 2,
+	.vtotal = 480 + 10 + 2 + 33,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc edt_etm0700g0dh6 = {
+	.modes = &edt_etm0700g0dh6_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+};
+
 static const struct drm_display_mode lg_lp129qe_mode = {
 	.clock = 285250,
 	.hdisplay = 2560,
@@ -383,6 +406,12 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "chunghwa,claa101wb01",
 		.data = &chunghwa_claa101wb01
 	}, {
+		.compatible = "edt,et070080dh6",
+		.data = &edt_etm0700g0dh6,
+	}, {
+		.compatible = "edt,etm0700g0dh6",
+		.data = &edt_etm0700g0dh6,
+	}, {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
 	}, {
-- 
2.0.0.rc0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels
  2014-05-15 10:25 [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels Philipp Zabel
@ 2014-05-15 10:54 ` Thierry Reding
  2014-05-15 15:54   ` Stephen Warren
  0 siblings, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2014-05-15 10:54 UTC (permalink / raw)
  To: Philipp Zabel; +Cc: devicetree, dri-devel, Thierry Reding, kernel, Stefan Agner


[-- Attachment #1.1: Type: text/plain, Size: 960 bytes --]

On Thu, May 15, 2014 at 12:25:47PM +0200, Philipp Zabel wrote:
> The EDT ETM0700G0DH6 and ET070080DH6 are 7" 800x480 panels,
> which can be supported by the simple panel driver.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> Changes since v2:
>  - Added device tree binding documentation. Do we really want to add one little
>    file for each panel?

I guess we could move all of the compatible values into simple-panel.txt
but I don't see a need for that yet.

> ---
>  .../devicetree/bindings/panel/edt,et070080dh6.txt  | 10 ++++++++
>  .../devicetree/bindings/panel/edt,etm0700g0dh6.txt | 10 ++++++++
>  drivers/gpu/drm/panel/panel-simple.c               | 29 ++++++++++++++++++++++
>  3 files changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/panel/edt,et070080dh6.txt
>  create mode 100644 Documentation/devicetree/bindings/panel/edt,etm0700g0dh6.txt

Applied, thanks.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels
  2014-05-15 10:54 ` Thierry Reding
@ 2014-05-15 15:54   ` Stephen Warren
  2014-05-15 21:41     ` Thierry Reding
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Warren @ 2014-05-15 15:54 UTC (permalink / raw)
  To: Thierry Reding, Philipp Zabel
  Cc: devicetree, dri-devel, Thierry Reding, kernel, Stefan Agner

On 05/15/2014 04:54 AM, Thierry Reding wrote:
> On Thu, May 15, 2014 at 12:25:47PM +0200, Philipp Zabel wrote:
>> The EDT ETM0700G0DH6 and ET070080DH6 are 7" 800x480 panels,
>> which can be supported by the simple panel driver.
>>
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>> Changes since v2:
>>  - Added device tree binding documentation. Do we really want to add one little
>>    file for each panel?
> 
> I guess we could move all of the compatible values into simple-panel.txt
> but I don't see a need for that yet.

If they aren't added there, then I believe checkpatch will complain
about patches that start to use the new compatible values, since they
won't be documented.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels
  2014-05-15 15:54   ` Stephen Warren
@ 2014-05-15 21:41     ` Thierry Reding
  2014-05-15 21:48       ` Stephen Warren
  0 siblings, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2014-05-15 21:41 UTC (permalink / raw)
  To: Stephen Warren
  Cc: devicetree, dri-devel, Stefan Agner, kernel, Thierry Reding


[-- Attachment #1.1: Type: text/plain, Size: 900 bytes --]

On Thu, May 15, 2014 at 09:54:07AM -0600, Stephen Warren wrote:
> On 05/15/2014 04:54 AM, Thierry Reding wrote:
> > On Thu, May 15, 2014 at 12:25:47PM +0200, Philipp Zabel wrote:
> >> The EDT ETM0700G0DH6 and ET070080DH6 are 7" 800x480 panels,
> >> which can be supported by the simple panel driver.
> >>
> >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >> ---
> >> Changes since v2:
> >>  - Added device tree binding documentation. Do we really want to add one little
> >>    file for each panel?
> > 
> > I guess we could move all of the compatible values into simple-panel.txt
> > but I don't see a need for that yet.
> 
> If they aren't added there, then I believe checkpatch will complain
> about patches that start to use the new compatible values, since they
> won't be documented.

Added where? simple-panel.txt or in separate files per compatible?

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels
  2014-05-15 21:41     ` Thierry Reding
@ 2014-05-15 21:48       ` Stephen Warren
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Warren @ 2014-05-15 21:48 UTC (permalink / raw)
  To: Thierry Reding
  Cc: devicetree, dri-devel, Stefan Agner, kernel, Thierry Reding

On 05/15/2014 03:41 PM, Thierry Reding wrote:
> On Thu, May 15, 2014 at 09:54:07AM -0600, Stephen Warren wrote:
>> On 05/15/2014 04:54 AM, Thierry Reding wrote:
>>> On Thu, May 15, 2014 at 12:25:47PM +0200, Philipp Zabel wrote:
>>>> The EDT ETM0700G0DH6 and ET070080DH6 are 7" 800x480 panels,
>>>> which can be supported by the simple panel driver.
>>>>
>>>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>>>> ---
>>>> Changes since v2:
>>>>  - Added device tree binding documentation. Do we really want to add one little
>>>>    file for each panel?
>>>
>>> I guess we could move all of the compatible values into simple-panel.txt
>>> but I don't see a need for that yet.
>>
>> If they aren't added there, then I believe checkpatch will complain
>> about patches that start to use the new compatible values, since they
>> won't be documented.
> 
> Added where? simple-panel.txt or in separate files per compatible?

I assume that checkpatch simply checks all files in
Documentation/devicetree/bindings. By "there", I meant "somewhere in
that directory".

Perhaps I misinterpreted the email I was replying to; I thought you'd
meant that we didn't need to document it yet, but it looks like you were
simply discussing where to document it. Sorry for the noise.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-05-15 21:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 10:25 [PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels Philipp Zabel
2014-05-15 10:54 ` Thierry Reding
2014-05-15 15:54   ` Stephen Warren
2014-05-15 21:41     ` Thierry Reding
2014-05-15 21:48       ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).