devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Andrew Bresticker <abrestic@chromium.org>,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Russell King <linux@arm.linux.org.uk>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Kumar Gala <galak@codeaurora.org>,
	Grant Likely <grant.likely@linaro.org>,
	Mike Turquette <mturquette@linaro.org>
Subject: Re: [RFC PATCH 05/10] ARM: tegra: Export function to read USB calibration data
Date: Thu, 15 May 2014 14:39:07 -0600	[thread overview]
Message-ID: <537525EB.9090704@wwwdotorg.org> (raw)
In-Reply-To: <1400113986-339-6-git-send-email-abrestic@chromium.org>

On 05/14/2014 06:33 PM, Andrew Bresticker wrote:
> Board-specific USB configuration data is stored in FUSE_SKU_CALIB_0.
> Export a function to read it so the PHY can be properly configured.

This patch seems conceptually fine to me. Presumably once Peter's fuse
driver is fleshed out, it can expose the exact same semantic interface
to drivers.

I suppose one could argue that we should create/use an explicit fuse
subsystem with a standard API that drivers can call into, rather than a
custom API. We can get the appropriate handle to use for that API from a
phandle (plus fuse IDs?) in a DT property (in the XHCI device node,
pointing at the fuse device node) much like any other cross-device
resource reference. I'm not too bothered whether the code actually does
that in the first instance, although we should make sure we add that DT
property (containing all required fuse ID information) so that the code
/can/ work that way if we want it to in the future.

  reply	other threads:[~2014-05-15 20:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15  0:32 [RFC PATCH 00/10] Tegra XHCI support Andrew Bresticker
2014-05-15  0:32 ` [RFC PATCH 01/10] clk: tegra: Enable hardware control of PLLE Andrew Bresticker
2014-05-15  0:32 ` [RFC PATCH 02/10] clk: tegra: Fix xusb_fs_src mux Andrew Bresticker
2014-05-15  0:32 ` [RFC PATCH 03/10] clk: tegra: Fix xusb_hs_src clock hierarchy Andrew Bresticker
2014-05-15  0:33 ` [RFC PATCH 04/10] clk: tegra: Initialize xusb clocks Andrew Bresticker
     [not found]   ` <1400113986-339-5-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-15 19:22     ` Stephen Warren
     [not found]       ` <537513D8.7060203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-20 15:41         ` Peter De Schrijver
2014-05-15  0:33 ` [RFC PATCH 05/10] ARM: tegra: Export function to read USB calibration data Andrew Bresticker
2014-05-15 20:39   ` Stephen Warren [this message]
2014-05-15  0:33 ` [RFC PATCH 07/10] phy: Add Tegra XUSB PHY driver Andrew Bresticker
     [not found] ` <1400113986-339-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-15  0:33   ` [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver Andrew Bresticker
     [not found]     ` <1400113986-339-7-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-15  8:17       ` Arnd Bergmann
2014-05-15  9:19         ` Thierry Reding
2014-05-15 13:30           ` Arnd Bergmann
2014-05-15 20:18         ` Andrew Bresticker
     [not found]           ` <CAL1qeaHm7U2NVDeVZS-Tiz5ntkk4c13RR_1ws9MTYGGoGCOB5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-15 21:16             ` Alan Stern
2014-05-15 21:18             ` Thierry Reding
2014-05-16 16:52               ` Andrew Bresticker
2014-05-15  0:33   ` [RFC PATCH 08/10] ARM: tegra124: Bind CAR to syscon device Andrew Bresticker
     [not found]     ` <1400113986-339-9-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-15 19:25       ` Stephen Warren
     [not found]         ` <5375148E.6040905-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-15 20:22           ` Andrew Bresticker
2014-05-15  0:33   ` [RFC PATCH 09/10] ARM: tegra124: Add XHCI controller and PHY Andrew Bresticker
2014-05-15  0:33   ` [RFC PATCH 10/10] ARM: tegra124: Enable XHCI on Venice2 Andrew Bresticker
2014-05-15 19:33   ` [RFC PATCH 00/10] Tegra XHCI support Stephen Warren
     [not found]     ` <5375169F.3060809-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-15 20:44       ` Andrew Bresticker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537525EB.9090704@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=abrestic@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mathias.nyman@intel.com \
    --cc=mturquette@linaro.org \
    --cc=pawel.moll@arm.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).