From: Tomasz Figa <tomasz.figa@gmail.com>
To: Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
"mark.rutland" <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
devicetree <devicetree@vger.kernel.org>,
Andrew Bresticker <abrestic@chromium.org>,
Tomasz Figa <t.figa@samsung.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>,
skon.hwang@samsung.com, robh+dt <robh+dt@kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Thomas P Abraham <thomas.ab@samsung.com>,
Grant Likely <grant.likely@linaro.org>,
Jonghwan Choi <jhbird.choi@samsung.com>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"inderpal.s@samsung.com" <inderpal.s@samsung.com>
Subject: Re: [PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs
Date: Thu, 15 May 2014 23:11:40 +0200 [thread overview]
Message-ID: <53752D8C.3030708@gmail.com> (raw)
In-Reply-To: <CAM4voamSNYZ_hsjF3eZhqZ=FF__39tFgi5FeXRcUhRbYYzu0LQ@mail.gmail.com>
Hi Abhilash,
On 13.05.2014 12:12, Abhilash Kesavan wrote:
> On Tue, May 13, 2014 at 7:54 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
[snip]
>>> diff --git a/arch/arm/mach-exynos/regs-pmu.h b/arch/arm/mach-exynos/regs-
>>> pmu.h
>>> index 4f6a256..0bdfcbc 100644
>>> --- a/arch/arm/mach-exynos/regs-pmu.h
>>> +++ b/arch/arm/mach-exynos/regs-pmu.h
>>> @@ -121,6 +121,12 @@
>>>
>>> #define S5P_CHECK_SLEEP 0x00000BAD
>>>
>>> +#define EXYNOS_ARM_CORE0_CONFIGURATION S5P_PMUREG(0x2000)
>>
>> This can be put in order of address.
> OK, will fix.
>>
>>> +#define EXYNOS_ARM_CORE_CONFIGURATION(_nr) \
>>> + (EXYNOS_ARM_CORE0_CONFIGURATION + (0x80 * (_nr)))
>>> +#define EXYNOS_ARM_CORE_STATUS(_nr) \
>>> + (EXYNOS_ARM_CORE_CONFIGURATION(_nr) + 0x4)
My patches posted quite a while ago [1] to fix DT CPU topology already
add these, remove S5P_ARM_CORE1* and fix corresponding usage in
hotplug.c and platsmp.c.
[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29573
So I think you should rebase on top of them or at least on top of
patches 1 and 2 from that series, as 3 and 4 should be dropped.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-15 21:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 16:26 [PATCH v5 0/5] MCPM backend for Exynos5420 Abhilash Kesavan
[not found] ` <1399307221-8659-1-git-send-email-a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-05 16:26 ` [PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs Abhilash Kesavan
2014-05-13 2:24 ` Kukjin Kim
2014-05-13 10:12 ` Abhilash Kesavan
2014-05-15 21:11 ` Tomasz Figa [this message]
2014-05-16 5:07 ` Abhilash Kesavan
2014-05-17 0:32 ` Tomasz Figa
2014-05-19 2:42 ` Abhilash Kesavan
2014-05-05 16:26 ` [PATCH v5 2/5] ARM: EXYNOS: use generic exynos cpu power control functions Abhilash Kesavan
2014-05-13 2:28 ` Kukjin Kim
2014-05-13 10:13 ` Abhilash Kesavan
2014-05-05 16:27 ` [PATCH v5 4/5] ARM: dts: exynos5420: add CCI node Abhilash Kesavan
2014-05-05 16:26 ` [PATCH v5 3/5] arm: exynos: Add generic cluster power control functions Abhilash Kesavan
2014-05-05 16:27 ` [PATCH v5 5/5] arm: exynos: Add MCPM call-back functions Abhilash Kesavan
2014-05-05 18:12 ` Nicolas Pitre
2014-05-27 11:07 ` Arnd Bergmann
2014-05-27 11:39 ` Kukjin Kim
2014-05-27 14:25 ` Abhilash Kesavan
2014-05-27 15:17 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53752D8C.3030708@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=Dave.Martin@arm.com \
--cc=abrestic@chromium.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=jhbird.choi@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.pitre@linaro.org \
--cc=robh+dt@kernel.org \
--cc=skon.hwang@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).