devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: zynq: dt: Add a fixed regulator for CPU voltage
@ 2014-05-02 21:07 Soren Brinkmann
  2014-05-15 14:57 ` Sören Brinkmann
  0 siblings, 1 reply; 3+ messages in thread
From: Soren Brinkmann @ 2014-05-02 21:07 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Michal Simek
  Cc: devicetree, linux-arm-kernel, linux-kernel, git, Soren Brinkmann

To silence the warning
	cpufreq_cpu0: failed to get cpu0 regulator: -19
from the cpufreq driver regarding a missing regulator,
add a fixed regulator to the DT.
Zynq does not support voltage scaling and the CPU rail should always be
supplied with 1 V, hence it is added in the SOC-level dtsi.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---

 arch/arm/boot/dts/zynq-7000.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index c1176abc34d9..64779f9d5c38 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -25,6 +25,7 @@
 			reg = <0>;
 			clocks = <&clkc 3>;
 			clock-latency = <1000>;
+			cpu0-supply = <&regulator_vccpint>;
 			operating-points = <
 				/* kHz    uV */
 				666667  1000000
@@ -48,6 +49,15 @@
 		reg = < 0xf8891000 0x1000 0xf8893000 0x1000 >;
 	};
 
+	regulator_vccpint: fixedregulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCCPINT";
+		regulator-min-microvolt = <1000000>;
+		regulator-max-microvolt = <1000000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
 	amba {
 		compatible = "simple-bus";
 		#address-cells = <1>;
-- 
1.9.2.1.g06c4abd

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: zynq: dt: Add a fixed regulator for CPU voltage
  2014-05-02 21:07 [PATCH] ARM: zynq: dt: Add a fixed regulator for CPU voltage Soren Brinkmann
@ 2014-05-15 14:57 ` Sören Brinkmann
  2014-05-16 12:54   ` Michal Simek
  0 siblings, 1 reply; 3+ messages in thread
From: Sören Brinkmann @ 2014-05-15 14:57 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Michal Simek
  Cc: devicetree, linux-arm-kernel, linux-kernel, git

ping? Any comments?

	Thanks,
	Sören

On Fri, 2014-05-02 at 02:07PM -0700, Soren Brinkmann wrote:
> To silence the warning
> 	cpufreq_cpu0: failed to get cpu0 regulator: -19
> from the cpufreq driver regarding a missing regulator,
> add a fixed regulator to the DT.
> Zynq does not support voltage scaling and the CPU rail should always be
> supplied with 1 V, hence it is added in the SOC-level dtsi.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index c1176abc34d9..64779f9d5c38 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -25,6 +25,7 @@
>  			reg = <0>;
>  			clocks = <&clkc 3>;
>  			clock-latency = <1000>;
> +			cpu0-supply = <&regulator_vccpint>;
>  			operating-points = <
>  				/* kHz    uV */
>  				666667  1000000
> @@ -48,6 +49,15 @@
>  		reg = < 0xf8891000 0x1000 0xf8893000 0x1000 >;
>  	};
>  
> +	regulator_vccpint: fixedregulator@0 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VCCPINT";
> +		regulator-min-microvolt = <1000000>;
> +		regulator-max-microvolt = <1000000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +
>  	amba {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
> -- 
> 1.9.2.1.g06c4abd
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: zynq: dt: Add a fixed regulator for CPU voltage
  2014-05-15 14:57 ` Sören Brinkmann
@ 2014-05-16 12:54   ` Michal Simek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2014-05-16 12:54 UTC (permalink / raw)
  To: Sören Brinkmann, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, Michal Simek
  Cc: devicetree, linux-arm-kernel, linux-kernel, git

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On 05/15/2014 04:57 PM, Sören Brinkmann wrote:
> ping? Any comments?
> 
> 	Thanks,
> 	Sören
> 
> On Fri, 2014-05-02 at 02:07PM -0700, Soren Brinkmann wrote:
>> To silence the warning
>> 	cpufreq_cpu0: failed to get cpu0 regulator: -19
>> from the cpufreq driver regarding a missing regulator,
>> add a fixed regulator to the DT.
>> Zynq does not support voltage scaling and the CPU rail should always be
>> supplied with 1 V, hence it is added in the SOC-level dtsi.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> ---
>>
>>  arch/arm/boot/dts/zynq-7000.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)

Probably no objection from others.
Applied to zynq/dt branch.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-16 12:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-02 21:07 [PATCH] ARM: zynq: dt: Add a fixed regulator for CPU voltage Soren Brinkmann
2014-05-15 14:57 ` Sören Brinkmann
2014-05-16 12:54   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).