From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A5192BDC09; Tue, 18 Nov 2025 11:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763466380; cv=none; b=oc6XO7DTHYPTHkbB8W7VZSCbHTFNmCd7MQtaJFcgCA7AaKFB6euYaN4zihwRD+kWVpEntIT7e94aS453oFS5bFl2nAD3JvZzpC60dHmAJPDDtHlHaEfY6LJOsg+hOzjWt3vMxaUlySqpiyYk29YZBi+JZTPKx/cFEezwS4mKN2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763466380; c=relaxed/simple; bh=W/JkQ4U0diGESZkOi7amWyGqbWa3KCEdmeCe0IkPCXU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=j67dQO/q+xfnIifSgJL3rOI+krJCcj1YdCZ14Ly+Cj0HQzi/isrBeyrFdL5cR1CEg/JKePyQFZvGoVukuAoXjMb+jhsmSnUG2r8Uf0tPrYiuzNsTgLs/aExyAUz6GuJ9mLRIUWriaJMDbcFajzasvPjzc8xY5FKVC1vCMdXRyyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qPgFpH/T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qPgFpH/T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB967C4CEFB; Tue, 18 Nov 2025 11:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763466378; bh=W/JkQ4U0diGESZkOi7amWyGqbWa3KCEdmeCe0IkPCXU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=qPgFpH/T5wVLQFRc/P3GWh9cu7skFIGpVGfvKdvCDqDz4V8zEUoqtu4+XO5OHwr3o Wmko2YNu1UVd0gLpmxWhZnaxlfyJJEOL1ETtNRAui8qUd3jQXwh1pKWLuxAf3X1VB8 kXHmr/Kn4MGe24UcuJllNtxWBXQzDNmO1YWFB0Rl87Yl16h9pVFsf7+1H9BTiLY2Ab 6tEJGxv7lARGeutg4EwQwcDZBJQvAKqlVWi2eMEevS4nMpt8Oh208L2qCqKraXjh9h 9if48VtzhGakO1MKUygIozNVU+L2Rt14WTF0nrvA+XpArJfB9mcpitYwokktQIL3m4 NV76wO41dzbWw== Message-ID: <5377db69-13d2-4ee2-b5d4-d9d4ae681848@kernel.org> Date: Tue, 18 Nov 2025 12:46:11 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] firmware: qcom: scm: Register gunyah watchdog device From: Krzysztof Kozlowski To: Kathiravan Thirumoorthy , hrishabh.rajput@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pavan Kondeti , Neil Armstrong , Dmitry Baryshkov , Shivendra Pratap References: <20251118-gunyah_watchdog-v8-0-e5de12e2eef5@oss.qualcomm.com> <20251118-gunyah_watchdog-v8-1-e5de12e2eef5@oss.qualcomm.com> <88e538ee-9e70-4249-bee5-5127d344edad@oss.qualcomm.com> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/11/2025 12:32, Krzysztof Kozlowski wrote: > On 18/11/2025 12:18, Kathiravan Thirumoorthy wrote: >> >> On 11/18/2025 4:10 PM, Hrishabh Rajput via B4 Relay wrote: >>> From: Hrishabh Rajput >>> >>> To restrict Gunyah watchdog initialization to Qualcomm platforms running >>> under the Gunyah Hypervisor, register the watchdog device in the QCOM >>> SCM driver. >>> >>> When Gunyah is not present or Gunyah emulates MMIO-based watchdog, we >>> expect Qualcomm watchdog or ARM SBSA watchdog device to be present in >>> the devicetree. First, we make sure we're running under the Gunyah >>> Hypervisor. Then we move to check if any of the above mentioned >>> watchdog device nodes are present, if not then we proceed to register >>> the SMC-based Gunyah watchdog device. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Tested-by: Shivendra Pratap >>> Tested-by: Neil Armstrong >>> Signed-off-by: Hrishabh Rajput >>> --- >>> drivers/firmware/qcom/qcom_scm.c | 53 ++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 53 insertions(+) >>> >>> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c >>> index e777b7cb9b12..14d0663316e6 100644 >>> --- a/drivers/firmware/qcom/qcom_scm.c >>> +++ b/drivers/firmware/qcom/qcom_scm.c >>> @@ -2182,6 +2182,56 @@ int qcom_scm_qtee_callback_response(phys_addr_t buf, size_t buf_size, >>> } >>> EXPORT_SYMBOL(qcom_scm_qtee_callback_response); >>> >>> +static void qcom_scm_gunyah_wdt_free(void *data) >>> +{ >>> + struct platform_device *gunyah_wdt_dev = data; >>> + >>> + platform_device_unregister(gunyah_wdt_dev); >>> +} >>> + >>> +static void qcom_scm_gunyah_wdt_init(struct qcom_scm *scm) >>> +{ >>> + struct platform_device *gunyah_wdt_dev; >>> + struct device_node *np; >> >> nit: Can we use the __cleanup() attribute for device_node like below and >> drop the explicit of_node_put()? >> >> struct device_node *np __free(device_node) = NULL; > > Please don't. It is not desired style, error prone and not helping. > > Don't use cleanup.h if you are not accustomed to its specific style. Good that you linked here your patches, so I can NAK everything. That's very poor idea. Simple, readable code you transform into buggy, error-prone discouraged style. In all your patches the code was left like this ON PURPOSE. Best regards, Krzysztof