From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDF4C43334 for ; Fri, 10 Jun 2022 10:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348512AbiFJKF5 (ORCPT ); Fri, 10 Jun 2022 06:05:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347388AbiFJKF4 (ORCPT ); Fri, 10 Jun 2022 06:05:56 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 373A8B57B3 for ; Fri, 10 Jun 2022 03:05:55 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id b8so17912789edj.11 for ; Fri, 10 Jun 2022 03:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=Q5vsmxWtwaYG8oW1AvQlgwQ8iE5Q0pMcGpxfbWiaZG0=; b=mAwnc2FFbtLQIpZr3EhYJcGHEjUDTrbX5Jx0lJTRxxZ0qBjgwzPJoDo1t/rjo0CWE3 yerDl7ktV0DQWz4+QGdECsB949KbT+RbfG3jjSbSDHNcLk/Qq32eONfK5Y+syiadgwxc ksxL5klIEiyxCxjJvC8ufzFhxN2Xdp4ryDJ2tg7eEFag1jBlUpf70OVlutNMCQvvFixk 895brrs4P/H1ae1l2GIH/45CaIzX/PQ3r60ns2tsqGQzOzuj0bVlcbrTvxO6/D2WULPH VqEwY5ydtSucv3FLVw+nIzGu2j0Jn0IuF9KeJQMxm25MK3JNOoeX21Lku7r4L+7+wnEq em5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Q5vsmxWtwaYG8oW1AvQlgwQ8iE5Q0pMcGpxfbWiaZG0=; b=15MlTU1mWEvRwMiMMldrs3bK1Qp8YxN3CGsXXXTWydo4+csmSRxwhWRVfyTtJ4y5ld itCi7rM56ljYoi/appntRJskNyvoBtGCVVJdoOANB3x39rQEJg7wDc3hX77hNxKWccH+ 3Cu4/G/PM+59qXh6ATuoFnIkWdwyqNr9feNDKlKdDpC7HY3zI4Uq4cYKM6qndGYGk+22 glWeuSNnazN7SvL0kVqRO8LV1h2KiT1+HvGla6ZDn9lXfwIE6qGOoaaYgu8zHdVDBP+E 9Xz/U/Te38zTkWdWs4gvOlFTvfyTNJU1n8AeegW41HADL1IFTrhq03+t07Knjv3otmg3 6dOA== X-Gm-Message-State: AOAM532vhQJbG5EPECj8gwo/paAYp9CC2ElVD0LXNAO19L2e4nKBINww ekVM4hm+1U0VwHi2KTIGuA0STw== X-Google-Smtp-Source: ABdhPJw+10Yv7YpKYQWS1YFaBYbE6qXvaEMzJNgXTJK+zRmZH81nGhz+1LAX3otPNb4lPpztjPphrw== X-Received: by 2002:a05:6402:50:b0:431:69fc:eff4 with SMTP id f16-20020a056402005000b0043169fceff4mr26419944edu.243.1654855553741; Fri, 10 Jun 2022 03:05:53 -0700 (PDT) Received: from [192.168.0.202] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i7-20020a170906444700b0070e238ff66fsm9834067ejp.96.2022.06.10.03.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 03:05:53 -0700 (PDT) Message-ID: <537986d4-376e-d787-1581-cf0b0d525daa@linaro.org> Date: Fri, 10 Jun 2022 12:05:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 44/48] ARM: dts: at91: align gpio-key node names with dtschema Content-Language: en-US To: Claudiu.Beznea@microchip.com, arnd@arndb.de, olof@lixom.net, arm@kernel.org, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, peda@axentia.se, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <20220609114047.380793-5-krzysztof.kozlowski@linaro.org> <42e8f573-cfc2-dfa4-1740-b0a29521628e@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <42e8f573-cfc2-dfa4-1740-b0a29521628e@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/06/2022 09:12, Claudiu.Beznea@microchip.com wrote: >> compatible = "gpio-keys"; >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> status = "okay"; >> >> - sw1 { >> + switch-1 { > > This is acutally a button labeled on board as SW1. It has been wrongly > carried over from older DTSes. Maybe it would worth to have it now here as > button instead of switch. Sure, I'll name it "button-1". Could be also "button-sw1" if ou prefer. > >> label = "SW1"; >> gpios = <&pioD 18 GPIO_ACTIVE_LOW>; >> linux,code=; >> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >> index 08f0d4b995ff..96c9290007a8 100644 >> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >> @@ -478,13 +478,13 @@ can1: can@fc050000 { >> }; >> }; >> >> - gpio_keys { >> + gpio-keys { >> compatible = "gpio-keys"; >> >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> >> - pb4 { >> + button { >> label = "USER"; >> gpios = <&pioA PIN_PA29 GPIO_ACTIVE_LOW>; >> linux,code = ; >> diff --git a/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >> index 5e8755f22784..d5652c974748 100644 >> --- a/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >> +++ b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >> @@ -26,14 +26,14 @@ chosen { >> stdout-path = "serial0:115200n8"; >> }; >> >> - gpio_keys { >> + gpio-keys { >> compatible = "gpio-keys"; >> >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> status = "okay"; >> >> - sw4 { >> + switch-4 { > > Same here, this is a button not a switch. Sure, then button-1 or button-sw4 > >> label = "USER BUTTON"; >> gpios = <&pioA PIN_PB2 GPIO_ACTIVE_LOW>; >> linux,code = ; >> diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts >> index 806eb1d911d7..d7b59e16a081 100644 >> --- a/arch/arm/boot/dts/at91-sama5d2_icp.dts >> +++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts >> @@ -42,14 +42,14 @@ main_xtal { >> }; >> }; >> >> - gpio_keys { >> + gpio-keys { >> compatible = "gpio-keys"; >> >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> status = "okay"; >> >> - sw4 { >> + switch-4 { > > Same here, button not switch. > > Other than this, looks good to me. Thanks for checking Best regards, Krzysztof