devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Tarek Dakhran <t.dakhran@samsung.com>, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Russell King <linux@arm.linux.org.uk>,
	Ben Dooks <ben-linux@fluff.org>, Tomasz Figa <t.figa@samsung.com>,
	Mike Turquette <mturquette@linaro.org>,
	Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Romain Naour <romain.naour@openwide.fr>,
	Chander Kashyap <chander.kashyap@linaro.org>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Tarek Dakhran <t.dakhran@gmail.com>
Subject: Re: [PATCH v9 0/3] Exynos 5410 support
Date: Mon, 19 May 2014 12:51:36 +0200	[thread overview]
Message-ID: <5379E238.1080803@gmail.com> (raw)
In-Reply-To: <1400470640-30611-1-git-send-email-t.dakhran@samsung.com>

Hi Tarek,

On 19.05.2014 05:37, Tarek Dakhran wrote:
> The series of patches represent support of Exynos 5410 SoC
> 
> The Exynos 5410 is the first Samsung SoC based on big.LITTLE architecture
> 
> Patches add new platform description, support of clock controller and device
> tree for Exynos 5410.
> 
> Has been build on Samsung Linux Kernel
>   (branch: for-next, commit: ccf5511 ARM: EXYNOS: Add MCPM call-back functions)

This doesn't look like an up-to-date tip of that branch. There was a lot
of changes merged 2 days ago, especially from samsung-clk tree and your
patches won't apply and/or compile (at least patch 2/3). Are you sure
you didn't have a git fetch error?

Moreover I can still see the dts using full-path syntax, instead of
reference-based one and also no soc node, as I pointed in v8. [1]

[1] https://lkml.org/lkml/2014/4/26/59

Another thing is that I still see a custom fixed clock binding being
used for oscclk in the clock driver, while I believe I pointed in some
of the previous versions that generic fixed clock should be used.

Best regards,
Tomasz

      parent reply	other threads:[~2014-05-19 10:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19  3:37 [PATCH v9 0/3] Exynos 5410 support Tarek Dakhran
2014-05-19  3:37 ` [PATCH v9 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC Tarek Dakhran
2014-05-19 11:30   ` Tomasz Figa
2014-05-19  3:37 ` [PATCH v9 2/3] clk: exynos5410: register clocks using common clock framework Tarek Dakhran
2014-05-19  3:37 ` [PATCH v9 3/3] ARM: dts: Add initial device tree support for EXYNOS5410 Tarek Dakhran
2014-05-19 10:51 ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5379E238.1080803@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=chander.kashyap@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=pawel.moll@arm.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    --cc=romain.naour@openwide.fr \
    --cc=t.dakhran@gmail.com \
    --cc=t.dakhran@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    --cc=v.tyrtov@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).