From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v2 00/10] Marvell Berlin full clock support Date: Mon, 19 May 2014 21:46:13 +0200 Message-ID: <537A5F85.4090709@gmail.com> References: <1400517811-24668-1-git-send-email-sebastian.hesselbarth@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400517811-24668-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: linux-doc-owner@vger.kernel.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Mike Turquette , Alexandre Belloni , Jisheng Zhang , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 05/19/2014 06:43 PM, Sebastian Hesselbarth wrote: > Mike, > > this is v2 of the Berlin SoC clock driver [1] but with a reworked DT > binding as requested [2]. We decided to not even try to split up the chip > control registers that deal with pinmux, padmux, clock, reset, and evil > stuff we haven't even looked at. Instead we keep a single node that clock > driver will remap early, while proper platform_drivers use a regmap > instead. Although clock and other drivers share the same register range, > they use individual registers exclusively. > > There are some functional fixes in the single clock drivers, I noticed > while retesting each individial driver. There will be more to fixup but > without any drivers actually using the clocks, it is hard to tell what > isn't working now. > > Anyway, the current binding should match what you requested and having > a clock driver for v3.16 will really be a huge benefit for us to work > on more driver support. > > If you are fine with it, please take patches 2-7 and I'll pick up > 1,8-10 in berlin branch. nit: I also take patch 2 as it is the required DT include. Makes 3-7 to pick up for you. Sebastian > [1] https://lkml.kernel.org/r/1399839881-29895-1-git-send-email-sebastian.hesselbarth@gmail.com > [2] https://lkml.kernel.org/r/20140515044106.19795.57249@quantum > > Alexandre Belloni (4): > clk: berlin: add driver for BG2x simple PLLs > clk: berlin: add driver for BG2x complex divider cells > clk: berlin: add core clock driver for BG2Q > ARM: dts: berlin: convert BG2Q to DT clock nodes > > Sebastian Hesselbarth (6): > dt-binding: ARM: add clock binding docs for Marvell Berlin2 SoCs > clk: berlin: add binding include for Berlin SoC clock ids > clk: berlin: add driver for BG2x audio/video PLL > clk: berlin: add core clock driver for BG2/BG2CD > ARM: dts: berlin: convert BG2CD to DT clock nodes > ARM: dts: berlin: convert BG2 to DT clock nodes > > .../devicetree/bindings/arm/marvell,berlin.txt | 47 ++ > arch/arm/boot/dts/berlin2.dtsi | 56 +- > arch/arm/boot/dts/berlin2cd.dtsi | 53 +- > arch/arm/boot/dts/berlin2q.dtsi | 54 +- > drivers/clk/Makefile | 1 + > drivers/clk/berlin/Makefile | 4 + > drivers/clk/berlin/berlin2-avpll.c | 393 ++++++++++++ > drivers/clk/berlin/berlin2-avpll.h | 36 ++ > drivers/clk/berlin/berlin2-div.c | 265 ++++++++ > drivers/clk/berlin/berlin2-div.h | 89 +++ > drivers/clk/berlin/berlin2-pll.c | 117 ++++ > drivers/clk/berlin/berlin2-pll.h | 37 ++ > drivers/clk/berlin/bg2.c | 691 +++++++++++++++++++++ > drivers/clk/berlin/bg2q.c | 389 ++++++++++++ > drivers/clk/berlin/common.h | 29 + > include/dt-bindings/clock/berlin2.h | 45 ++ > include/dt-bindings/clock/berlin2q.h | 31 + > 17 files changed, 2240 insertions(+), 97 deletions(-) > create mode 100644 drivers/clk/berlin/Makefile > create mode 100644 drivers/clk/berlin/berlin2-avpll.c > create mode 100644 drivers/clk/berlin/berlin2-avpll.h > create mode 100644 drivers/clk/berlin/berlin2-div.c > create mode 100644 drivers/clk/berlin/berlin2-div.h > create mode 100644 drivers/clk/berlin/berlin2-pll.c > create mode 100644 drivers/clk/berlin/berlin2-pll.h > create mode 100644 drivers/clk/berlin/bg2.c > create mode 100644 drivers/clk/berlin/bg2q.c > create mode 100644 drivers/clk/berlin/common.h > create mode 100644 include/dt-bindings/clock/berlin2.h > create mode 100644 include/dt-bindings/clock/berlin2q.h > > --- > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: Randy Dunlap > Cc: Mike Turquette > Cc: Alexandre Belloni > Cc: Jisheng Zhang > Cc: devicetree@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org >