From: Maxime Coquelin <maxime.coquelin@st.com>
To: Olof Johansson <olof@lixom.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
kernel@stlinux.com, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@st.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stuart Menefy <stuart.menefy@st.com>,
Rob Herring <robh+dt@kernel.org>, Rob Landley <rob@landley.net>,
Kumar Gala <galak@codeaurora.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support
Date: Tue, 20 May 2014 10:27:10 +0200 [thread overview]
Message-ID: <537B11DE.6040000@st.com> (raw)
In-Reply-To: <CAOesGMg5Jk_XB3zdfKz8VxRObYbFO8OMuRyo7Ba-kavANbci1w@mail.gmail.com>
Hi Olof,
On 05/20/2014 08:18 AM, Olof Johansson wrote:
> Hi,
>
> Just a quick drive-by review since I was looking at these patches in
> the pull request you sent.
>
>
>
Thanks for the review.
I will send a new series taking your comments into account, except the
one about reference-based syntax.
[...]
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 12455cf..f760a88 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -317,7 +317,8 @@ dtb-$(CONFIG_ARCH_SPEAR6XX)+= spear600-evb.dtb
>> dtb-$(CONFIG_ARCH_STI)+= stih415-b2000.dtb \
>> stih416-b2000.dtb \
>> stih415-b2020.dtb \
>> - stih416-b2020.dtb
>> + stih416-b2020.dtb \
>> + stih407-b2120.dtb
>
> These should be in alphanumerical order. 407 comes before 415. You've
> been out of order with others as well.
Ok, it will be re-ordered in the next series.
>
>> dtb-$(CONFIG_ARCH_SUNXI) += \
>> sun4i-a10-a1000.dtb \
>> sun4i-a10-cubieboard.dtb \
>> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
>> new file mode 100644
>> index 0000000..9c97da4
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stih407-b2120.dts
>> @@ -0,0 +1,78 @@
>> +/*
>> + * Copyright (C) 2014 STMicroelectronics (R&D) Limited.
>> + * Author: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +/dts-v1/;
>> +#include "stih407.dtsi"
>> +/ {
>> + model = "STiH407 B2120";
>> + compatible = "st,stih407", "st,stih407-b2120";
>
> This should go from specific to generic, so the order needs to be the other way.
>
> Please check other dts files for the same (I didn't).
>
Ok, I will change that for this dts and also the other ones.
Thanks,
Maxime
next prev parent reply other threads:[~2014-05-20 8:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 8:50 [PATCH v4 0/6] Add STiH407 SoC and reference board support Maxime COQUELIN
2014-03-12 8:50 ` [PATCH v4 1/6] ARM: STi: Add STiH407 SoC support Maxime COQUELIN
2014-03-12 9:37 ` Lee Jones
2014-03-12 8:50 ` [PATCH v4 2/6] pinctrl: st: Enhance the controller to manage unavailable registers Maxime COQUELIN
2014-03-12 9:38 ` Lee Jones
[not found] ` <1394614210-15698-3-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2014-03-12 14:16 ` Linus Walleij
2014-03-12 8:50 ` [PATCH v4 3/6] pinctrl: st: add pinctrl support for the STiH407 SoC Maxime COQUELIN
[not found] ` <1394614210-15698-4-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2014-03-12 14:17 ` Linus Walleij
2014-03-12 8:50 ` [PATCH v4 4/6] pinctrl: st: Use ARRAY_SIZE instead of raw value for number of delays Maxime COQUELIN
2014-03-12 9:39 ` Lee Jones
2014-03-12 14:19 ` Linus Walleij
2014-03-12 14:25 ` Joe Perches
2014-03-14 9:20 ` Linus Walleij
2014-03-14 9:44 ` Maxime Coquelin
2014-03-14 9:46 ` srinivas kandagatla
2014-03-12 8:50 ` [PATCH v4 5/6] ARM: dts: Add STiH407 SoC support Maxime COQUELIN
2014-05-13 12:04 ` [STLinux Kernel] " Patrice Chotard
2014-03-12 8:50 ` [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support Maxime COQUELIN
2014-05-13 12:05 ` [STLinux Kernel] " Patrice Chotard
[not found] ` <1394614210-15698-7-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2014-05-20 6:18 ` Olof Johansson
2014-05-20 7:20 ` Lee Jones
2014-05-20 7:24 ` Olof Johansson
[not found] ` <CAOesGMioLwX3jgGEsR=rHV0u6yR54b4x8BfyZ91vjJnMapUHew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-20 7:43 ` Lee Jones
2014-05-20 7:53 ` Maxime Coquelin
2014-05-20 22:10 ` Olof Johansson
2014-05-21 10:02 ` Lee Jones
2014-05-20 8:27 ` Maxime Coquelin [this message]
2014-03-12 14:20 ` [PATCH v4 0/6] Add STiH407 SoC and reference " Linus Walleij
2014-03-12 15:26 ` Maxime Coquelin
[not found] ` <53207CA2.4090309-qxv4g6HH51o@public.gmane.org>
2014-03-14 10:14 ` Linus Walleij
2014-04-22 12:17 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B11DE.6040000@st.com \
--to=maxime.coquelin@st.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@st.com \
--cc=stuart.menefy@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).