From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v4 4/7] ata: ahci_platform: add the Marvell Berlin AHCI compatible Date: Tue, 20 May 2014 11:18:11 +0200 Message-ID: <537B1DD3.2040104@gmail.com> References: <1400576675-25265-1-git-send-email-antoine.tenart@free-electrons.com> <1400576675-25265-5-git-send-email-antoine.tenart@free-electrons.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1400576675-25265-5-git-send-email-antoine.tenart@free-electrons.com> Sender: linux-ide-owner@vger.kernel.org To: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= , tj@kernel.org, kishon@ti.com Cc: alexandre.belloni@free-electrons.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 05/20/2014 11:04 AM, Antoine T=C3=A9nart wrote: > The Marvell Berlin AHCI has all his specific in the PHY driver. It th= en > only need to use the libahci functions to work properly. If it is that generic, .. > Add its compatible into the libahci_platform driver. > > Signed-off-by: Antoine T=C3=A9nart > --- > drivers/ata/ahci_platform.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.= c > index ef67e79944f9..bc050aabf206 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -76,6 +76,7 @@ static const struct of_device_id ahci_of_match[] =3D= { > { .compatible =3D "snps,exynos5440-ahci", }, > { .compatible =3D "ibm,476gtr-ahci", }, > { .compatible =3D "snps,dwc-ahci", }, > + { .compatible =3D "marvell,berlin-ahci", }, =2E. why have a Marvell-specific compatible? How about "generic-ahci" instead, like we have for other fooHCIs already? Sebastian > {}, > }; > MODULE_DEVICE_TABLE(of, ahci_of_match); >