From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: dts: overo: Add support for 4.3'' LCD output
Date: Tue, 20 May 2014 15:55:32 +0200 [thread overview]
Message-ID: <537B5ED4.3040805@epfl.ch> (raw)
In-Reply-To: <537B4D6B.5070106@ti.com>
On 05/20/2014 02:41 PM, Tomi Valkeinen wrote:
> On 20/05/14 15:31, Florian Vaussard wrote:
>
>> + lcd0: display@0 { + compatible = "samsung,lte430wq-f0c",
>> "panel-dpi"; + label = "lcd"; + + gpios = <&gpio5 16
>> GPIO_ACTIVE_HIGH /* gpio_144: enable */ + &gpio5 17
>> GPIO_ACTIVE_HIGH>; /* gpio_145: brightness */
>
> The panel-dpi only takes one gpio, the enable. The backlight should
> be handled with gpio-backlight driver.
>
> The same applies for the Alto35 patch.
>
Indeed. I will send a v3.
Regards,
Florian
next prev parent reply other threads:[~2014-05-20 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 12:31 [PATCH v2 0/3] ARM: dts: overo: Add panel support Florian Vaussard
2014-05-20 12:31 ` [PATCH v2 1/3] ARM: dts: overo: Add support for DVI output Florian Vaussard
2014-05-20 12:31 ` [PATCH v2 2/3] ARM: dts: overo: Add support for 4.3'' LCD output Florian Vaussard
2014-05-20 12:41 ` Tomi Valkeinen
2014-05-20 13:55 ` Florian Vaussard [this message]
2014-05-20 12:31 ` [PATCH v2 3/3] ARM: dts: overo: Add support for 3.5'' " Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B5ED4.3040805@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).