From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH RESEND 2/2] Documentation: add Broadcom STB Level-2 interrupt controller binding Date: Tue, 20 May 2014 19:24:16 -0700 Message-ID: <537C0E50.4050409@gmail.com> References: <1400613229-19049-1-git-send-email-f.fainelli@gmail.com> <1400613229-19049-3-git-send-email-f.fainelli@gmail.com> <20140521013027.GD8664@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20140521013027.GD8664@titan.lakedaemon.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jason Cooper Cc: Mark Rutland , "open list:OPEN FIRMWARE AND..." , Pawel Moll , Ian Campbell , Randy Dunlap , DOCUMENTATION , open list , Rob Herring , arm@kernel.org, Kumar Gala , Thomas Gleixner , Brian Norris , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Le 20/05/2014 18:30, Jason Cooper a =E9crit : > On Tue, May 20, 2014 at 12:13:49PM -0700, Florian Fainelli wrote: >> This patch adds the Device Tree binding document for the Broadcom >> Set-top-box Level 2 interrupt controller hardware. >> >> Signed-off-by: Brian Norris >> Signed-off-by: Florian Fainelli >> --- >> .../bindings/interrupt-controller/brcm,l2-intc.txt | 29 ++++++++++++++= ++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-control= ler/brcm,l2-intc.txt >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm= ,l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,= l2-intc.txt >> new file mode 100644 >> index 000000000000..448273a30a11 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-int= c.txt >> @@ -0,0 +1,29 @@ >> +Broadcom Generic Level 2 Interrupt Controller >> + >> +Required properties: >> + >> +- compatible: should be "brcm,l2-intc" >> +- reg: specifies the base physical address and size of the registers >> +- interrupt-controller: identifies the node as an interrupt controller >> +- #interrupt-cells: specifies the number of cells needed to encode an >> + interrupt source. Should be 1. >> +- interrupt-parent: specifies the phandle to the parent interrupt contr= oller >> + this controller is cacaded from >> +- interrupts: specifies the interrupt line in the interrupt-parent irq = space >> + to be used for cascading >> + >> +Optional properties: >> + >> +- brcm,irq-can-wake: If present, this means the L2 controller can be us= ed as a >> + wakeup source for system suspend/resume. > > Do we need a vendor-specific property here? I'd much prefer to see a > generic implementation. Is there an usable generic property? We came up with a custom one = because there is not a generic one AFAICT.