Re: [Patch] ARM: dts: keystone: add pll controller syscon entry

[Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]

On 05/21/2014 10:18 PM, Sergei Shtylyov wrote:

>> The pll controller register set includes sets of registers with
>> different purposes, so it's logically to add syscon entry to be able
>> to access them from appropriate places.

>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
>> ---

>> Based on linux-next/master

>>   arch/arm/boot/dts/keystone.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index d9f99e7..5e67c5b 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -66,6 +66,11 @@
>>           ranges = <0x0 0x0 0x0 0xc0000000>;
>>           dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>>
>> +        pllctrl: pll_controller {

>    I think it's better to follow the pattern established by "reset-controller"
> and use hyphen ISO dash in the node name. This is also a common practice to

    Oops, hyphen and dash are basically the same thing; I meant 
s/dash/underscore/.

> use hyphens in the device trees overall.

>> +            compatible = "ti,keystone-pllctrl", "syscon";
>> +            reg = <0x2310000 0x200>;
>> +        };
>> +
>>           rstctrl: reset-controller {
>>               compatible = "ti,keystone-reset";
>>               reg = <0x023100e8 4>;    /* pll reset control reg */
>>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html