From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Abhilash Kesavan <a.kesavan@samsung.com>,
linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
t.figa@samsung.com, myungjoo.ham@samsung.com,
rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Cc: kesavan.abhilash@gmail.com
Subject: Re: [PATCH RFC v2 4/7] ARM: dts: Add PPMU device tree support for Exynos5420
Date: Thu, 22 May 2014 21:50:45 +0400 [thread overview]
Message-ID: <537E38F5.4020200@cogentembedded.com> (raw)
In-Reply-To: <1400779322-4410-5-git-send-email-a.kesavan@samsung.com>
On 05/22/2014 09:21 PM, Abhilash Kesavan wrote:
> PPMU is required by the exynos5420 devfreq driver. Add a device
> tree node for it.
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 8e7e35c..6ab7b03 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -833,4 +833,11 @@
> samsung,pmu-syscon = <&pmu_system_controller>;
> #phy-cells = <1>;
> };
> +
> + ppmu {
Shouldn't it have the unit-address part, like "ppmu@10d00000"?
> + compatible = "samsung,exynos5420-int-busfreq";
> + reg = <0x10D00000 0x2000 /* PPMU_DMC_0_0 */
> + 0x10D10000 0x2000 /* PPMU_DMC_0_1 */
> + 0x10D60000 0x2000>; /* PPMU_DMC_1_0 */
> + };
> };
WBR, Sergei
next prev parent reply other threads:[~2014-05-22 17:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 17:21 [PATCH RFC v2 0/7] Devfreq support for Exynos5250/5420 Abhilash Kesavan
2014-05-22 17:21 ` [PATCH RFC v2 1/7] clk: exynos5250: add aliases for clocks used by devfreq Abhilash Kesavan
2014-07-15 18:33 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 10:50 ` Tomasz Figa
2014-07-16 18:04 ` Abhilash Kesavan
2014-05-22 17:21 ` [PATCH RFC v2 2/7] clk: exynos5420: Add " Abhilash Kesavan
2014-07-15 18:34 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 10:51 ` Tomasz Figa
2014-05-22 17:21 ` [PATCH RFC v2 4/7] ARM: dts: Add PPMU device tree support for Exynos5420 Abhilash Kesavan
2014-05-22 17:50 ` Sergei Shtylyov [this message]
2014-06-16 7:01 ` Abhilash Kesavan
2014-07-15 18:34 ` [PATCH v3 " Abhilash Kesavan
2014-05-22 17:22 ` [PATCH RFC v2 5/7] PM / devfreq: exynos5250: migrate to common-clock Abhilash Kesavan
2014-07-15 18:35 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 11:03 ` Tomasz Figa
2014-07-16 18:00 ` Abhilash Kesavan
2014-05-22 17:22 ` [PATCH RFC v2 6/7] PM / devfreq: exynos: Fix typo in macro Abhilash Kesavan
2014-07-15 18:35 ` [PATCH v3 " Abhilash Kesavan
[not found] ` <1400779322-4410-1-git-send-email-a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-22 17:21 ` [PATCH RFC v2 3/7] ARM: dts: Add PPMU device tree support for Exynos5250 Abhilash Kesavan
2014-07-15 18:34 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 10:55 ` Tomasz Figa
2014-07-16 18:00 ` Abhilash Kesavan
2014-07-16 10:56 ` Tomasz Figa
2014-07-16 18:01 ` Abhilash Kesavan
2014-05-22 17:22 ` [PATCH RFC v2 7/7] PM / devfreq: Add devfreq driver for Exynos5420 Abhilash Kesavan
2014-07-15 18:36 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 11:55 ` Tomasz Figa
2014-07-16 17:59 ` Abhilash Kesavan
2014-07-28 12:01 ` Abhilash Kesavan
2014-05-23 5:08 ` [PATCH RFC v2 0/7] Devfreq support for Exynos5250/5420 Chanwoo Choi
2014-06-16 6:59 ` Abhilash Kesavan
2014-07-15 18:33 ` [PATCH v3 " Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E38F5.4020200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=a.kesavan@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).