From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH RFC v2 4/7] ARM: dts: Add PPMU device tree support for Exynos5420 Date: Thu, 22 May 2014 21:50:45 +0400 Message-ID: <537E38F5.4020200@cogentembedded.com> References: <1400779322-4410-1-git-send-email-a.kesavan@samsung.com> <1400779322-4410-5-git-send-email-a.kesavan@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400779322-4410-5-git-send-email-a.kesavan@samsung.com> Sender: linux-pm-owner@vger.kernel.org To: Abhilash Kesavan , linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com, t.figa@samsung.com, myungjoo.ham@samsung.com, rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: kesavan.abhilash@gmail.com List-Id: devicetree@vger.kernel.org On 05/22/2014 09:21 PM, Abhilash Kesavan wrote: > PPMU is required by the exynos5420 devfreq driver. Add a device > tree node for it. > Signed-off-by: Abhilash Kesavan > --- > arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 8e7e35c..6ab7b03 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -833,4 +833,11 @@ > samsung,pmu-syscon = <&pmu_system_controller>; > #phy-cells = <1>; > }; > + > + ppmu { Shouldn't it have the unit-address part, like "ppmu@10d00000"? > + compatible = "samsung,exynos5420-int-busfreq"; > + reg = <0x10D00000 0x2000 /* PPMU_DMC_0_0 */ > + 0x10D10000 0x2000 /* PPMU_DMC_0_1 */ > + 0x10D60000 0x2000>; /* PPMU_DMC_1_0 */ > + }; > }; WBR, Sergei