From: Jonas Bonn <jonas@southpole.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
linux <linux@lists.openrisc.net>
Subject: Re: [PATCH v4] openrisc: irq: use irqchip framework
Date: Tue, 27 May 2014 08:47:36 +0200 [thread overview]
Message-ID: <53843508.7060007@southpole.se> (raw)
In-Reply-To: <CAMuHMdUUqaRP2M0hPh5k0nPp1a_t0W98Vc_4zAQMjGYZZOPd8w@mail.gmail.com>
On 05/26/2014 10:52 PM, Geert Uytterhoeven wrote:
> CC devicetree for the bindings
>
> On Mon, May 26, 2014 at 10:31 PM, Stefan Kristiansson
> <stefan.kristiansson@saunalahti.fi> wrote:
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt
>> @@ -0,0 +1,23 @@
>> +OpenRISC 1000 Programmable Interrupt Controller
>> +
>> +Required properties:
>> +
>> +- compatible : should be "opencores,or1k-pic-level" for variants with
>> + level triggered interrupt lines, "opencores,or1k-pic-edge" for variants with
>> + edge triggered interrupt lines or "opencores,or1200-pic" for machines
>> + with the non-spec compliant or1200 type implementation.
>> +
>> + "opencores,or1k-pic" is also provided as an alias to "opencores,or1200-pic",
>> + but this is only for backwards compatibility.
I still think this identifier needs to be versioned. Use the same
version number as we have on the cpu identifier since the OR1200 PIC
hasn't changed since then; i.e. opencores,or1200-pic-rtlsvnXYZ.
/Jonas
next prev parent reply other threads:[~2014-05-27 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401136302-27654-1-git-send-email-stefan.kristiansson@saunalahti.fi>
2014-05-26 20:52 ` [PATCH v4] openrisc: irq: use irqchip framework Geert Uytterhoeven
2014-05-27 6:47 ` Jonas Bonn [this message]
2014-05-29 20:28 ` Stefan Kristiansson
2014-05-30 11:08 ` Jonas Bonn
2014-06-21 2:04 ` Jason Cooper
2014-06-21 7:13 ` Stefan Kristiansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53843508.7060007@southpole.se \
--to=jonas@southpole.se \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@lists.openrisc.net \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).