From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Bonn Subject: Re: [PATCH v4] openrisc: irq: use irqchip framework Date: Tue, 27 May 2014 08:47:36 +0200 Message-ID: <53843508.7060007@southpole.se> References: <1401136302-27654-1-git-send-email-stefan.kristiansson@saunalahti.fi> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-bounces@lists.openrisc.net Errors-To: linux-bounces@lists.openrisc.net To: Geert Uytterhoeven , Stefan Kristiansson Cc: "devicetree@vger.kernel.org" , Thomas Gleixner , "linux-kernel@vger.kernel.org" , Jason Cooper , linux List-Id: devicetree@vger.kernel.org On 05/26/2014 10:52 PM, Geert Uytterhoeven wrote: > CC devicetree for the bindings > > On Mon, May 26, 2014 at 10:31 PM, Stefan Kristiansson > wrote: >> +++ b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt >> @@ -0,0 +1,23 @@ >> +OpenRISC 1000 Programmable Interrupt Controller >> + >> +Required properties: >> + >> +- compatible : should be "opencores,or1k-pic-level" for variants with >> + level triggered interrupt lines, "opencores,or1k-pic-edge" for variants with >> + edge triggered interrupt lines or "opencores,or1200-pic" for machines >> + with the non-spec compliant or1200 type implementation. >> + >> + "opencores,or1k-pic" is also provided as an alias to "opencores,or1200-pic", >> + but this is only for backwards compatibility. I still think this identifier needs to be versioned. Use the same version number as we have on the cpu identifier since the OR1200 PIC hasn't changed since then; i.e. opencores,or1200-pic-rtlsvnXYZ. /Jonas