From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tushar Behera Subject: Re: [PATCH/RFC V6 2/2] clk: Add handling of clk parent and rate assigned from DT Date: Tue, 27 May 2014 15:58:05 +0530 Message-ID: <538468B5.6090505@linaro.org> References: <1400520171-6698-1-git-send-email-s.nawrocki@samsung.com> <1400520171-6698-3-git-send-email-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400520171-6698-3-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sylwester Nawrocki , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 05/19/2014 10:52 PM, Sylwester Nawrocki wrote: > This patch adds a helper function to configure clock parents and > rates as specified in clock-parents, clock-rates DT properties > for a consumer device and a call to it before driver is bound to > a device. > > Signed-off-by: Sylwester Nawrocki [ ... ] > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 5b47210..f622733 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > > #include "base.h" > #include "power/power.h" > @@ -486,6 +487,10 @@ static int platform_drv_probe(struct device *_dev) > struct platform_device *dev = to_platform_device(_dev); > int ret; > > + ret = of_clk_set_defaults(_dev->of_node, false); > + if (ret < 0) > + return ret; > + of_clk_set_defaults() is not getting called when the related driver is not registered through platform_driver_register(). I came across this issue while testing this patch on peach-pit board with following dts change. max98090 audio codec driver is registered through module_i2c_driver(). * arch/arm/boot/dts/exynos5420-peach-pit.dts &hsi2c_7 { status = "okay"; max98090: codec@10 { compatible = "maxim,max98090"; reg = <0x10>; interrupts = <2 0>; interrupt-parent = <&gpx0>; pinctrl-names = "default"; pinctrl-0 = <&max98090_irq>; + clocks = <&pmu_system_controller 0>; + clock-names = "mclk"; + clock-parents = <&clock CLK_FIN_PLL>; + clock-rates = <24000000>; }; }; -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html