From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v3 4/7] of: configure the platform device dma parameters Date: Wed, 28 May 2014 10:04:16 -0400 Message-ID: <5385ECE0.7040703@ti.com> References: <1398353407-2345-1-git-send-email-santosh.shilimkar@ti.com> <5840140.8yGnd4Ycx3@wuerfel> <4960549.viM91iY2g2@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij , Arnd Bergmann Cc: Grant Likely , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grygorii Strashko , Russell King , Greg Kroah-Hartman , Rob Herring , Catalin Marinas , Olof Johansson List-Id: devicetree@vger.kernel.org On Wednesday 28 May 2014 09:32 AM, Linus Walleij wrote: > On Wed, May 28, 2014 at 3:29 PM, Arnd Bergmann wrote: >> On Wednesday 28 May 2014 10:23:09 Linus Walleij wrote: > >>> model = "ARM Integrator/AP"; >>> compatible = "arm,integrator-ap"; >>> + dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>; >>> >>> aliases { >>> arm,timer-primary = &timer2; >>> >> >> It looks like you accidentally copied the ranges from keystone, even >> though that has a 64-bit root bus and you only have 32-bit. > > Nah it was no accident, just good old incompetence ;-) > >> I suspect what you want is >> >> dma-ranges = <0x80000000 0 0x80000000>; >> >> to translate dma_addr_t 0x80000000-0xffffffff to phys_addr_t 0x0-0x7fffffff >> rather than phys_addr_t 0x800000000-0x87fffffff. > Interesting. Where does the ROM address space resides on integrator then considering address 0 is used for DMA. > Thanks, I'll fix up my patch. > Feel free to add my ack after the fixup if you need one. regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html