* [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
@ 2014-05-29 11:00 Yoshihiro Shimoda
2014-05-29 16:08 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-29 11:00 UTC (permalink / raw)
To: Simon Horman, SH-Linux, Rob Herring, pawel.moll, mark.rutland,
ijc+devicetree, galak, devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index e06c486..e6b04f2 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -902,4 +902,14 @@
#size-cells = <0>;
status = "disabled";
};
+
+ xhci: xhci@ee000000 {
+ compatible = "renesas,xhci-r8a7790";
+ reg = <0 0xee000000 0 0xc00>;
+ interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
+ phys = <&usbphy 1 1>;
+ phy-names = "usb";
+ status = "disabled";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-29 11:00 [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi Yoshihiro Shimoda
@ 2014-05-29 16:08 ` Sergei Shtylyov
2014-05-30 12:14 ` Yoshihiro Shimoda
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-05-29 16:08 UTC (permalink / raw)
To: Yoshihiro Shimoda, Simon Horman, SH-Linux, Rob Herring,
pawel.moll, mark.rutland, ijc+devicetree, galak,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index e06c486..e6b04f2 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -902,4 +902,14 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + xhci: xhci@ee000000 {
The node name should be "usb@ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
> + compatible = "renesas,xhci-r8a7790";
> + reg = <0 0xee000000 0 0xc00>;
> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
> + phys = <&usbphy 1 1>;
This part is dependent on the generic PHY support in the USB HCD in order
to work.
> + phy-names = "usb";
> + status = "disabled";
> + };
> };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-29 16:08 ` Sergei Shtylyov
@ 2014-05-30 12:14 ` Yoshihiro Shimoda
2014-05-30 13:08 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 12:14 UTC (permalink / raw)
To: Sergei Shtylyov, Simon Horman, SH-Linux, Rob Herring,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
(2014/05/30 1:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index e06c486..e6b04f2 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -902,4 +902,14 @@
>> #size-cells = <0>;
>> status = "disabled";
>> };
>> +
>> + xhci: xhci@ee000000 {
>
> The node name should be "usb@ee000000", according to section 2.2.2 of the
> ePAPR standard [1]:
Thank you for the point! I will fix this and r8a7791's one.
>> + compatible = "renesas,xhci-r8a7790";
>> + reg = <0 0xee000000 0 0xc00>;
>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>> + phys = <&usbphy 1 1>;
>
> This part is dependent on the generic PHY support in the USB HCD in order
> to work.
This means that I should wait to add this parameter until the generic USB PHY Gen2
driver is supported in upstream?
Best regards,
Yoshihiro Shimoda
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> };
>
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-30 12:14 ` Yoshihiro Shimoda
@ 2014-05-30 13:08 ` Sergei Shtylyov
2014-05-30 13:38 ` Yoshihiro Shimoda
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-05-30 13:08 UTC (permalink / raw)
To: Yoshihiro Shimoda, Simon Horman, SH-Linux, Rob Herring,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index e06c486..e6b04f2 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -902,4 +902,14 @@
>>> #size-cells = <0>;
>>> status = "disabled";
>>> };
>>> +
>>> + xhci: xhci@ee000000 {
>> The node name should be "usb@ee000000", according to section 2.2.2 of the
>> ePAPR standard [1]:
> Thank you for the point! I will fix this and r8a7791's one.
>>> + compatible = "renesas,xhci-r8a7790";
>>> + reg = <0 0xee000000 0 0xc00>;
>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>> + phys = <&usbphy 1 1>;
>> This part is dependent on the generic PHY support in the USB HCD in order
>> to work.
Oops, I hadn't seen that you added generic PHY support to the xHCI driver
when writing this. I'm however for adding the generic PHY support to the
generic USB HCD code, so that we can use it for the PCI controllers.
> This means that I should wait to add this parameter until the generic USB PHY Gen2
> driver is supported in upstream?
At least describe that dependency.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
2014-05-30 13:08 ` Sergei Shtylyov
@ 2014-05-30 13:38 ` Yoshihiro Shimoda
0 siblings, 0 replies; 5+ messages in thread
From: Yoshihiro Shimoda @ 2014-05-30 13:38 UTC (permalink / raw)
To: Sergei Shtylyov, Simon Horman, SH-Linux, Rob Herring,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Cc: Magnus Damm, linux-arm-kernel@lists.infradead.org
Hello.
(2014/05/30 22:08), Sergei Shtylyov wrote:
> Hello.
>
> On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote:
>
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>
>>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>>> index e06c486..e6b04f2 100644
>>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>>> @@ -902,4 +902,14 @@
>>>> #size-cells = <0>;
>>>> status = "disabled";
>>>> };
>>>> +
>>>> + xhci: xhci@ee000000 {
>
>>> The node name should be "usb@ee000000", according to section 2.2.2 of the
>>> ePAPR standard [1]:
>
>> Thank you for the point! I will fix this and r8a7791's one.
>
>>>> + compatible = "renesas,xhci-r8a7790";
>>>> + reg = <0 0xee000000 0 0xc00>;
>>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>;
>>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>;
>>>> + phys = <&usbphy 1 1>;
>
>>> This part is dependent on the generic PHY support in the USB HCD in order
>>> to work.
>
> Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers.
>
>> This means that I should wait to add this parameter until the generic USB PHY Gen2
>> driver is supported in upstream?
>
> At least describe that dependency.
Thank you for the reply! I will add such a describption in change log.
Best regards,
Yoshihiro Shimoda
>> Best regards,
>> Yoshihiro Shimoda
>
> WBR, Sergei
>
--
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-30 13:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-29 11:00 [PATCH 2/2] arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi Yoshihiro Shimoda
2014-05-29 16:08 ` Sergei Shtylyov
2014-05-30 12:14 ` Yoshihiro Shimoda
2014-05-30 13:08 ` Sergei Shtylyov
2014-05-30 13:38 ` Yoshihiro Shimoda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).