From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 16/18] ARM: OMAP: Enable PCI for DRA7 Date: Thu, 29 May 2014 18:47:07 +0530 Message-ID: <53873353.9010609@ti.com> References: <1401345500-20188-1-git-send-email-kishon@ti.com> <1401345500-20188-17-git-send-email-kishon@ti.com> <000601cf7b0a$0fbce200$2f36a600$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <000601cf7b0a$0fbce200$2f36a600$%han@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Jingoo Han Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, tony@atomide.com, 'Rob Herring' , 'Pawel Moll' , 'Mark Rutland' , 'Kumar Gala' List-Id: devicetree@vger.kernel.org Hi, On Thursday 29 May 2014 12:18 PM, Jingoo Han wrote: > On Thursday, May 29, 2014 3:38 PM, Kishon Vijay Abraham I wrote: >> >> Now that we have added PCIe driver for DRA7 SOCs, enable PCI on >> DRA7 SOCs. >> >> Cc: Tony Lindgren >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Kumar Gala >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/mach-omap2/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >> index cb31d43..b179e80 100644 >> --- a/arch/arm/mach-omap2/Kconfig >> +++ b/arch/arm/mach-omap2/Kconfig >> @@ -75,6 +75,8 @@ config SOC_DRA7XX >> select ARM_GIC >> select HAVE_ARM_ARCH_TIMER >> select IRQ_CROSSBAR >> + select MIGHT_HAVE_PCI >> + select ARCH_SUPPORTS_MSI > > Hi Kishon, > > Please, don't select ARCH_SUPPORTS_MSI, because this kconfig > option was already removed in v3.12 by the commit ebd97be635 > ('PCI: remove ARCH_SUPPORTS_MSI kconfig option'). So, there is > NO need to select 'ARCH_SUPPORTS_MSI'. Thanks for spotting it. Will remove it. Thanks Kishon