From: Stephen Warren <swarren@wwwdotorg.org>
To: Kevin Hilman <khilman@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
linaro-kernel@lists.linaro.org, Nicolas Pitre <nico@linaro.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Michal Marek <mmarek@suse.cz>,
"open list:KERNEL BUILD + fi..." <linux-kbuild@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/dtc: pad DTBs to facilitate later modification
Date: Thu, 29 May 2014 09:55:34 -0600 [thread overview]
Message-ID: <53875876.2020001@wwwdotorg.org> (raw)
In-Reply-To: <1400888507-11637-1-git-send-email-khilman@linaro.org>
On 05/23/2014 05:41 PM, Kevin Hilman wrote:
> By default, add some padding to the DT blobs to facilitate later
> patching.
>
> An example need for DTB patching is the need to modifiy the command
> line on platforms where ATAGS are not (or cannot) be used to pass the
> commandline. For example, we do not support a big-endian kernel
> reading ATAGS from a little-endian u-boot, so the only way to pass a
> command line in the DT.
>
> Also, without ATAG support (or if u-boot was built without
> CONFIG_INITRD_TAG) the only way to pass an initrd is by adding an
> initrd= option to command line (in the DT).
>
> Therefore, to facilitate adding to the DT command line directly in the
> DTB, add some padding.
>
> Cc: Nicolas Pitre <nico@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> I kinda pulled 64 bytes out of the air here since it's enough to add
> some common things to the commandline like debug, earlyprink
> initrd=<addr>,<size>, etc., but I'm certainlly not opposed to more
> padding.
Conceptually,
Acked-by: Stephen Warren <swarren@nvidia.com>
But I would expect a pad of something like 4KB to be more future-proof.
U-Boot appears to use 4KB on ARM at least:
./arch/arm/dts/Makefile:37:DTC_FLAGS += -R 4 -p 0x1000
next prev parent reply other threads:[~2014-05-29 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 23:41 [PATCH] scripts/dtc: pad DTBs to facilitate later modification Kevin Hilman
2014-05-29 15:55 ` Stephen Warren [this message]
[not found] ` <53875876.2020001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-29 17:20 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53875876.2020001@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nico@linaro.org \
--cc=olof@lixom.net \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).