From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshihiro Shimoda Subject: Re: [PATCH v3 1/2] usb: host: xhci-plat: add optional PHY support Date: Fri, 30 May 2014 22:48:20 +0900 Message-ID: <53888C24.4070203@renesas.com> References: <53868E18.7090805@renesas.com> <53876BB6.3040304@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53876BB6.3040304@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov , "mathias.nyman@intel.com" , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , Gregory CLEMENT Cc: SH-Linux , Magnus Damm , Geert Uytterhoeven , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hello. (2014/05/30 2:17), Sergei Shtylyov wrote: > Hello. > > On 05/29/2014 05:32 AM, Yoshihiro Shimoda wrote: > >> From: Gregory CLEMENT > >> This commit extends the xhci-plat so that it can optionally be passed >> a reference to a PHY through the Device Tree. It will be useful for >> the Armada 375 SoCs. If no PHY is provided then the behavior of the >> driver is unchanged. > >> As for the clock, to achieve this, it adds a 'struct phy *' member in >> xhci_hcd. While only used for now in xhci-plat, here again, it might >> be used by other drivers in the future. > >> Signed-off-by: Gregory CLEMENT >> Signed-off-by: Yoshihiro Shimoda >> --- >> drivers/usb/host/xhci-plat.c | 27 ++++++++++++++++++++++++++- >> drivers/usb/host/xhci.h | 2 ++ >> 2 files changed, 28 insertions(+), 1 deletion(-) > > I've already posted a patch adding generic PHY support to all USB HCDs > about 1.5 months ago, which should make this patch unneeded. Thank you for the point. So, I will not use this patch. And, I could clean up xhci-rcar patch! (ioremap is not needed) Best regards, Yoshihiro Shimoda > WBR, Sergei > -- Yoshihiro Shimoda