From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver Date: Mon, 02 Jun 2014 08:25:16 +0200 Message-ID: <538C18CC.6040105@monstr.eu> References: <1401185895-3677-1-git-send-email-harinik@xilinx.com> <20140529092106.GC24233@leverpostej> <53870129.5010505@monstr.eu> <20140529131940.GG24233@leverpostej> Reply-To: monstr@monstr.eu Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BiKsBpnhxs5kiiEJnDCpQBMnWbjuGLFVp" Return-path: In-Reply-To: <20140529131940.GG24233@leverpostej> Sender: linux-doc-owner@vger.kernel.org To: Mark Rutland Cc: Harini Katakam , "wim@iguana.be" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rob@landley.net" , "michals@xilinx.com" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BiKsBpnhxs5kiiEJnDCpQBMnWbjuGLFVp Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/29/2014 03:19 PM, Mark Rutland wrote: > On Thu, May 29, 2014 at 10:43:05AM +0100, Michal Simek wrote: >> Hi Mark, >> >>>> +static struct of_device_id cdns_wdt_of_match[] =3D { >>>> + { .compatible =3D "xlnx,zynq-wdt-r1p2", }, >>>> + { .compatible =3D "cdns,wdt-r1p2", }, >>> >>> If these can currently be handled identically, why not just have >>> "cdns,wdt-r1p2" in the driver and in your dts have: >>> >>> compatible =3D "xlnx,zynq-wdt-r1p2", "cdns,wdt-r1p2"; >>> >>> If we need to distinguish the two for some reason later we can always= >>> add the "xlnx,zynq-wdt-r1p2" string to the driver. >> >> I would prefer to have 2 compatible strings just because >> of that we don't know what is different compare to origin cadence >> version. We have done the same for spi-cadence.c that's why >> it shouldn't be any problem to keep it as is. >> Having zynq compatible property here and using it give us option >> that if another SoC vendor come with new configuration or clean >> cadence one we can simple handle it without changing compatible >> property for us. >=20 > Sure, we can have two documented strings. But as I mention for the > moment the driver only needs to support the one string so long as a > given dts has both. Then we can later distinguish the zynq variant (or > any other) as necessary. ok then. Let's use just "xlnx,zynq-wdt-r1p2" compatible string here and remove "cdns,wdt-r1p2" Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --BiKsBpnhxs5kiiEJnDCpQBMnWbjuGLFVp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlOMGMwACgkQykllyylKDCGpTgCeI7dlKUifRZbCVGPXZJ905Fb2 qfUAn0ReQS9Wp7Gz9Gfl9Mg/T3JbdEma =pVbY -----END PGP SIGNATURE----- --BiKsBpnhxs5kiiEJnDCpQBMnWbjuGLFVp--