From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables Date: Tue, 03 Jun 2014 11:19:09 -0700 Message-ID: <538E119D.8010304@codeaurora.org> References: <1401213858-31950-1-git-send-email-sboyd@codeaurora.org> <538E09C1.30200@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julia Lawall Cc: Michal Marek , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mitchel Humpherys , Gilles Muller , Nicolas Palix , Grant Likely , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/03/14 11:14, Julia Lawall wrote: > On Tue, 3 Jun 2014, Stephen Boyd wrote: > >> On 06/03/14 03:15, Julia Lawall wrote: >>> Failure to terminate an of_device_id table can lead to confusing >>> failures depending on where the compiler places the array. Add a >>> check to make sure these tables are terminated. Thanks to Mitchel >>> Humpherys for coming up with the pattern initially. >>> >>> Cc: Mitchel Humpherys >>> Cc: Julia Lawall >>> Cc: Gilles Muller >>> Cc: Nicolas Palix >>> Cc: Grant Likely >>> Cc: Rob Herring >>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>> Signed-off-by: Stephen Boyd >>> Acked-by: Grant Likely >>> Signed-off-by: Julia Lawall >>> >>> --- >>> >>> v3: Removed unneeded rule bad_of_table. Placed * in context rule on the >>> closing brace; putting it on the field caused all fields to be marked. >>> >> >> These seem like only minor changes. Why was my authorship removed? > Probably because I don't know how to provide a new vesion of the patch > properly. What should I have done? If you use git format-patch it should insert a "From: " line at the beginning of the commit text. This ensures that when git am is used the correct authorship is retained. It looks like you're using alpine so I suspect you could just paste this information at the beginning of the message. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html