From: Tomasz Figa <tomasz.figa@gmail.com>
To: Doug Anderson <dianders@chromium.org>,
Tomasz Figa <t.figa@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: olof@lixom.net, javier.martinez@collabora.co.uk,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rahul.sharma@samsung.com, shaik.ameer@samsung.com,
arun.kk@samsung.com, alim.akhtar@samsung.com,
a.hajda@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] clk: exynos5420: Remove aclk66_peric from the clock tree description
Date: Fri, 06 Jun 2014 00:26:31 +0200 [thread overview]
Message-ID: <5390EE97.9020702@gmail.com> (raw)
In-Reply-To: <1402000514-30752-1-git-send-email-dianders@chromium.org>
On 05.06.2014 22:35, Doug Anderson wrote:
> The "aclk66_peric" clock is a gate clock with a whole bunch of gates
> underneath it. This big gate isn't very useful to include in our
> clock tree. If any of the children need to be turned on then the big
> gate will need to be on anyway. ...and there are plenty of other "big
> gates" that aren't described in our clock tree, some of which shut off
> collections of clocks that have no relationship in the hierarchy so
> are hard to model.
>
> "aclk66_peric" is causing earlyprintk problems since it gets disabled
> as part of the boot process, so let's just remove it.
>
> Strangely (and for no good reason) this clock is exported as part of
> the common clock bindings. Remove it since there are no in-kernel
> device trees using it and no reason anyone out of tree should refer to
> it either.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes in v3:
> - Now just remove aclk66_peric from the tree as suggested by Tomasz.
>
> Changes in v2:
> - Use GATE_A and clk_get(). Save the clock for putting later.
> - Return 0 from exynos5420_clk_late_init().
>
> drivers/clk/samsung/clk-exynos5420.c | 85 ++++++++++++++++++++++------------
> include/dt-bindings/clock/exynos5420.h | 1 -
> 2 files changed, 55 insertions(+), 31 deletions(-)
>
Mike, I can take this patch to my tree as a fix for 3.16-rc, or if still
possible and you don't mind, feel free to apply it directly with my ACK:
Acked-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2014-06-05 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401467562-5585-1-git-send-email-dianders@chromium.org>
2014-06-05 20:35 ` [PATCH v3] clk: exynos5420: Remove aclk66_peric from the clock tree description Doug Anderson
2014-06-05 22:26 ` Tomasz Figa [this message]
2014-06-06 23:41 ` Mike Turquette
2014-06-09 18:56 ` Doug Anderson
2014-06-06 0:03 ` Mike Turquette
2014-06-06 0:46 ` Doug Anderson
2014-06-06 22:31 ` Mike Turquette
2014-06-06 23:19 ` Doug Anderson
2014-06-30 13:48 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5390EE97.9020702@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=a.hajda@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=arun.kk@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rahul.sharma@samsung.com \
--cc=robh+dt@kernel.org \
--cc=shaik.ameer@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).