From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B31FA3743 for ; Fri, 28 Oct 2022 21:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230008AbiJ1VsZ (ORCPT ); Fri, 28 Oct 2022 17:48:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbiJ1VsX (ORCPT ); Fri, 28 Oct 2022 17:48:23 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E38F24C11E for ; Fri, 28 Oct 2022 14:48:21 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id u7so4910543qvn.13 for ; Fri, 28 Oct 2022 14:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SBJznIFzWZyEQbZ4eSSNW6gDtZq5LgNV4oKX/YjGZaU=; b=S1rpEcjOVlvANLl0lKIzyQw2/HKiR+gzWh/C1KxmlLUp0TymDAoBBY8Ul+cVdpkdD1 Qb+bWUawxtnOwh0PeIYsVu+AtzModJPMUMpySwO18TKpURRJCEaWD2UxXDZtkCbTj80K kxoqBKC7J3qx9FOP4/N+MzwlGjX2xZocCYVImbCiIPJZBz59J33i7tRXHqlwImhCpS6r Xc3omikSPEMPvz741LYlnWLNrU5bPK6HMts1n1I4APzrtQdgsB2sd7z89KuD+OsuRFfE Inht9Swb9s7xcvFyzVUOdCUuv8xTNyBBJ9mqwMZKr6At2fkJN5SJC231U7AP+YGuxVuG 0JLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SBJznIFzWZyEQbZ4eSSNW6gDtZq5LgNV4oKX/YjGZaU=; b=CmISK2TuX6wA1jSWcXxTq+EeeUpLdyw0RHAxnG4DtCEV3/EkWvLemJy80PiBtoNvgL LHUvAogpwDaxz0xqDrtznHo+89NdRHiiAyOGHBYCfiybAAS7drpIEknZNU96xgZigh3Q SjODtGUicilvkDOagHv3OBSrt7AUKqlg5PgGdJ9o27FjnRVIzAjv4SxOfyOOvtLxaHfE 105umC3SiVCSSEfSQpJQqJdeDN+P049pwCTWVOOlIh3nDsUxnW6ldBVOWTaxQWa6tWKo MLbiuMD8aXxSFjCuDptoGtm1WqTQIoYRXk3kiHCnK5qqSgF7UiWe2EMzsvl+5Bksrk6S P5ow== X-Gm-Message-State: ACrzQf2ZmV+60G1YWuow480P2tCPzgJ2sJqljMn+PRuKEsBJf1zPu4Oi zndbUDUFfGjaew5zkqO12H6eOw== X-Google-Smtp-Source: AMsMyM7RVnXDhVMel24hc/A2lGTULvxRB93QAfaenSC9hzmYAcuI1qSvsj4Kp1lV+hm1ywpWSMbBPw== X-Received: by 2002:a05:6214:29c9:b0:4bb:b957:cd4a with SMTP id gh9-20020a05621429c900b004bbb957cd4amr1364459qvb.108.1666993700285; Fri, 28 Oct 2022 14:48:20 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id m22-20020a05620a291600b006f926a0572asm3847258qkp.27.2022.10.28.14.48.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 14:48:19 -0700 (PDT) Message-ID: <5392d0d9-ab8c-8945-169f-264114017c1f@linaro.org> Date: Fri, 28 Oct 2022 17:48:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 04/11] arm64: tegra: Enable XUSB host and device on Jetson AGX Orin Content-Language: en-US To: Thierry Reding Cc: Jon Hunter , Wayne Chang , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, treding@nvidia.com, heikki.krogerus@linux.intel.com, ajayg@nvidia.com, kishon@ti.com, vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org, mathias.nyman@intel.com, jckuo@nvidia.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, singhanc@nvidia.com, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org References: <20221024074128.1113554-1-waynec@nvidia.com> <20221024074128.1113554-5-waynec@nvidia.com> <2059dfe5-b084-42a4-7f35-9da9561fc12b@linaro.org> <5676bcd2-14fc-4e1d-643e-89e575d190c3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/10/2022 08:38, Thierry Reding wrote: >>> >>> I understand you may not like this approach, however, this comment is >>> not really relevant to just this patch, but a general comment. But yes >>> we will ensure that this is correct. >>> >> >> Just to clarify - this status looks redundant, but I have no way to tell >> for sure... > > But that's independent of whether we specify this using the full path or > reference the node by label, isn't it? The only way to make sure that a > status = "okay" is not redundant is by manual inspection. I don't know > of an automated way to do that. Perhaps it's something that could be > added as a check to DTC? With overrides/extends pattern it is easy to spot one case of mistakes - you see override, then status might be needed might not. You see new node (like here!) - then status=okay is redundant. Best regards, Krzysztof