From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-pm@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, Punit.Agrawal@arm.com,
ionela.voinescu@arm.com
Subject: Re: [Query] thermal: Who is using "cooling-{min|max}-level}" properties ?
Date: Fri, 9 Feb 2018 10:15:38 +0100 [thread overview]
Message-ID: <539699c7-9509-dea2-2b31-c5f6749c99c4@linaro.org> (raw)
In-Reply-To: <20180209064211.GY28462@vireshk-i7>
On 09/02/2018 07:42, Viresh Kumar wrote:
> On 07-02-18, 11:45, Daniel Lezcano wrote:
>> Yes, that is my understanding. cooling-min-level and cooling-max-level
>> are not used in the thermal framework code today.
>
> Right.
>
>> So if they are defined, we should check the cooling-device max and min
>> are in the boundaries (if they are different from no-limit).
>
> Hmm, I am not sure. We do compare those values (from maps) with the
> max reported by the cooling driver, so there is some boundary check
> happening. And I don't think it is worth comparing the min/max values
> from DT cooling device's nodes. Why not just leave those for the
> driver to return (which is already happening btw).
>
> I don't think it would be correct for the thermal core to go and look
> at the min/max properties of the cooling device directly, as those are
> more for the thermal driver's help. The thermal core should just call
> the get_max_state() callback and that's it.
>
> Anyway, we can take decision on the binding itself after some time but
> I will send some patches to get rid of this property from CPU nodes
> for now. It doesn't make sense to have it there (anyway it is
> optional), as the cpu cooling devices are kind of virtual cooling
> devices which rely on OPP or freq-table currently. Maybe I will begin
> by just updating one platform and once that is merged, update
> everything else as well.
What about the "cooling-cells" ? Its usage is unclear in the code and
I'm not sure it is really needed.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-02-09 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 6:59 [Query] thermal: Who is using "cooling-{min|max}-level}" properties ? Viresh Kumar
2018-02-07 10:04 ` Daniel Lezcano
[not found] ` <c7bd6ed5-b93e-3a07-b4a2-4c3b1eef5fac-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-07 10:24 ` Viresh Kumar
2018-02-07 10:45 ` Daniel Lezcano
2018-02-09 6:42 ` Viresh Kumar
2018-02-09 9:15 ` Daniel Lezcano [this message]
[not found] ` <539699c7-9509-dea2-2b31-c5f6749c99c4-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-09 9:24 ` Viresh Kumar
2018-02-09 12:14 ` Daniel Lezcano
[not found] ` <5722441d-c8be-4d29-fab7-28b4e5716961-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-12 6:10 ` Viresh Kumar
2018-02-12 8:39 ` Daniel Lezcano
2018-02-12 8:52 ` Viresh Kumar
2018-02-12 9:52 ` Daniel Lezcano
2018-02-12 10:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539699c7-9509-dea2-2b31-c5f6749c99c4@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Punit.Agrawal@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).