From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] ARM: tegra: tamonten: add the base board regulators Date: Thu, 12 Jun 2014 15:17:56 -0600 Message-ID: <539A1904.2000601@wwwdotorg.org> References: <1402585885-28247-1-git-send-email-alban.bedel@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402585885-28247-1-git-send-email-alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alban Bedel , Rob Herring Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Thierry Reding , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/12/2014 09:11 AM, Alban Bedel wrote: > Currently the Tamonten DTS define a fixed regulator for the 5V supply. > However this regulator is in fact on the base board. Fix this by > properly defining the regulators found on the base boards. > diff --git a/arch/arm/boot/dts/tegra20-medcom-wide.dts b/arch/arm/boot/dts/tegra20-medcom-wide.dts > + board_regulators { The name "board_regulators" encodes both type ("regulators") and identify ("board": the regulators on the board). DT node names are suposed to contain type but not identity information. The way this is done in other Tegra DTs is to have a regulators node in both the board and module DT files, and use different ranges of reg values for the board and module; e.g. 0..99 for module and 100.. for the board or similar. Other than that, this patch looks fine.