devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tushar Behera <trblinux@gmail.com>
To: Doug Anderson <dianders@google.com>,
	Tushar Behera <tushar.b@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Mike Turquette <mturquette@linaro.org>,
	Tomasz Figa <t.figa@samsung.com>,
	Russell King <linux@arm.linux.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Kevin Hilman <khilman@linaro.org>,
	Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board
Date: Mon, 16 Jun 2014 16:49:28 +0530	[thread overview]
Message-ID: <539ED2C0.8030405@gmail.com> (raw)
In-Reply-To: <CAD=FV=XqqP7+xDOAKCixivzgaO0xvJX7L+CCN+unAEuf-6aUbQ@mail.gmail.com>

On 06/13/2014 10:33 PM, Doug Anderson wrote:
> Tushar,
> 
> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera <tushar.b@samsung.com> wrote:
>> Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus.
> 
> If you want to be a stickler about it, peach-pi actually has a
> max98091.  That requires code changes to the i2c driver, though.
> ...and unfortunately listing two compatible strings for i2c devices is
> broken.  :(
> 
Hi Doug,

You are right. I checked the boot logs, the detected codec type is
MAX98091. Since both these CODECs are supported through a single driver
and the detection of chip is done during runtime, I would suggest we go
ahead with "max98090" compatible string. I will update the commit
message accordingly.

Does that sound okay to you?

> 
>> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5800-peach-pi.dts |   31 +++++++++++++++++++++++++++++
>>  1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index f3af207..76f5966 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -78,9 +78,27 @@
>>                 pinctrl-0 = <&usb301_vbus_en>;
>>                 enable-active-high;
>>         };
>> +
>> +       sound {
>> +               compatible = "google,snow-audio-max98090";
>> +
>> +               samsung,i2s-controller = <&i2s0>;
>> +               samsung,audio-codec = <&max98090>;
>> +       };
>> +};
>> +
>> +&i2s0 {
>> +       status = "okay";
> 
> It would be awfully nice to keep diffs between exynos5420-peach-pit
> and exynos5800-peach-pi clean.  They're 99% the same.  I know this has
> already gotten messed up with DP/HDMI were added, but there's no need
> to make it worse.
> 

If you so desire, I will submit a patch to sort peach-pi device-tree
nodes (w.r.t. peach-pit dts file).

> Could you add these nodes in the same place within the dts they were
> added in exynos5420-peach-pit?
> 

Okay, I will add it after watchdog node.

-- 
Tushar Behera

  parent reply	other threads:[~2014-06-16 11:19 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  5:32 [PATCH 0/3] Fix boot-hang on Peach-pit and Enable audio Tushar Behera
2014-06-11  5:32 ` [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled Tushar Behera
2014-06-11 15:58   ` Javier Martinez Canillas
     [not found]   ` <1402464739-19044-2-git-send-email-tushar.b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-11 16:50     ` Mike Turquette
2014-06-12  7:29       ` Tushar Behera
2014-06-12 21:09         ` Mike Turquette
2014-07-11  6:18           ` Tushar Behera
2014-07-29  6:58             ` Mike Turquette
2014-06-11 16:50   ` Kevin Hilman
2014-06-12  7:40     ` Tushar Behera
2014-06-24 22:59       ` Doug Anderson
2014-06-25  3:09         ` Tushar Behera
2014-06-25  4:02           ` Doug Anderson
2014-06-11 17:28   ` Tomasz Figa
2014-06-12  7:30     ` Tushar Behera
2014-06-11  5:32 ` [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420 Tushar Behera
2014-06-11 15:58   ` Javier Martinez Canillas
2014-06-16 11:26     ` Tushar Behera
2014-06-22 15:53       ` Tushar Behera
2014-06-24 23:00   ` Doug Anderson
2014-06-25 23:21     ` Kevin Hilman
2014-06-26  3:20       ` Tushar Behera
2014-06-26 16:08         ` Kevin Hilman
2014-06-27  3:38           ` Tushar Behera
2014-06-27 14:18             ` Kevin Hilman
2014-06-27 14:48               ` Kevin Hilman
2014-07-01 11:59                 ` Tushar Behera
2014-07-07 23:34                   ` Kukjin Kim
2014-07-08  3:00                     ` Tushar Behera
2014-07-09 10:14                       ` Javier Martinez Canillas
2014-07-09 12:11                         ` Tushar Behera
     [not found]                           ` <53BD3157.7030804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-09 13:03                             ` Javier Martinez Canillas
2014-07-09 16:01                               ` Doug Anderson
2014-07-09 17:46                                 ` Javier Martinez Canillas
     [not found]                                   ` <CABxcv==v9whax3oraJQnTiDwfAUznjQP6WHK-auPv3q-LOmdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-09 17:52                                     ` Doug Anderson
     [not found] ` <1402464739-19044-1-git-send-email-tushar.b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-11  5:32   ` [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board Tushar Behera
2014-06-13 17:03     ` Doug Anderson
2014-06-13 17:05       ` Mark Brown
2014-06-13 17:13         ` Doug Anderson
     [not found]           ` <CAD=FV=VvkvH1TPiKttm9VXbBRnBo7kmTVK8bZZvexK=bAvaO4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-13 21:58             ` Doug Anderson
2014-06-13 22:04               ` Mark Brown
     [not found]                 ` <20140613220421.GD5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-13 22:50                   ` Doug Anderson
2014-06-16 11:19       ` Tushar Behera [this message]
     [not found]         ` <539ED2C0.8030405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 16:49           ` Doug Anderson
2014-06-16 16:51             ` Mark Brown
2014-06-16 17:02               ` Doug Anderson
2014-06-17  3:39                 ` Tushar Behera
2014-06-17  3:36             ` Tushar Behera
2014-06-17  4:07               ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539ED2C0.8030405@gmail.com \
    --to=trblinux@gmail.com \
    --cc=broonie@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=t.figa@samsung.com \
    --cc=tushar.b@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).