From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH] extcon: extcon-dra7xx: Add Extcon driver for DRA7xx Date: Mon, 16 Jun 2014 07:15:49 -0700 Message-ID: <539EFC15.8000304@roeck-us.net> References: <1402886548-22765-1-git-send-email-george.cherian@ti.com> <539E79A1.50208@roeck-us.net> <539E8399.80902@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <539E8399.80902@ti.com> Sender: linux-doc-owner@vger.kernel.org To: George Cherian , cw00.choi@samsung.com, myungjoo.ham@samsung.com, grant.likely@linaro.org, rdunlap@infradead.org, galak@codeaurora.org, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, pawel.moll@arm.com Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 06/15/2014 10:41 PM, George Cherian wrote: > On 6/16/2014 10:29 AM, Guenter Roeck wrote: >> On 06/15/2014 07:42 PM, George Cherian wrote: >>> This is the driver for the USB ID pin detection. This driver >>> handles only the USB ID pin changes generated by cable >>> insertion/removal. >>> >>> Signed-off-by: George Cherian >> >> Hi George, >> >> Curious: Why can't you use extcon-gpio ? > Main reason being missing dt support. Then why not add dt support to it ? >> >> Also, I thought that Linux specific bindings would be unacceptable. >> "ti,dra7xx-extcon" looks very linux specific to me. Did the rules change ? >> > Then how about "ti,extcon-usbid" ? "extcon" seems very linux specific to me. Anyway, not arguing, just asking, since I wondered. If the extcon maintainer and the dt folks are happy with your driver, so am I. Guenter