From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding Date: Mon, 16 Jun 2014 15:35:20 -0600 Message-ID: <539F6318.5010306@wwwdotorg.org> References: <1402930623-28886-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402930623-28886-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Linus Walleij Cc: Andrew Bresticker , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/16/2014 08:57 AM, Thierry Reding wrote: > From: Thierry Reding > > This patch adds the device tree binding documentation for the XUSB pad > controller found on NVIDIA Tegra SoCs. It exposes both pinmuxing and PHY > capabilities. This looks fine to me, with one issue below: > diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt > +Required properties: > +-------------------- > +- #address-cells: Should be 0. > +- #size-cells: Should be 0. I don't think those properties are needed. If they are, a value of 0 for both doesn't seem useful. I assume those two lines should just be deleted, and also from the example below. Assuming I take this through the Tegra tree, If this is the only issue, I can delete those lines when applying.