[PATCH 0/1] Update apq8016 lpass-cpu compat string

[PATCH 0/1] Update apq8016 lpass-cpu compat string

[Bryan O'Donoghue]

Per discussion with Krzysztof on this yesterday:
https://lore.kernel.org/linux-arm-msm/20220908105720.857294-1-bryan.odonoghue@linaro.org/T/#mb16386b0b6d45de6a7d7e01733d5b6a7d0b85c25

Mark the old lpass compat string as deprecated in yaml and leave a comment
in the commit log to explain new SoC additions should use the corrected
version.

Bryan O'Donoghue (1):
  ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as
    deprecated

 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml    | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

-- 
2.37.3

[PATCH 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Bryan O'Donoghue]

We've had some discongruity in the compatible string of the lpass for 8916
for a while.

Mark the old compat as deprecated. New SoC additions such as msm8936 and
msm8939 should use the compat string "qcom,apq8016-lpass-cpu".

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml    | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
index ef18a572a1ff3..bb6f0c5dd4e8b 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
@@ -18,11 +18,13 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,lpass-cpu
-      - qcom,apq8016-lpass-cpu
-      - qcom,sc7180-lpass-cpu
-      - qcom,sc7280-lpass-cpu
+    oneOf:
+      - const: qcom,lpass-cpu
+      - const: qcom,apq8016-lpass-cpu
+      - const: qcom,sc7180-lpass-cpu
+      - const: qcom,sc7280-lpass-cpu
+      - const: qcom,lpass-cpu-apq8016
+        deprecated: true
 
   reg:
     minItems: 1
-- 
2.37.3

Re: [PATCH 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Krzysztof Kozlowski]

On 09/09/2022 18:34, Bryan O'Donoghue wrote:
> We've had some discongruity in the compatible string of the lpass for 8916
> for a while.
> 
> Mark the old compat as deprecated. New SoC additions such as msm8936 and
> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml    | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index ef18a572a1ff3..bb6f0c5dd4e8b 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -18,11 +18,13 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,lpass-cpu
> -      - qcom,apq8016-lpass-cpu
> -      - qcom,sc7180-lpass-cpu
> -      - qcom,sc7280-lpass-cpu
> +    oneOf:
> +      - const: qcom,lpass-cpu
> +      - const: qcom,apq8016-lpass-cpu
> +      - const: qcom,sc7180-lpass-cpu
> +      - const: qcom,sc7280-lpass-cpu

We talked and I gave you the expected code with enum. I also explained
why other schema (Odroid sound) is done differently. The code here is
correct, but I find more readable and common to use enum. Please make
these entries as enum.

> +      - const: qcom,lpass-cpu-apq8016
> +        deprecated: true
>  
>    reg:
>      minItems: 1


Best regards,
Krzysztof

Re: [PATCH 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Bryan O'Donoghue]

On 09/09/2022 17:36, Krzysztof Kozlowski wrote:
> On 09/09/2022 18:34, Bryan O'Donoghue wrote:
>> We've had some discongruity in the compatible string of the lpass for 8916
>> for a while.
>>
>> Mark the old compat as deprecated. New SoC additions such as msm8936 and
>> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml    | 12 +++++++-----
>>   1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> index ef18a572a1ff3..bb6f0c5dd4e8b 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> @@ -18,11 +18,13 @@ description: |
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - qcom,lpass-cpu
>> -      - qcom,apq8016-lpass-cpu
>> -      - qcom,sc7180-lpass-cpu
>> -      - qcom,sc7280-lpass-cpu
>> +    oneOf:
>> +      - const: qcom,lpass-cpu
>> +      - const: qcom,apq8016-lpass-cpu
>> +      - const: qcom,sc7180-lpass-cpu
>> +      - const: qcom,sc7280-lpass-cpu
> 
> We talked and I gave you the expected code with enum. I also explained
> why other schema (Odroid sound) is done differently. The code here is
> correct, but I find more readable and common to use enum. Please make
> these entries as enum.

Ah you did say enum, I copy/pasted the wrong fragment.