From: Guenter Roeck <linux@roeck-us.net>
To: Heiko Schocher <hs@denx.de>, lm-sensors@lm-sensors.org
Cc: Jean Delvare <khali@linux-fr.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor
Date: Tue, 17 Jun 2014 03:48:06 -0700 [thread overview]
Message-ID: <53A01CE6.4010608@roeck-us.net> (raw)
In-Reply-To: <1402992713-22711-1-git-send-email-hs@denx.de>
On 06/17/2014 01:11 AM, Heiko Schocher wrote:
> Driver for the TI TMP103.
>
> The TI TMP103 is similar to the TMP102. It differs from the TMP102
> by having only 8 bit registers.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
>
[ ... ]
> +#define TMP103_CONF_SD (TMP103_CONF_M0 | TMP103_CONF_M1)
Hello Heiko,
I thought this needs to be TMP103_CONF_M1, but from the datasheet it looks
like it does not matter if M0 is set if M1 is set as well. Did you test it,
though, to make sure that it works ? I feel slightly uncomfortable with it.
Thanks,
Guenter
next prev parent reply other threads:[~2014-06-17 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 8:11 [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor Heiko Schocher
2014-06-17 10:48 ` Guenter Roeck [this message]
[not found] ` <53A01CE6.4010608-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-06-17 11:01 ` Heiko Schocher
2014-06-17 14:22 ` Guenter Roeck
2014-06-17 16:11 ` Mark Rutland
2014-06-17 16:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A01CE6.4010608@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=hs@denx.de \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).