From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v5] hwmon: Driver for TI TMP103 temperature sensor Date: Wed, 18 Jun 2014 06:02:28 -0700 Message-ID: <53A18DE4.8030107@roeck-us.net> References: <1403069837-15651-1-git-send-email-hs@denx.de> <53A127BB.7090802@gmail.com> <53A12ED2.4080004@denx.de> <53A138A0.4010704@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53A138A0.4010704@gmail.com> Sender: linux-doc-owner@vger.kernel.org To: Varka Bhadram , hs@denx.de Cc: lm-sensors@lm-sensors.org, Jean Delvare , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Mark Rutland List-Id: devicetree@vger.kernel.org On 06/17/2014 11:58 PM, Varka Bhadram wrote: > On 06/18/2014 11:46 AM, Heiko Schocher wrote: ... >>> >>> In the bindings you are giving the compatible property as : ti,tmp103, but here only tmp103. >>> >>> Instead of using the i2c_device_id struct , use of_device_id struct for giving the >>> compatible property value. >>> compatble = "," >> >> There are a lot of drivers in drivers/hwmon which use "i2c_device_id struct", >> and for them only "model" is necessary ... >> >> As this is not a platform driver, I do not know, if "of_device_id struct" >> is possible to use. For that, it must be converted to a platform >> device driver ... >> > I thought your are using the devicetree source to load the driver. In that case it need not to be platform driver. > we can use "of_device_id struct" which matches the bindings in your trivial-devices.txt > This would be unnecessary. The bindings will work just fine as-is. I am starting to repeat myself, as do you. May I kindly suggest that you spend some time educating yourself ? Thanks, Guenter