* [PATCH v2 0/2] arm: dts: add support for am437x sk @ 2014-06-18 15:43 Felipe Balbi 2014-06-18 15:43 ` [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog Felipe Balbi 2014-06-18 15:43 ` [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit Felipe Balbi 0 siblings, 2 replies; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 15:43 UTC (permalink / raw) To: Benoit Cousson Cc: robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, Nishanth Menon, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List, Felipe Balbi Hi, here's v2 of am437x sk support. Patches tested on top of next-20140617. Note that this series was tested with the following extra patches: http://marc.info/?l=linux-omap&m=140299431732700&w=2 http://marc.info/?l=linux-omap&m=140300146503126&w=2 http://marc.info/?l=linux-omap&m=140299231232123 http://marc.info/?l=linux-omap&m=140310472709968&w=2 http://marc.info/?l=linux-omap&m=140310471409959&w=2 A branch is also available with all these patches at [1] and serial console capture is available at [2]. [1] http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/log/?h=am437x-starterkit [2] http://slexy.org/view/s20wyUDXDh Felipe Balbi (2): arm: dts: am4372: let boards enable RTC and Watchdog arm: dts: add support for AM437x StarterKit .../devicetree/bindings/arm/omap/omap.txt | 3 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/am4372.dtsi | 4 +- arch/arm/boot/dts/am437x-sk-evm.dts | 583 +++++++++++++++++++++ 4 files changed, 589 insertions(+), 2 deletions(-) create mode 100644 arch/arm/boot/dts/am437x-sk-evm.dts -- 2.0.0.rc1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog 2014-06-18 15:43 [PATCH v2 0/2] arm: dts: add support for am437x sk Felipe Balbi @ 2014-06-18 15:43 ` Felipe Balbi 2014-06-18 15:55 ` Nishanth Menon 2014-06-18 15:43 ` [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit Felipe Balbi 1 sibling, 1 reply; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 15:43 UTC (permalink / raw) To: Benoit Cousson Cc: robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, Nishanth Menon, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List, Felipe Balbi by providing phandles to rtc and wdt nodes, we can let boards enable rtc and wdt as necessary. Signed-off-by: Felipe Balbi <balbi@ti.com> --- arch/arm/boot/dts/am4372.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 49fa596..e3830d4 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -270,7 +270,7 @@ ti,hwmods = "counter_32k"; }; - rtc@44e3e000 { + rtc: rtc@44e3e000 { compatible = "ti,am4372-rtc","ti,da830-rtc"; reg = <0x44e3e000 0x1000>; interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH @@ -279,7 +279,7 @@ status = "disabled"; }; - wdt@44e35000 { + wdt: wdt@44e35000 { compatible = "ti,am4372-wdt","ti,omap3-wdt"; reg = <0x44e35000 0x1000>; interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; -- 2.0.0.rc1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog 2014-06-18 15:43 ` [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog Felipe Balbi @ 2014-06-18 15:55 ` Nishanth Menon 2014-06-18 19:25 ` Felipe Balbi 0 siblings, 1 reply; 17+ messages in thread From: Nishanth Menon @ 2014-06-18 15:55 UTC (permalink / raw) To: Felipe Balbi, Benoit Cousson Cc: robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List $subject - ARM: dts: On 06/18/2014 10:43 AM, Felipe Balbi wrote: > by providing phandles to rtc and wdt nodes, we can > let boards enable rtc and wdt as necessary. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > arch/arm/boot/dts/am4372.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 49fa596..e3830d4 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -270,7 +270,7 @@ > ti,hwmods = "counter_32k"; > }; > > - rtc@44e3e000 { > + rtc: rtc@44e3e000 { > compatible = "ti,am4372-rtc","ti,da830-rtc"; > reg = <0x44e3e000 0x1000>; > interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH > @@ -279,7 +279,7 @@ > status = "disabled"; > }; > > - wdt@44e35000 { > + wdt: wdt@44e35000 { > compatible = "ti,am4372-wdt","ti,omap3-wdt"; > reg = <0x44e35000 0x1000>; > interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; > we might want to fix up any other similar nodes in dtsi as well, no? examples: cpu@0 dispc@4832a400 Might also be nice to have Fixes: to point out which commit was being fixed, no? -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog 2014-06-18 15:55 ` Nishanth Menon @ 2014-06-18 19:25 ` Felipe Balbi 2014-06-18 21:43 ` Nishanth Menon 0 siblings, 1 reply; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 19:25 UTC (permalink / raw) To: Nishanth Menon Cc: Felipe Balbi, Benoit Cousson, robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List [-- Attachment #1: Type: text/plain, Size: 1525 bytes --] Hi, On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote: > $subject - ARM: dts: > > On 06/18/2014 10:43 AM, Felipe Balbi wrote: > > by providing phandles to rtc and wdt nodes, we can > > let boards enable rtc and wdt as necessary. > > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > --- > > arch/arm/boot/dts/am4372.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > > index 49fa596..e3830d4 100644 > > --- a/arch/arm/boot/dts/am4372.dtsi > > +++ b/arch/arm/boot/dts/am4372.dtsi > > @@ -270,7 +270,7 @@ > > ti,hwmods = "counter_32k"; > > }; > > > > - rtc@44e3e000 { > > + rtc: rtc@44e3e000 { > > compatible = "ti,am4372-rtc","ti,da830-rtc"; > > reg = <0x44e3e000 0x1000>; > > interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH > > @@ -279,7 +279,7 @@ > > status = "disabled"; > > }; > > > > - wdt@44e35000 { > > + wdt: wdt@44e35000 { > > compatible = "ti,am4372-wdt","ti,omap3-wdt"; > > reg = <0x44e35000 0x1000>; > > interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; > > > we might want to fix up any other similar nodes in dtsi as well, no? > > examples: > cpu@0 and why would you want boards to mess with the cpu node ? > dispc@4832a400 perhaps > Might also be nice to have Fixes: to point out which commit was being > fixed, no? no other board enables those, so I wouldn't consider it a fix. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog 2014-06-18 19:25 ` Felipe Balbi @ 2014-06-18 21:43 ` Nishanth Menon 2014-06-18 21:51 ` Felipe Balbi 0 siblings, 1 reply; 17+ messages in thread From: Nishanth Menon @ 2014-06-18 21:43 UTC (permalink / raw) To: balbi Cc: devicetree, linux, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, r.sricharan, robh+dt, Benoit Cousson, galak, Linux OMAP Mailing List, Linux ARM Kernel Mailing List On 06/18/2014 02:25 PM, Felipe Balbi wrote: > Hi, > > On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote: >> $subject - ARM: dts: >> >> On 06/18/2014 10:43 AM, Felipe Balbi wrote: >>> by providing phandles to rtc and wdt nodes, we can >>> let boards enable rtc and wdt as necessary. >>> >>> Signed-off-by: Felipe Balbi <balbi@ti.com> >>> --- >>> arch/arm/boot/dts/am4372.dtsi | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >>> index 49fa596..e3830d4 100644 >>> --- a/arch/arm/boot/dts/am4372.dtsi >>> +++ b/arch/arm/boot/dts/am4372.dtsi >>> @@ -270,7 +270,7 @@ >>> ti,hwmods = "counter_32k"; >>> }; >>> >>> - rtc@44e3e000 { >>> + rtc: rtc@44e3e000 { >>> compatible = "ti,am4372-rtc","ti,da830-rtc"; >>> reg = <0x44e3e000 0x1000>; >>> interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH >>> @@ -279,7 +279,7 @@ >>> status = "disabled"; >>> }; >>> >>> - wdt@44e35000 { >>> + wdt: wdt@44e35000 { >>> compatible = "ti,am4372-wdt","ti,omap3-wdt"; >>> reg = <0x44e35000 0x1000>; >>> interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; >>> >> we might want to fix up any other similar nodes in dtsi as well, no? >> >> examples: >> cpu@0 > > and why would you want boards to mess with the cpu node ? > cpu-supply = <®ulator>; for cpufreq. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog 2014-06-18 21:43 ` Nishanth Menon @ 2014-06-18 21:51 ` Felipe Balbi 2014-06-18 21:55 ` Nishanth Menon 0 siblings, 1 reply; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 21:51 UTC (permalink / raw) To: Nishanth Menon Cc: balbi, devicetree, linux, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, r.sricharan, robh+dt, Benoit Cousson, galak, Linux OMAP Mailing List, Linux ARM Kernel Mailing List [-- Attachment #1: Type: text/plain, Size: 1656 bytes --] Hi, On Wed, Jun 18, 2014 at 04:43:28PM -0500, Nishanth Menon wrote: > On 06/18/2014 02:25 PM, Felipe Balbi wrote: > >Hi, > > > >On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote: > >>$subject - ARM: dts: > >> > >>On 06/18/2014 10:43 AM, Felipe Balbi wrote: > >>>by providing phandles to rtc and wdt nodes, we can > >>>let boards enable rtc and wdt as necessary. > >>> > >>>Signed-off-by: Felipe Balbi <balbi@ti.com> > >>>--- > >>> arch/arm/boot/dts/am4372.dtsi | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>>diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > >>>index 49fa596..e3830d4 100644 > >>>--- a/arch/arm/boot/dts/am4372.dtsi > >>>+++ b/arch/arm/boot/dts/am4372.dtsi > >>>@@ -270,7 +270,7 @@ > >>> ti,hwmods = "counter_32k"; > >>> }; > >>> > >>>- rtc@44e3e000 { > >>>+ rtc: rtc@44e3e000 { > >>> compatible = "ti,am4372-rtc","ti,da830-rtc"; > >>> reg = <0x44e3e000 0x1000>; > >>> interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH > >>>@@ -279,7 +279,7 @@ > >>> status = "disabled"; > >>> }; > >>> > >>>- wdt@44e35000 { > >>>+ wdt: wdt@44e35000 { > >>> compatible = "ti,am4372-wdt","ti,omap3-wdt"; > >>> reg = <0x44e35000 0x1000>; > >>> interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; > >>> > >>we might want to fix up any other similar nodes in dtsi as well, no? > >> > >>examples: > >>cpu@0 > > > >and why would you want boards to mess with the cpu node ? > > > cpu-supply = <®ulator>; > > for cpufreq. good point, but does thqt even work with AM437x devices in mainline? -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog 2014-06-18 21:51 ` Felipe Balbi @ 2014-06-18 21:55 ` Nishanth Menon 0 siblings, 0 replies; 17+ messages in thread From: Nishanth Menon @ 2014-06-18 21:55 UTC (permalink / raw) To: balbi Cc: devicetree, linux, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, r.sricharan, robh+dt, Benoit Cousson, galak, Linux OMAP Mailing List, Linux ARM Kernel Mailing List On 06/18/2014 04:51 PM, Felipe Balbi wrote: > Hi, > > On Wed, Jun 18, 2014 at 04:43:28PM -0500, Nishanth Menon wrote: >> On 06/18/2014 02:25 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote: >>>> $subject - ARM: dts: >>>> >>>> On 06/18/2014 10:43 AM, Felipe Balbi wrote: >>>>> by providing phandles to rtc and wdt nodes, we can >>>>> let boards enable rtc and wdt as necessary. >>>>> >>>>> Signed-off-by: Felipe Balbi <balbi@ti.com> >>>>> --- >>>>> arch/arm/boot/dts/am4372.dtsi | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >>>>> index 49fa596..e3830d4 100644 >>>>> --- a/arch/arm/boot/dts/am4372.dtsi >>>>> +++ b/arch/arm/boot/dts/am4372.dtsi >>>>> @@ -270,7 +270,7 @@ >>>>> ti,hwmods = "counter_32k"; >>>>> }; >>>>> >>>>> - rtc@44e3e000 { >>>>> + rtc: rtc@44e3e000 { >>>>> compatible = "ti,am4372-rtc","ti,da830-rtc"; >>>>> reg = <0x44e3e000 0x1000>; >>>>> interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH >>>>> @@ -279,7 +279,7 @@ >>>>> status = "disabled"; >>>>> }; >>>>> >>>>> - wdt@44e35000 { >>>>> + wdt: wdt@44e35000 { >>>>> compatible = "ti,am4372-wdt","ti,omap3-wdt"; >>>>> reg = <0x44e35000 0x1000>; >>>>> interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; >>>>> >>>> we might want to fix up any other similar nodes in dtsi as well, no? >>>> >>>> examples: >>>> cpu@0 >>> >>> and why would you want boards to mess with the cpu node ? >>> >> cpu-supply = <®ulator>; >> >> for cpufreq. > > good point, but does thqt even work with AM437x devices in mainline? it will once we are done adding a node. context here being - if you are fixing phandles, please fix them all up.. that is a little nice to do. I wont argue more on this. I will leave it to maintainers. -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit 2014-06-18 15:43 [PATCH v2 0/2] arm: dts: add support for am437x sk Felipe Balbi 2014-06-18 15:43 ` [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog Felipe Balbi @ 2014-06-18 15:43 ` Felipe Balbi 2014-06-18 16:14 ` Nishanth Menon 1 sibling, 1 reply; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 15:43 UTC (permalink / raw) To: Benoit Cousson Cc: robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, Nishanth Menon, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List, Felipe Balbi, Josh Elliot, Darren Etheridge Add support for TI's AM437x StarterKit Evaluation Module. Cc: Josh Elliot <jelliott@ti.com> Cc: Darren Etheridge <detheridge@ti.com> Signed-off-by: Felipe Balbi <balbi@ti.com> --- .../devicetree/bindings/arm/omap/omap.txt | 3 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/am437x-sk-evm.dts | 583 +++++++++++++++++++++ 3 files changed, 587 insertions(+) create mode 100644 arch/arm/boot/dts/am437x-sk-evm.dts diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt index d22b216..0edc903 100644 --- a/Documentation/devicetree/bindings/arm/omap/omap.txt +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt @@ -129,6 +129,9 @@ Boards: - AM437x GP EVM compatible = "ti,am437x-gp-evm", "ti,am4372", "ti,am43" +- AM437x SK EVM: AM437x StarterKit Evaluation Module + compatible = "ti,am437x-sk-evm", "ti,am4372", "ti,am43" + - DRA742 EVM: Software Development Board for DRA742 compatible = "ti,dra7-evm", "ti,dra742", "ti,dra74", "ti,dra7" diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 621c6c5..a85a4b8 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += omap4-duovero-parlor.dtb \ omap4-var-dvk-om44.dtb \ omap4-var-stk-om44.dtb dtb-$(CONFIG_SOC_AM43XX) += am43x-epos-evm.dtb \ + am437x-sk-evm.dtb \ am437x-gp-evm.dtb dtb-$(CONFIG_SOC_OMAP5) += omap5-cm-t54.dtb \ omap5-sbc-t54.dtb \ diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts new file mode 100644 index 0000000..e7a2bbe --- /dev/null +++ b/arch/arm/boot/dts/am437x-sk-evm.dts @@ -0,0 +1,583 @@ +/* + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/* AM437x SK EVM */ + +/dts-v1/; + +#include "am4372.dtsi" +#include <dt-bindings/pinctrl/am43xx.h> +#include <dt-bindings/pwm/pwm.h> +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> + +/ { + model = "TI AM437x SK EVM"; + compatible = "ti,am437x-sk-evm","ti,am4372","ti,am43"; + + aliases { + display0 = &lcd0; + }; + + backlight { + compatible = "pwm-backlight"; + pwms = <&ecap0 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <0 51 53 56 62 75 101 152 255>; + default-brightness-level = <8>; + }; + + sound { + compatible = "ti,da830-evm-audio"; + ti,model = "AM437x-SK-EVM"; + ti,audio-codec = <&tlv320aic3106>; + ti,mcasp-controller = <&mcasp1>; + ti,codec-clock-rate = <24000000>; + ti,audio-routing = + "Headphone Jack", "HPLOUT", + "Headphone Jack", "HPROUT"; + }; + + matrix_keypad: matrix_keypad@0 { + compatible = "gpio-matrix-keypad"; + + debounce-delay-ms = <5>; + col-scan-delay-us = <1500>; + + row-gpios = <&gpio5 5 GPIO_ACTIVE_HIGH /* Bank5, pin5 */ + &gpio5 6 GPIO_ACTIVE_HIGH>; /* Bank5, pin6 */ + + col-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH /* Bank5, pin13 */ + &gpio5 4 GPIO_ACTIVE_HIGH>; /* Bank5, pin4 */ + + linux,keymap = < + MATRIX_KEY(0, 0, KEY_DOWN) + MATRIX_KEY(0, 1, KEY_RIGHT) + MATRIX_KEY(1, 0, KEY_LEFT) + MATRIX_KEY(1, 1, KEY_UP) + >; + }; + + leds { + compatible = "gpio-leds"; + + led@0 { + label = "am437x-sk:red:heartbeat"; + gpios = <&gpio5 0 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 0 */ + linux,default-trigger = "heartbeat"; + default-state = "off"; + }; + + led@1 { + label = "am437x-sk:green:mmc1"; + gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 1 */ + linux,default-trigger = "mmc0"; + default-state = "off"; + }; + + led@2 { + label = "am437x-sk:blue:cpu0"; + gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 2 */ + linux,default-trigger = "cpu0"; + default-state = "off"; + }; + + led@3 { + label = "am437x-sk:blue:usr3"; + gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 3 */ + default-state = "off"; + }; + }; + + lcd0: display { + compatible = "osddisplays,osd057T0559-34ts", "panel-dpi"; + label = "lcd"; + + pinctrl-names = "default"; + pinctrl-0 = <&lcd_pins>; + + enable-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>; + + panel-timing { + clock-frequency = <9000000>; + hactive = <480>; + vactive = <272>; + hfront-porch = <8>; + hback-porch = <43>; + hsync-len = <4>; + vback-porch = <12>; + vfront-porch = <4>; + vsync-len = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <1>; + }; + + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; +}; + +&am43xx_pinmux { + i2c0_pins: i2c0_pins { + pinctrl-single,pins = < + 0x188 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_sda.i2c0_sda */ + 0x18c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_scl.i2c0_scl */ + >; + }; + + i2c1_pins: i2c1_pins { + pinctrl-single,pins = < + 0x15c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2) /* spi0_cs0.i2c1_scl */ + 0x158 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2) /* spi0_d1.i2c1_sda */ + >; + }; + + mmc1_pins: pinmux_mmc1_pins { + pinctrl-single,pins = < + 0x160 (PIN_INPUT | MUX_MODE7) /* spi0_cs1.gpio0_6 */ + >; + }; + + ecap0_pins: backlight_pins { + pinctrl-single,pins = < + 0x164 MUX_MODE0 /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */ + >; + }; + + edt_ft5306_ts_pins: edt_ft5306_ts_pins { + pinctrl-single,pins = < + 0x74 (PIN_INPUT | MUX_MODE7) /* gpmc_wpn.gpio0_31 */ + 0x78 (PIN_OUTPUT | MUX_MODE7) /* gpmc_be1n.gpio1_28 */ + >; + }; + + cpsw_default: cpsw_default { + pinctrl-single,pins = < + /* Slave 1 */ + 0x12c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txclk.rmii1_tclk */ + 0x114 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txen.rgmii1_tctl */ + 0x128 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd0.rgmii1_td0 */ + 0x124 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd1.rgmii1_td1 */ + 0x120 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd0.rgmii1_td2 */ + 0x11c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd1.rgmii1_td3 */ + 0x130 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxclk.rmii1_rclk */ + 0x118 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxdv.rgmii1_rctl */ + 0x140 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd0.rgmii1_rd0 */ + 0x13c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd1.rgmii1_rd1 */ + 0x138 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd0.rgmii1_rd2 */ + 0x134 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd1.rgmii1_rd3 */ + + /* Slave 2 */ + 0x58 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a6.rgmii2_tclk */ + 0x40 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a0.rgmii2_tctl */ + 0x54 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a5.rgmii2_td0 */ + 0x50 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a4.rgmii2_td1 */ + 0x4c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a3.rgmii2_td2 */ + 0x48 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a2.rgmii2_td3 */ + 0x5c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a7.rgmii2_rclk */ + 0x44 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a1.rgmii2_rtcl */ + 0x6c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a11.rgmii2_rd0 */ + 0x68 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a10.rgmii2_rd1 */ + 0x64 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a9.rgmii2_rd2 */ + 0x60 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a8.rgmii2_rd3 */ + >; + }; + + cpsw_sleep: cpsw_sleep { + pinctrl-single,pins = < + /* Slave 1 reset value */ + 0x12c (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x114 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x128 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x124 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x120 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x11c (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x130 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x118 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x140 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x13c (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x138 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x134 (PIN_INPUT_PULLDOWN | MUX_MODE7) + + /* Slave 2 reset value */ + 0x58 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x40 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x54 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x50 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x4c (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x48 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x5c (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x44 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x6c (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x68 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x64 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x60 (PIN_INPUT_PULLDOWN | MUX_MODE7) + >; + }; + + davinci_mdio_default: davinci_mdio_default { + pinctrl-single,pins = < + /* MDIO */ + 0x148 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* mdio_data.mdio_data */ + 0x14c (PIN_OUTPUT_PULLUP | MUX_MODE0) /* mdio_clk.mdio_clk */ + >; + }; + + davinci_mdio_sleep: davinci_mdio_sleep { + pinctrl-single,pins = < + /* MDIO reset value */ + 0x148 (PIN_INPUT_PULLDOWN | MUX_MODE7) + 0x14c (PIN_INPUT_PULLDOWN | MUX_MODE7) + >; + }; + + dss_pins: dss_pins { + pinctrl-single,pins = < + 0x020 (PIN_OUTPUT_PULLUP | MUX_MODE1) /* gpmc ad 8 -> DSS DATA 23 */ + 0x024 (PIN_OUTPUT_PULLUP | MUX_MODE1) + 0x028 (PIN_OUTPUT_PULLUP | MUX_MODE1) + 0x02c (PIN_OUTPUT_PULLUP | MUX_MODE1) + 0x030 (PIN_OUTPUT_PULLUP | MUX_MODE1) + 0x034 (PIN_OUTPUT_PULLUP | MUX_MODE1) + 0x038 (PIN_OUTPUT_PULLUP | MUX_MODE1) + 0x03c (PIN_OUTPUT_PULLUP | MUX_MODE1) /* gpmc ad 15 -> DSS DATA 16 */ + 0x0a0 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS DATA 0 */ + 0x0a4 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0a8 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0ac (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0b0 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0b4 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0b8 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0bc (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0c0 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0c4 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0c8 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0cc (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0d0 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0d4 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0d8 (PIN_OUTPUT_PULLUP | MUX_MODE0) + 0x0dc (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS DATA 15 */ + 0x0e0 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS VSYNC */ + 0x0e4 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS HSYNC */ + 0x0e8 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS PCLK */ + 0x0ec (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS AC BIAS EN */ + + >; + }; + + qspi_pins: qspi_pins { + pinctrl-single,pins = < + 0x7c (PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_csn0.qspi_csn */ + 0x88 (PIN_OUTPUT | MUX_MODE2) /* gpmc_csn3.qspi_clk */ + 0x90 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_advn_ale.qspi_d0 */ + 0x94 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_oen_ren.qspi_d1 */ + 0x98 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_wen.qspi_d2 */ + 0x9c (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_be0n_cle.qspi_d3 */ + >; + }; + + mcasp1_pins: mcasp1_pins { + pinctrl-single,pins = < + 0x10c (PIN_INPUT_PULLDOWN | MUX_MODE4) /* mii1_crs.mcasp1_aclkx */ + 0x110 (PIN_INPUT_PULLDOWN | MUX_MODE4) /* mii1_rxerr.mcasp1_fsx */ + 0x108 (PIN_OUTPUT_PULLDOWN | MUX_MODE4) /* mii1_col.mcasp1_axr2 */ + 0x144 (PIN_INPUT_PULLDOWN | MUX_MODE4) /* rmii1_ref_clk.mcasp1_axr3 */ + >; + }; + + lcd_pins: lcd_pins { + pinctrl-single,pins = < + /* GPIO 5_8 to select LCD / HDMI */ + 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) + >; + }; +}; + +&i2c0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins>; + + tps@24 { + compatible = "ti,tps65218"; + reg = <0x24>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + #interrupt-cells = <2>; + + dcdc1: regulator-dcdc1 { + compatible = "ti,tps65218-dcdc1"; + /* VDD_CORE limits min of OPP50 and max of OPP100 */ + regulator-name = "vdd_core"; + regulator-min-microvolt = <912000>; + regulator-max-microvolt = <1144000>; + regulator-boot-on; + regulator-always-on; + }; + + dcdc2: regulator-dcdc2 { + compatible = "ti,tps65218-dcdc2"; + /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */ + regulator-name = "vdd_mpu"; + regulator-min-microvolt = <912000>; + regulator-max-microvolt = <1378000>; + regulator-boot-on; + regulator-always-on; + }; + + dcdc3: regulator-dcdc3 { + compatible = "ti,tps65218-dcdc3"; + regulator-name = "vdds_ddr"; + regulator-boot-on; + regulator-always-on; + }; + + dcdc4: regulator-dcdc4 { + compatible = "ti,tps65218-dcdc4"; + regulator-name = "v3_3d"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo1: regulator-ldo1 { + compatible = "ti,tps65218-ldo1"; + regulator-name = "v1_8d"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + }; + + at24@50 { + compatible = "at24,24c256"; + pagesize = <64>; + reg = <0x50>; + }; +}; + +&i2c1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>; + + edt-ft5306@38 { + status = "okay"; + compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; + pinctrl-names = "default"; + pinctrl-0 = <&edt_ft5306_ts_pins>; + reg = <0x38>; + interrupt-parent = <&gpio0>; + interrupts = <31 0>; + + wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; + + touchscreen-size-x = <480>; + touchscreen-size-y = <272>; + }; + + tlv320aic3106: tlv320aic3106@1b { + compatible = "ti,tlv320aic3106"; + reg = <0x1b>; + status = "okay"; + + /* Regulators */ + AVDD-supply = <&dcdc4>; + IOVDD-supply = <&dcdc4>; + DRVDD-supply = <&dcdc4>; + DVDD-supply = <&ldo1>; + }; + + lis331dlh@18 { + compatible = "st,lis331dlh"; + reg = <0x18>; + status = "okay"; + + Vdd-supply = <&dcdc4>; + Vdd_IO-supply = <&dcdc4>; + interrupts-extended = <&gpio1 6 0>, <&gpio2 1 0>; + }; +}; + +&epwmss0 { + status = "okay"; +}; + +&ecap0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&ecap0_pins>; +}; + +&gpio0 { + status = "okay"; +}; + +&gpio1 { + status = "okay"; +}; + +&gpio5 { + status = "okay"; +}; + +&mmc1 { + status = "okay"; + vmmc-supply = <&dcdc4>; + bus-width = <4>; + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; +}; + +&usb2_phy1 { + status = "okay"; +}; + +&usb1 { + dr_mode = "peripheral"; + status = "okay"; +}; + +&usb2_phy2 { + status = "okay"; +}; + +&usb2 { + dr_mode = "host"; + status = "okay"; +}; + +&qspi { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&qspi_pins>; + + spi-max-frequency = <48000000>; + m25p80@0 { + compatible = "mx66l51235l"; + spi-max-frequency = <48000000>; + reg = <0>; + spi-cpol; + spi-cpha; + spi-tx-bus-width = <1>; + spi-rx-bus-width = <4>; + #address-cells = <1>; + #size-cells = <1>; + + /* MTD partition table. + * The ROM checks the first 512KiB + * for a valid file to boot(XIP). + */ + partition@0 { + label = "QSPI.U_BOOT"; + reg = <0x00000000 0x000080000>; + }; + partition@1 { + label = "QSPI.U_BOOT.backup"; + reg = <0x00080000 0x00080000>; + }; + partition@2 { + label = "QSPI.U-BOOT-SPL_OS"; + reg = <0x00100000 0x00010000>; + }; + partition@3 { + label = "QSPI.U_BOOT_ENV"; + reg = <0x00110000 0x00010000>; + }; + partition@4 { + label = "QSPI.U-BOOT-ENV.backup"; + reg = <0x00120000 0x00010000>; + }; + partition@5 { + label = "QSPI.KERNEL"; + reg = <0x00130000 0x0800000>; + }; + partition@6 { + label = "QSPI.FILESYSTEM"; + reg = <0x00930000 0x36D0000>; + }; + }; +}; + +&mac { + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&cpsw_default>; + pinctrl-1 = <&cpsw_sleep>; + dual_emac = <1>; + status = "okay"; +}; + +&davinci_mdio { + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&davinci_mdio_default>; + pinctrl-1 = <&davinci_mdio_sleep>; + status = "okay"; +}; + +&cpsw_emac0 { + phy_id = <&davinci_mdio>, <4>; + phy-mode = "rgmii"; + dual_emac_res_vlan = <1>; +}; + +&cpsw_emac1 { + phy_id = <&davinci_mdio>, <5>; + phy-mode = "rgmii"; + dual_emac_res_vlan = <2>; +}; + +&elm { + status = "okay"; +}; + +&mcasp1 { + pinctrl-names = "default"; + pinctrl-0 = <&mcasp1_pins>; + + status = "okay"; + + op-mode = <0>; + tdm-slots = <2>; + serial-dir = < + 0 0 1 2 + >; + + tx-num-evt = <1>; + rx-num-evt = <1>; +}; + +&dss { + status = "okay"; + + pinctrl-names = "default"; + pinctrl-0 = <&dss_pins>; + + port { + dpi_out: endpoint@0 { + remote-endpoint = <&lcd_in>; + data-lines = <24>; + }; + }; +}; + +&rtc { + status = "okay"; +}; + +&wdt { + status = "okay"; +}; -- 2.0.0.rc1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit 2014-06-18 15:43 ` [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit Felipe Balbi @ 2014-06-18 16:14 ` Nishanth Menon 2014-06-18 19:31 ` Felipe Balbi 0 siblings, 1 reply; 17+ messages in thread From: Nishanth Menon @ 2014-06-18 16:14 UTC (permalink / raw) To: Felipe Balbi, Benoit Cousson Cc: robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List, Josh Elliot, Darren Etheridge On 06/18/2014 10:43 AM, Felipe Balbi wrote: > Add support for TI's AM437x StarterKit Evaluation > Module. is there a link for this platform? > > Cc: Josh Elliot <jelliott@ti.com> > Cc: Darren Etheridge <detheridge@ti.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > .../devicetree/bindings/arm/omap/omap.txt | 3 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/am437x-sk-evm.dts | 583 +++++++++++++++++++++ > 3 files changed, 587 insertions(+) > create mode 100644 arch/arm/boot/dts/am437x-sk-evm.dts > > diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt > index d22b216..0edc903 100644 > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt > @@ -129,6 +129,9 @@ Boards: > - AM437x GP EVM > compatible = "ti,am437x-gp-evm", "ti,am4372", "ti,am43" > > +- AM437x SK EVM: AM437x StarterKit Evaluation Module > + compatible = "ti,am437x-sk-evm", "ti,am4372", "ti,am43" > + > - DRA742 EVM: Software Development Board for DRA742 > compatible = "ti,dra7-evm", "ti,dra742", "ti,dra74", "ti,dra7" > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 621c6c5..a85a4b8 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += omap4-duovero-parlor.dtb \ > omap4-var-dvk-om44.dtb \ > omap4-var-stk-om44.dtb > dtb-$(CONFIG_SOC_AM43XX) += am43x-epos-evm.dtb \ > + am437x-sk-evm.dtb \ > am437x-gp-evm.dtb > dtb-$(CONFIG_SOC_OMAP5) += omap5-cm-t54.dtb \ > omap5-sbc-t54.dtb \ > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > new file mode 100644 > index 0000000..e7a2bbe > --- /dev/null > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > @@ -0,0 +1,583 @@ > +/* > + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/ > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +/* AM437x SK EVM */ ?? > + > +/dts-v1/; > + > +#include "am4372.dtsi" > +#include <dt-bindings/pinctrl/am43xx.h> > +#include <dt-bindings/pwm/pwm.h> > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > + > +/ { > + model = "TI AM437x SK EVM"; > + compatible = "ti,am437x-sk-evm","ti,am4372","ti,am43"; > + > + aliases { > + display0 = &lcd0; > + }; > + > + backlight { > + compatible = "pwm-backlight"; > + pwms = <&ecap0 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = <0 51 53 56 62 75 101 152 255>; > + default-brightness-level = <8>; > + }; > + > + sound { > + compatible = "ti,da830-evm-audio"; > + ti,model = "AM437x-SK-EVM"; > + ti,audio-codec = <&tlv320aic3106>; > + ti,mcasp-controller = <&mcasp1>; > + ti,codec-clock-rate = <24000000>; > + ti,audio-routing = > + "Headphone Jack", "HPLOUT", > + "Headphone Jack", "HPROUT"; > + }; > + > + matrix_keypad: matrix_keypad@0 { > + compatible = "gpio-matrix-keypad"; no pinctrl needed? > + > + debounce-delay-ms = <5>; > + col-scan-delay-us = <1500>; > + > + row-gpios = <&gpio5 5 GPIO_ACTIVE_HIGH /* Bank5, pin5 */ > + &gpio5 6 GPIO_ACTIVE_HIGH>; /* Bank5, pin6 */ > + > + col-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH /* Bank5, pin13 */ > + &gpio5 4 GPIO_ACTIVE_HIGH>; /* Bank5, pin4 */ > + > + linux,keymap = < > + MATRIX_KEY(0, 0, KEY_DOWN) > + MATRIX_KEY(0, 1, KEY_RIGHT) > + MATRIX_KEY(1, 0, KEY_LEFT) > + MATRIX_KEY(1, 1, KEY_UP) > + >; > + }; > + > + leds { > + compatible = "gpio-leds"; no pinctrl needed? > + > + led@0 { > + label = "am437x-sk:red:heartbeat"; > + gpios = <&gpio5 0 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 0 */ > + linux,default-trigger = "heartbeat"; > + default-state = "off"; > + }; > + > + led@1 { > + label = "am437x-sk:green:mmc1"; > + gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 1 */ > + linux,default-trigger = "mmc0"; > + default-state = "off"; > + }; > + > + led@2 { > + label = "am437x-sk:blue:cpu0"; > + gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 2 */ > + linux,default-trigger = "cpu0"; > + default-state = "off"; > + }; > + > + led@3 { > + label = "am437x-sk:blue:usr3"; > + gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 3 */ > + default-state = "off"; > + }; > + }; > + > + lcd0: display { > + compatible = "osddisplays,osd057T0559-34ts", "panel-dpi"; > + label = "lcd"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; > + > + enable-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>; > + > + panel-timing { > + clock-frequency = <9000000>; > + hactive = <480>; > + vactive = <272>; > + hfront-porch = <8>; > + hback-porch = <43>; > + hsync-len = <4>; > + vback-porch = <12>; > + vfront-porch = <4>; > + vsync-len = <10>; > + hsync-active = <0>; > + vsync-active = <0>; > + de-active = <1>; > + pixelclk-active = <1>; > + }; > + > + port { > + lcd_in: endpoint { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + }; > +}; > + > +&am43xx_pinmux { > + i2c0_pins: i2c0_pins { > + pinctrl-single,pins = < > + 0x188 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_sda.i2c0_sda */ > + 0x18c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_scl.i2c0_scl */ > + >; > + }; > + > + i2c1_pins: i2c1_pins { > + pinctrl-single,pins = < > + 0x15c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2) /* spi0_cs0.i2c1_scl */ > + 0x158 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2) /* spi0_d1.i2c1_sda */ > + >; > + }; > + > + mmc1_pins: pinmux_mmc1_pins { > + pinctrl-single,pins = < > + 0x160 (PIN_INPUT | MUX_MODE7) /* spi0_cs1.gpio0_6 */ > + >; > + }; > + > + ecap0_pins: backlight_pins { > + pinctrl-single,pins = < > + 0x164 MUX_MODE0 /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */ pin direction? > + >; > + }; > + > + edt_ft5306_ts_pins: edt_ft5306_ts_pins { > + pinctrl-single,pins = < > + 0x74 (PIN_INPUT | MUX_MODE7) /* gpmc_wpn.gpio0_31 */ > + 0x78 (PIN_OUTPUT | MUX_MODE7) /* gpmc_be1n.gpio1_28 */ > + >; > + }; > + > + cpsw_default: cpsw_default { > + pinctrl-single,pins = < > + /* Slave 1 */ > + 0x12c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txclk.rmii1_tclk */ > + 0x114 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txen.rgmii1_tctl */ > + 0x128 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd0.rgmii1_td0 */ > + 0x124 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd1.rgmii1_td1 */ > + 0x120 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd0.rgmii1_td2 */ > + 0x11c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd1.rgmii1_td3 */ > + 0x130 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxclk.rmii1_rclk */ > + 0x118 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxdv.rgmii1_rctl */ > + 0x140 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd0.rgmii1_rd0 */ > + 0x13c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd1.rgmii1_rd1 */ > + 0x138 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd0.rgmii1_rd2 */ > + 0x134 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd1.rgmii1_rd3 */ > + > + /* Slave 2 */ > + 0x58 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a6.rgmii2_tclk */ > + 0x40 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a0.rgmii2_tctl */ > + 0x54 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a5.rgmii2_td0 */ > + 0x50 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a4.rgmii2_td1 */ > + 0x4c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a3.rgmii2_td2 */ > + 0x48 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a2.rgmii2_td3 */ > + 0x5c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a7.rgmii2_rclk */ > + 0x44 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a1.rgmii2_rtcl */ > + 0x6c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a11.rgmii2_rd0 */ > + 0x68 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a10.rgmii2_rd1 */ > + 0x64 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a9.rgmii2_rd2 */ > + 0x60 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a8.rgmii2_rd3 */ > + >; > + }; > + > + cpsw_sleep: cpsw_sleep { > + pinctrl-single,pins = < > + /* Slave 1 reset value */ > + 0x12c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x114 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x128 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x124 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x120 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x11c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x130 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x118 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x140 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x13c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x138 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x134 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + > + /* Slave 2 reset value */ > + 0x58 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x40 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x54 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x50 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x4c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x48 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x5c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x44 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x6c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x68 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x64 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x60 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + >; > + }; > + > + davinci_mdio_default: davinci_mdio_default { > + pinctrl-single,pins = < > + /* MDIO */ > + 0x148 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* mdio_data.mdio_data */ > + 0x14c (PIN_OUTPUT_PULLUP | MUX_MODE0) /* mdio_clk.mdio_clk */ > + >; > + }; > + > + davinci_mdio_sleep: davinci_mdio_sleep { > + pinctrl-single,pins = < > + /* MDIO reset value */ > + 0x148 (PIN_INPUT_PULLDOWN | MUX_MODE7) > + 0x14c (PIN_INPUT_PULLDOWN | MUX_MODE7) > + >; > + }; > + > + dss_pins: dss_pins { > + pinctrl-single,pins = < > + 0x020 (PIN_OUTPUT_PULLUP | MUX_MODE1) /* gpmc ad 8 -> DSS DATA 23 */ > + 0x024 (PIN_OUTPUT_PULLUP | MUX_MODE1) > + 0x028 (PIN_OUTPUT_PULLUP | MUX_MODE1) > + 0x02c (PIN_OUTPUT_PULLUP | MUX_MODE1) > + 0x030 (PIN_OUTPUT_PULLUP | MUX_MODE1) > + 0x034 (PIN_OUTPUT_PULLUP | MUX_MODE1) > + 0x038 (PIN_OUTPUT_PULLUP | MUX_MODE1) > + 0x03c (PIN_OUTPUT_PULLUP | MUX_MODE1) /* gpmc ad 15 -> DSS DATA 16 */ > + 0x0a0 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS DATA 0 */ > + 0x0a4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0a8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0ac (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0b0 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0b4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0b8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0bc (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0c0 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0c4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0c8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0cc (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0d0 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0d4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0d8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > + 0x0dc (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS DATA 15 */ > + 0x0e0 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS VSYNC */ > + 0x0e4 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS HSYNC */ > + 0x0e8 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS PCLK */ > + 0x0ec (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS AC BIAS EN */ > + > + >; > + }; > + > + qspi_pins: qspi_pins { > + pinctrl-single,pins = < > + 0x7c (PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_csn0.qspi_csn */ > + 0x88 (PIN_OUTPUT | MUX_MODE2) /* gpmc_csn3.qspi_clk */ > + 0x90 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_advn_ale.qspi_d0 */ > + 0x94 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_oen_ren.qspi_d1 */ > + 0x98 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_wen.qspi_d2 */ > + 0x9c (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_be0n_cle.qspi_d3 */ > + >; > + }; > + > + mcasp1_pins: mcasp1_pins { > + pinctrl-single,pins = < > + 0x10c (PIN_INPUT_PULLDOWN | MUX_MODE4) /* mii1_crs.mcasp1_aclkx */ > + 0x110 (PIN_INPUT_PULLDOWN | MUX_MODE4) /* mii1_rxerr.mcasp1_fsx */ > + 0x108 (PIN_OUTPUT_PULLDOWN | MUX_MODE4) /* mii1_col.mcasp1_axr2 */ > + 0x144 (PIN_INPUT_PULLDOWN | MUX_MODE4) /* rmii1_ref_clk.mcasp1_axr3 */ > + >; > + }; > + > + lcd_pins: lcd_pins { > + pinctrl-single,pins = < > + /* GPIO 5_8 to select LCD / HDMI */ > + 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) > + >; > + }; > +}; > + > +&i2c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; what speed are you running this on? -> also can you align these to 1 tab instead of spaces? > + > + tps@24 { > + compatible = "ti,tps65218"; > + reg = <0x24>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; is this muxed? > + interrupt-controller; > + #interrupt-cells = <2>; > + > + dcdc1: regulator-dcdc1 { > + compatible = "ti,tps65218-dcdc1"; > + /* VDD_CORE limits min of OPP50 and max of OPP100 */ > + regulator-name = "vdd_core"; > + regulator-min-microvolt = <912000>; > + regulator-max-microvolt = <1144000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + dcdc2: regulator-dcdc2 { > + compatible = "ti,tps65218-dcdc2"; > + /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */ > + regulator-name = "vdd_mpu"; > + regulator-min-microvolt = <912000>; > + regulator-max-microvolt = <1378000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + dcdc3: regulator-dcdc3 { > + compatible = "ti,tps65218-dcdc3"; > + regulator-name = "vdds_ddr"; no voltage ? > + regulator-boot-on; > + regulator-always-on; > + }; > + > + dcdc4: regulator-dcdc4 { > + compatible = "ti,tps65218-dcdc4"; > + regulator-name = "v3_3d"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: regulator-ldo1 { > + compatible = "ti,tps65218-ldo1"; > + regulator-name = "v1_8d"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + }; > + > + at24@50 { > + compatible = "at24,24c256"; > + pagesize = <64>; > + reg = <0x50>; > + }; > +}; > + > +&i2c1 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; ^^ alignment problem Also speed please. > + > + edt-ft5306@38 { > + status = "okay"; > + compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; > + pinctrl-names = "default"; > + pinctrl-0 = <&edt_ft5306_ts_pins>; > + reg = <0x38>; > + interrupt-parent = <&gpio0>; > + interrupts = <31 0>; > + > + wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; why wake-gpios? we should be using pinctrl with interrupt-extended to do wakeup sequence, no? > + > + touchscreen-size-x = <480>; > + touchscreen-size-y = <272>; > + }; > + > + tlv320aic3106: tlv320aic3106@1b { > + compatible = "ti,tlv320aic3106"; > + reg = <0x1b>; > + status = "okay"; > + > + /* Regulators */ > + AVDD-supply = <&dcdc4>; > + IOVDD-supply = <&dcdc4>; > + DRVDD-supply = <&dcdc4>; > + DVDD-supply = <&ldo1>; > + }; > + > + lis331dlh@18 { > + compatible = "st,lis331dlh"; > + reg = <0x18>; > + status = "okay"; > + > + Vdd-supply = <&dcdc4>; > + Vdd_IO-supply = <&dcdc4>; > + interrupts-extended = <&gpio1 6 0>, <&gpio2 1 0>; > + }; > +}; > + > +&epwmss0 { > + status = "okay"; > +}; > + > +&ecap0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&ecap0_pins>; > +}; > + > +&gpio0 { > + status = "okay"; > +}; > + > +&gpio1 { > + status = "okay"; > +}; > + > +&gpio5 { > + status = "okay"; > +}; > + > +&mmc1 { > + status = "okay"; > + vmmc-supply = <&dcdc4>; > + bus-width = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc1_pins>; just for style, wonder if moving the pinctrl just after status is better? > + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > +}; > + > +&usb2_phy1 { > + status = "okay"; > +}; > + > +&usb1 { > + dr_mode = "peripheral"; > + status = "okay"; > +}; > + > +&usb2_phy2 { > + status = "okay"; > +}; > + > +&usb2 { > + dr_mode = "host"; > + status = "okay"; > +}; none of the above need pinctrl? no regulator supplies? > + > +&qspi { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&qspi_pins>; > + > + spi-max-frequency = <48000000>; > + m25p80@0 { > + compatible = "mx66l51235l"; > + spi-max-frequency = <48000000>; > + reg = <0>; > + spi-cpol; > + spi-cpha; > + spi-tx-bus-width = <1>; > + spi-rx-bus-width = <4>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + /* MTD partition table. /* * MTD partition table. ? > + * The ROM checks the first 512KiB > + * for a valid file to boot(XIP). > + */ > + partition@0 { > + label = "QSPI.U_BOOT"; > + reg = <0x00000000 0x000080000>; > + }; > + partition@1 { > + label = "QSPI.U_BOOT.backup"; > + reg = <0x00080000 0x00080000>; > + }; > + partition@2 { > + label = "QSPI.U-BOOT-SPL_OS"; > + reg = <0x00100000 0x00010000>; > + }; > + partition@3 { > + label = "QSPI.U_BOOT_ENV"; > + reg = <0x00110000 0x00010000>; > + }; > + partition@4 { > + label = "QSPI.U-BOOT-ENV.backup"; > + reg = <0x00120000 0x00010000>; > + }; > + partition@5 { > + label = "QSPI.KERNEL"; > + reg = <0x00130000 0x0800000>; > + }; > + partition@6 { > + label = "QSPI.FILESYSTEM"; > + reg = <0x00930000 0x36D0000>; > + }; > + }; > +}; > + > +&mac { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&cpsw_default>; > + pinctrl-1 = <&cpsw_sleep>; > + dual_emac = <1>; > + status = "okay"; > +}; > + > +&davinci_mdio { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&davinci_mdio_default>; > + pinctrl-1 = <&davinci_mdio_sleep>; > + status = "okay"; > +}; > + > +&cpsw_emac0 { > + phy_id = <&davinci_mdio>, <4>; > + phy-mode = "rgmii"; > + dual_emac_res_vlan = <1>; > +}; > + > +&cpsw_emac1 { > + phy_id = <&davinci_mdio>, <5>; > + phy-mode = "rgmii"; > + dual_emac_res_vlan = <2>; > +}; > + > +&elm { > + status = "okay"; > +}; > + > +&mcasp1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mcasp1_pins>; > + > + status = "okay"; > + > + op-mode = <0>; > + tdm-slots = <2>; > + serial-dir = < > + 0 0 1 2 > + >; > + > + tx-num-evt = <1>; > + rx-num-evt = <1>; > +}; > + > +&dss { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&dss_pins>; > + > + port { > + dpi_out: endpoint@0 { > + remote-endpoint = <&lcd_in>; > + data-lines = <24>; > + }; > + }; > +}; > + > +&rtc { > + status = "okay"; > +}; > + > +&wdt { > + status = "okay"; > +}; > -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit 2014-06-18 16:14 ` Nishanth Menon @ 2014-06-18 19:31 ` Felipe Balbi [not found] ` <20140618193113.GC4570-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> 0 siblings, 1 reply; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 19:31 UTC (permalink / raw) To: Nishanth Menon Cc: Felipe Balbi, Benoit Cousson, robh+dt, galak, Tony Lindgren, linux, Rajendra Nayak, r.sricharan, devicetree, Linux Kernel Mailing List, Linux ARM Kernel Mailing List, Linux OMAP Mailing List, Josh Elliot, Darren Etheridge [-- Attachment #1: Type: text/plain, Size: 18742 bytes --] On Wed, Jun 18, 2014 at 11:14:21AM -0500, Nishanth Menon wrote: > On 06/18/2014 10:43 AM, Felipe Balbi wrote: > > Add support for TI's AM437x StarterKit Evaluation > > Module. > > is there a link for this platform? internal only > > Cc: Josh Elliot <jelliott@ti.com> > > Cc: Darren Etheridge <detheridge@ti.com> > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > --- > > .../devicetree/bindings/arm/omap/omap.txt | 3 + > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/am437x-sk-evm.dts | 583 +++++++++++++++++++++ > > 3 files changed, 587 insertions(+) > > create mode 100644 arch/arm/boot/dts/am437x-sk-evm.dts > > > > diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt > > index d22b216..0edc903 100644 > > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt > > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt > > @@ -129,6 +129,9 @@ Boards: > > - AM437x GP EVM > > compatible = "ti,am437x-gp-evm", "ti,am4372", "ti,am43" > > > > +- AM437x SK EVM: AM437x StarterKit Evaluation Module > > + compatible = "ti,am437x-sk-evm", "ti,am4372", "ti,am43" > > + > > - DRA742 EVM: Software Development Board for DRA742 > > compatible = "ti,dra7-evm", "ti,dra742", "ti,dra74", "ti,dra7" > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 621c6c5..a85a4b8 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += omap4-duovero-parlor.dtb \ > > omap4-var-dvk-om44.dtb \ > > omap4-var-stk-om44.dtb > > dtb-$(CONFIG_SOC_AM43XX) += am43x-epos-evm.dtb \ > > + am437x-sk-evm.dtb \ > > am437x-gp-evm.dtb > > dtb-$(CONFIG_SOC_OMAP5) += omap5-cm-t54.dtb \ > > omap5-sbc-t54.dtb \ > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > > new file mode 100644 > > index 0000000..e7a2bbe > > --- /dev/null > > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > > @@ -0,0 +1,583 @@ > > +/* > > + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/ > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > + > > +/* AM437x SK EVM */ > ?? > > + > > +/dts-v1/; > > + > > +#include "am4372.dtsi" > > +#include <dt-bindings/pinctrl/am43xx.h> > > +#include <dt-bindings/pwm/pwm.h> > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/input/input.h> > > + > > +/ { > > + model = "TI AM437x SK EVM"; > > + compatible = "ti,am437x-sk-evm","ti,am4372","ti,am43"; > > + > > + aliases { > > + display0 = &lcd0; > > + }; > > + > > + backlight { > > + compatible = "pwm-backlight"; > > + pwms = <&ecap0 0 50000 PWM_POLARITY_INVERTED>; > > + brightness-levels = <0 51 53 56 62 75 101 152 255>; > > + default-brightness-level = <8>; > > + }; > > + > > + sound { > > + compatible = "ti,da830-evm-audio"; > > + ti,model = "AM437x-SK-EVM"; > > + ti,audio-codec = <&tlv320aic3106>; > > + ti,mcasp-controller = <&mcasp1>; > > + ti,codec-clock-rate = <24000000>; > > + ti,audio-routing = > > + "Headphone Jack", "HPLOUT", > > + "Headphone Jack", "HPROUT"; > > + }; > > + > > + matrix_keypad: matrix_keypad@0 { > > + compatible = "gpio-matrix-keypad"; > > no pinctrl needed? pins are gpio by default > > + debounce-delay-ms = <5>; > > + col-scan-delay-us = <1500>; > > + > > + row-gpios = <&gpio5 5 GPIO_ACTIVE_HIGH /* Bank5, pin5 */ > > + &gpio5 6 GPIO_ACTIVE_HIGH>; /* Bank5, pin6 */ > > + > > + col-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH /* Bank5, pin13 */ > > + &gpio5 4 GPIO_ACTIVE_HIGH>; /* Bank5, pin4 */ > > + > > + linux,keymap = < > > + MATRIX_KEY(0, 0, KEY_DOWN) > > + MATRIX_KEY(0, 1, KEY_RIGHT) > > + MATRIX_KEY(1, 0, KEY_LEFT) > > + MATRIX_KEY(1, 1, KEY_UP) > > + >; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > no pinctrl needed? likewise > > + led@0 { > > + label = "am437x-sk:red:heartbeat"; > > + gpios = <&gpio5 0 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 0 */ > > + linux,default-trigger = "heartbeat"; > > + default-state = "off"; > > + }; > > + > > + led@1 { > > + label = "am437x-sk:green:mmc1"; > > + gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 1 */ > > + linux,default-trigger = "mmc0"; > > + default-state = "off"; > > + }; > > + > > + led@2 { > > + label = "am437x-sk:blue:cpu0"; > > + gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 2 */ > > + linux,default-trigger = "cpu0"; > > + default-state = "off"; > > + }; > > + > > + led@3 { > > + label = "am437x-sk:blue:usr3"; > > + gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>; /* Bank 5, pin 3 */ > > + default-state = "off"; > > + }; > > + }; > > + > > + lcd0: display { > > + compatible = "osddisplays,osd057T0559-34ts", "panel-dpi"; > > + label = "lcd"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&lcd_pins>; > > + > > + enable-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>; > > + > > + panel-timing { > > + clock-frequency = <9000000>; > > + hactive = <480>; > > + vactive = <272>; > > + hfront-porch = <8>; > > + hback-porch = <43>; > > + hsync-len = <4>; > > + vback-porch = <12>; > > + vfront-porch = <4>; > > + vsync-len = <10>; > > + hsync-active = <0>; > > + vsync-active = <0>; > > + de-active = <1>; > > + pixelclk-active = <1>; > > + }; > > + > > + port { > > + lcd_in: endpoint { > > + remote-endpoint = <&dpi_out>; > > + }; > > + }; > > + }; > > +}; > > + > > +&am43xx_pinmux { > > + i2c0_pins: i2c0_pins { > > + pinctrl-single,pins = < > > + 0x188 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_sda.i2c0_sda */ > > + 0x18c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_scl.i2c0_scl */ > > + >; > > + }; > > + > > + i2c1_pins: i2c1_pins { > > + pinctrl-single,pins = < > > + 0x15c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2) /* spi0_cs0.i2c1_scl */ > > + 0x158 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2) /* spi0_d1.i2c1_sda */ > > + >; > > + }; > > + > > + mmc1_pins: pinmux_mmc1_pins { > > + pinctrl-single,pins = < > > + 0x160 (PIN_INPUT | MUX_MODE7) /* spi0_cs1.gpio0_6 */ > > + >; > > + }; > > + > > + ecap0_pins: backlight_pins { > > + pinctrl-single,pins = < > > + 0x164 MUX_MODE0 /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */ > pin direction? > > + >; > > + }; > > + > > + edt_ft5306_ts_pins: edt_ft5306_ts_pins { > > + pinctrl-single,pins = < > > + 0x74 (PIN_INPUT | MUX_MODE7) /* gpmc_wpn.gpio0_31 */ > > + 0x78 (PIN_OUTPUT | MUX_MODE7) /* gpmc_be1n.gpio1_28 */ > > + >; > > + }; > > + > > + cpsw_default: cpsw_default { > > + pinctrl-single,pins = < > > + /* Slave 1 */ > > + 0x12c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txclk.rmii1_tclk */ > > + 0x114 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txen.rgmii1_tctl */ > > + 0x128 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd0.rgmii1_td0 */ > > + 0x124 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd1.rgmii1_td1 */ > > + 0x120 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd0.rgmii1_td2 */ > > + 0x11c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* mii1_txd1.rgmii1_td3 */ > > + 0x130 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxclk.rmii1_rclk */ > > + 0x118 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxdv.rgmii1_rctl */ > > + 0x140 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd0.rgmii1_rd0 */ > > + 0x13c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd1.rgmii1_rd1 */ > > + 0x138 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd0.rgmii1_rd2 */ > > + 0x134 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* mii1_rxd1.rgmii1_rd3 */ > > + > > + /* Slave 2 */ > > + 0x58 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a6.rgmii2_tclk */ > > + 0x40 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a0.rgmii2_tctl */ > > + 0x54 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a5.rgmii2_td0 */ > > + 0x50 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a4.rgmii2_td1 */ > > + 0x4c (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a3.rgmii2_td2 */ > > + 0x48 (PIN_OUTPUT_PULLDOWN | MUX_MODE2) /* gpmc_a2.rgmii2_td3 */ > > + 0x5c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a7.rgmii2_rclk */ > > + 0x44 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a1.rgmii2_rtcl */ > > + 0x6c (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a11.rgmii2_rd0 */ > > + 0x68 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a10.rgmii2_rd1 */ > > + 0x64 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a9.rgmii2_rd2 */ > > + 0x60 (PIN_INPUT_PULLDOWN | MUX_MODE2) /* gpmc_a8.rgmii2_rd3 */ > > + >; > > + }; > > + > > + cpsw_sleep: cpsw_sleep { > > + pinctrl-single,pins = < > > + /* Slave 1 reset value */ > > + 0x12c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x114 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x128 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x124 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x120 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x11c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x130 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x118 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x140 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x13c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x138 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x134 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + > > + /* Slave 2 reset value */ > > + 0x58 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x40 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x54 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x50 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x4c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x48 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x5c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x44 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x6c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x68 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x64 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x60 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + >; > > + }; > > + > > + davinci_mdio_default: davinci_mdio_default { > > + pinctrl-single,pins = < > > + /* MDIO */ > > + 0x148 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* mdio_data.mdio_data */ > > + 0x14c (PIN_OUTPUT_PULLUP | MUX_MODE0) /* mdio_clk.mdio_clk */ > > + >; > > + }; > > + > > + davinci_mdio_sleep: davinci_mdio_sleep { > > + pinctrl-single,pins = < > > + /* MDIO reset value */ > > + 0x148 (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + 0x14c (PIN_INPUT_PULLDOWN | MUX_MODE7) > > + >; > > + }; > > + > > + dss_pins: dss_pins { > > + pinctrl-single,pins = < > > + 0x020 (PIN_OUTPUT_PULLUP | MUX_MODE1) /* gpmc ad 8 -> DSS DATA 23 */ > > + 0x024 (PIN_OUTPUT_PULLUP | MUX_MODE1) > > + 0x028 (PIN_OUTPUT_PULLUP | MUX_MODE1) > > + 0x02c (PIN_OUTPUT_PULLUP | MUX_MODE1) > > + 0x030 (PIN_OUTPUT_PULLUP | MUX_MODE1) > > + 0x034 (PIN_OUTPUT_PULLUP | MUX_MODE1) > > + 0x038 (PIN_OUTPUT_PULLUP | MUX_MODE1) > > + 0x03c (PIN_OUTPUT_PULLUP | MUX_MODE1) /* gpmc ad 15 -> DSS DATA 16 */ > > + 0x0a0 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS DATA 0 */ > > + 0x0a4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0a8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0ac (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0b0 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0b4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0b8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0bc (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0c0 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0c4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0c8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0cc (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0d0 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0d4 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0d8 (PIN_OUTPUT_PULLUP | MUX_MODE0) > > + 0x0dc (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS DATA 15 */ > > + 0x0e0 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS VSYNC */ > > + 0x0e4 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS HSYNC */ > > + 0x0e8 (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS PCLK */ > > + 0x0ec (PIN_OUTPUT_PULLUP | MUX_MODE0) /* DSS AC BIAS EN */ > > + > > + >; > > + }; > > + > > + qspi_pins: qspi_pins { > > + pinctrl-single,pins = < > > + 0x7c (PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_csn0.qspi_csn */ > > + 0x88 (PIN_OUTPUT | MUX_MODE2) /* gpmc_csn3.qspi_clk */ > > + 0x90 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_advn_ale.qspi_d0 */ > > + 0x94 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_oen_ren.qspi_d1 */ > > + 0x98 (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_wen.qspi_d2 */ > > + 0x9c (PIN_INPUT_PULLUP | MUX_MODE3) /* gpmc_be0n_cle.qspi_d3 */ > > + >; > > + }; > > + > > + mcasp1_pins: mcasp1_pins { > > + pinctrl-single,pins = < > > + 0x10c (PIN_INPUT_PULLDOWN | MUX_MODE4) /* mii1_crs.mcasp1_aclkx */ > > + 0x110 (PIN_INPUT_PULLDOWN | MUX_MODE4) /* mii1_rxerr.mcasp1_fsx */ > > + 0x108 (PIN_OUTPUT_PULLDOWN | MUX_MODE4) /* mii1_col.mcasp1_axr2 */ > > + 0x144 (PIN_INPUT_PULLDOWN | MUX_MODE4) /* rmii1_ref_clk.mcasp1_axr3 */ > > + >; > > + }; > > + > > + lcd_pins: lcd_pins { > > + pinctrl-single,pins = < > > + /* GPIO 5_8 to select LCD / HDMI */ > > + 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) > > + >; > > + }; > > +}; > > + > > +&i2c0 { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c0_pins>; > > what speed are you running this on? -> also can you align these to 1 100kHz ? > tab instead of spaces? weird, I remember aligning everything with tabs. Will fix that up. > > + tps@24 { > > + compatible = "ti,tps65218"; > > + reg = <0x24>; > > + interrupt-parent = <&gic>; > > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > > is this muxed? there's no configuration for this. This pin is a single function. > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + > > + dcdc1: regulator-dcdc1 { > > + compatible = "ti,tps65218-dcdc1"; > > + /* VDD_CORE limits min of OPP50 and max of OPP100 */ > > + regulator-name = "vdd_core"; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <1144000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + dcdc2: regulator-dcdc2 { > > + compatible = "ti,tps65218-dcdc2"; > > + /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */ > > + regulator-name = "vdd_mpu"; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <1378000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + dcdc3: regulator-dcdc3 { > > + compatible = "ti,tps65218-dcdc3"; > > + regulator-name = "vdds_ddr"; > no voltage ? has no users in kernel. Also, it comes out with default, and correct, voltage. > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + dcdc4: regulator-dcdc4 { > > + compatible = "ti,tps65218-dcdc4"; > > + regulator-name = "v3_3d"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo1: regulator-ldo1 { > > + compatible = "ti,tps65218-ldo1"; > > + regulator-name = "v1_8d"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + }; > > + > > + at24@50 { > > + compatible = "at24,24c256"; > > + pagesize = <64>; > > + reg = <0x50>; > > + }; > > +}; > > + > > +&i2c1 { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > ^^ alignment problem > > Also speed please. will add. > > + edt-ft5306@38 { > > + status = "okay"; > > + compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&edt_ft5306_ts_pins>; > > + reg = <0x38>; > > + interrupt-parent = <&gpio0>; > > + interrupts = <31 0>; > > + > > + wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > > why wake-gpios? we should be using pinctrl with interrupt-extended to > do wakeup sequence, no? sure, can you patch the edt driver ? I'll fix the DTS after that gets merged > > + touchscreen-size-x = <480>; > > + touchscreen-size-y = <272>; > > + }; > > + > > + tlv320aic3106: tlv320aic3106@1b { > > + compatible = "ti,tlv320aic3106"; > > + reg = <0x1b>; > > + status = "okay"; > > + > > + /* Regulators */ > > + AVDD-supply = <&dcdc4>; > > + IOVDD-supply = <&dcdc4>; > > + DRVDD-supply = <&dcdc4>; > > + DVDD-supply = <&ldo1>; > > + }; > > + > > + lis331dlh@18 { > > + compatible = "st,lis331dlh"; > > + reg = <0x18>; > > + status = "okay"; > > + > > + Vdd-supply = <&dcdc4>; > > + Vdd_IO-supply = <&dcdc4>; > > + interrupts-extended = <&gpio1 6 0>, <&gpio2 1 0>; > > + }; > > +}; > > + > > +&epwmss0 { > > + status = "okay"; > > +}; > > + > > +&ecap0 { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&ecap0_pins>; > > +}; > > + > > +&gpio0 { > > + status = "okay"; > > +}; > > + > > +&gpio1 { > > + status = "okay"; > > +}; > > + > > +&gpio5 { > > + status = "okay"; > > +}; > > + > > +&mmc1 { > > + status = "okay"; > > + vmmc-supply = <&dcdc4>; > > + bus-width = <4>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&mmc1_pins>; > > just for style, wonder if moving the pinctrl just after status is better? why ? makes no difference. > > + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > > +}; > > + > > +&usb2_phy1 { > > + status = "okay"; > > +}; > > + > > +&usb1 { > > + dr_mode = "peripheral"; > > + status = "okay"; > > +}; > > + > > +&usb2_phy2 { > > + status = "okay"; > > +}; > > + > > +&usb2 { > > + dr_mode = "host"; > > + status = "okay"; > > +}; > none of the above need pinctrl? no regulator supplies? pins in default states, drivers don't use regulators. > > +&qspi { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&qspi_pins>; > > + > > + spi-max-frequency = <48000000>; > > + m25p80@0 { > > + compatible = "mx66l51235l"; > > + spi-max-frequency = <48000000>; > > + reg = <0>; > > + spi-cpol; > > + spi-cpha; > > + spi-tx-bus-width = <1>; > > + spi-rx-bus-width = <4>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + /* MTD partition table. > /* > * MTD partition table. > ? can be fixed. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20140618193113.GC4570-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>]
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit [not found] ` <20140618193113.GC4570-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> @ 2014-06-18 21:54 ` Nishanth Menon 2014-06-18 23:19 ` Felipe Balbi 0 siblings, 1 reply; 17+ messages in thread From: Nishanth Menon @ 2014-06-18 21:54 UTC (permalink / raw) To: balbi-l0cyMroinI0 Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-lFZ/pmaqli7XmaaqVzeoHQ, Josh Elliot, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan-l0cyMroinI0, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Benoit Cousson, galak-sgV2jX0FEOL9JmXXK+q4OQ, Linux OMAP Mailing List, Linux ARM Kernel Mailing List On 06/18/2014 02:31 PM, Felipe Balbi wrote: > On Wed, Jun 18, 2014 at 11:14:21AM -0500, Nishanth Menon wrote: >> On 06/18/2014 10:43 AM, Felipe Balbi wrote: >>> Add support for TI's AM437x StarterKit Evaluation >>> Module. >> >> is there a link for this platform? > > internal only but will eventually be sold externally? I assume this is not an TI internal only board. [...] >>> + >>> + matrix_keypad: matrix_keypad@0 { >>> + compatible = "gpio-matrix-keypad"; >> >> no pinctrl needed? > > pins are gpio by default Might be good to explicitly configure it - no strong opinions though -> GPIOs are always good to pinctrl up esp if bootloader screws up at a later date. [...] >>> +&i2c0 { >>> + status = "okay"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&i2c0_pins>; >> >> what speed are you running this on? -> also can you align these to 1 > > 100kHz ? Rule of thumb is to do the following: MIN(MAX_FREQ(D1), MAX_FREQ(D2).... MAX_FREQ(Dn)); where D1..n are all the peripherals on this i2c bus. >>> + tps@24 { >>> + compatible = "ti,tps65218"; >>> + reg = <0x24>; >>> + interrupt-parent = <&gic>; >>> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; >> >> is this muxed? > > there's no configuration for this. This pin is a single function. > >>> + interrupt-controller; >>> + #interrupt-cells = <2>; >>> + >>> + dcdc1: regulator-dcdc1 { >>> + compatible = "ti,tps65218-dcdc1"; >>> + /* VDD_CORE limits min of OPP50 and max of OPP100 */ >>> + regulator-name = "vdd_core"; >>> + regulator-min-microvolt = <912000>; >>> + regulator-max-microvolt = <1144000>; >>> + regulator-boot-on; >>> + regulator-always-on; >>> + }; >>> + >>> + dcdc2: regulator-dcdc2 { >>> + compatible = "ti,tps65218-dcdc2"; >>> + /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */ >>> + regulator-name = "vdd_mpu"; >>> + regulator-min-microvolt = <912000>; >>> + regulator-max-microvolt = <1378000>; >>> + regulator-boot-on; >>> + regulator-always-on; >>> + }; >>> + >>> + dcdc3: regulator-dcdc3 { >>> + compatible = "ti,tps65218-dcdc3"; >>> + regulator-name = "vdds_ddr"; >> no voltage ? > > has no users in kernel. Also, it comes out with default, and correct, > voltage. Device tree is description of hardware, not just who uses what in OS of interest. you might consider u-boot to use the same device tree at a later date and having complete details about the hardware is always the norm. I suggest setting the voltage here to be complete even if there are no current users. >>> + edt-ft5306@38 { >>> + status = "okay"; >>> + compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&edt_ft5306_ts_pins>; >>> + reg = <0x38>; >>> + interrupt-parent = <&gpio0>; >>> + interrupts = <31 0>; >>> + >>> + wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> >> why wake-gpios? we should be using pinctrl with interrupt-extended to >> do wakeup sequence, no? > > sure, can you patch the edt driver ? I'll fix the DTS after that gets > merged If you really want to go down that road, so you could probably help review the pinctrl patches I posted to enable pinctrl wakeup[1]? Come on, as of today, there is no ability to suspend AM437x without doing [1], let alone talk about wakeup gpio vs interrupt-extended. and do we really want to wakeup from suspend when touch screen is touched? Do you expect wake-gpio to work even after doing interrupt based solution? I am no edt driver expert... maybe you can help me here. >>> +&mmc1 { >>> + status = "okay"; >>> + vmmc-supply = <&dcdc4>; >>> + bus-width = <4>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&mmc1_pins>; >> >> just for style, wonder if moving the pinctrl just after status is better? > > why ? makes no difference. it does not - I agree, except, when you look at all other nodes: status="okay" pinctrl other things.. it is just a symmetry thing, I guess.. > >>> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; >>> +}; >>> + >>> +&usb2_phy1 { >>> + status = "okay"; >>> +}; >>> + >>> +&usb1 { >>> + dr_mode = "peripheral"; >>> + status = "okay"; >>> +}; >>> + >>> +&usb2_phy2 { >>> + status = "okay"; >>> +}; >>> + >>> +&usb2 { >>> + dr_mode = "host"; >>> + status = "okay"; >>> +}; >> none of the above need pinctrl? no regulator supplies? > > pins in default states, drivers don't use regulators. USB works without a supply? even a fixed voltage supply? that is weird. [..] [1] http://marc.info/?l=devicetree&m=140301966510748&w=2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit 2014-06-18 21:54 ` Nishanth Menon @ 2014-06-18 23:19 ` Felipe Balbi [not found] ` <20140618231923.GA9855-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> 2014-06-19 2:26 ` Nishanth Menon 0 siblings, 2 replies; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 23:19 UTC (permalink / raw) To: Nishanth Menon Cc: balbi, devicetree, linux, Josh Elliot, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan, robh+dt, Benoit Cousson, galak, Linux OMAP Mailing List, Linux ARM Kernel Mailing List [-- Attachment #1: Type: text/plain, Size: 6231 bytes --] Hi, On Wed, Jun 18, 2014 at 04:54:05PM -0500, Nishanth Menon wrote: > On 06/18/2014 02:31 PM, Felipe Balbi wrote: > >On Wed, Jun 18, 2014 at 11:14:21AM -0500, Nishanth Menon wrote: > >>On 06/18/2014 10:43 AM, Felipe Balbi wrote: > >>>Add support for TI's AM437x StarterKit Evaluation > >>>Module. > >> > >>is there a link for this platform? > > > >internal only > > but will eventually be sold externally? I assume this is not an TI probably, but there's nothing public yet. > internal only board. correct assumption for all I know. > [...] > >>>+ > >>>+ matrix_keypad: matrix_keypad@0 { > >>>+ compatible = "gpio-matrix-keypad"; > >> > >>no pinctrl needed? > > > >pins are gpio by default > > Might be good to explicitly configure it - no strong opinions though > -> GPIOs are always good to pinctrl up esp if bootloader screws up at > a later date. I find that very unlikely and don't quite like the idea of accessing registers unnecessarily. OTOH, I don't quite care, to be frank. > >>>+&i2c0 { > >>>+ status = "okay"; > >>>+ pinctrl-names = "default"; > >>>+ pinctrl-0 = <&i2c0_pins>; > >> > >>what speed are you running this on? -> also can you align these to 1 > > > >100kHz ? > > Rule of thumb is to do the following: MIN(MAX_FREQ(D1), > MAX_FREQ(D2).... MAX_FREQ(Dn)); where D1..n are all the peripherals on > this i2c bus. hehe, right. > >>>+ interrupt-controller; > >>>+ #interrupt-cells = <2>; > >>>+ > >>>+ dcdc1: regulator-dcdc1 { > >>>+ compatible = "ti,tps65218-dcdc1"; > >>>+ /* VDD_CORE limits min of OPP50 and max of OPP100 */ > >>>+ regulator-name = "vdd_core"; > >>>+ regulator-min-microvolt = <912000>; > >>>+ regulator-max-microvolt = <1144000>; > >>>+ regulator-boot-on; > >>>+ regulator-always-on; > >>>+ }; > >>>+ > >>>+ dcdc2: regulator-dcdc2 { > >>>+ compatible = "ti,tps65218-dcdc2"; > >>>+ /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */ > >>>+ regulator-name = "vdd_mpu"; > >>>+ regulator-min-microvolt = <912000>; > >>>+ regulator-max-microvolt = <1378000>; > >>>+ regulator-boot-on; > >>>+ regulator-always-on; > >>>+ }; > >>>+ > >>>+ dcdc3: regulator-dcdc3 { > >>>+ compatible = "ti,tps65218-dcdc3"; > >>>+ regulator-name = "vdds_ddr"; > >>no voltage ? > > > >has no users in kernel. Also, it comes out with default, and correct, > >voltage. > > Device tree is description of hardware, not just who uses what in OS > of interest. then we should start "fixing" every single DTS in the kernel because I'm sure even LEDs and keypads are tied to some sort of supply, as is the case with this board. No driver will use it though. Also, I couldn't find anywhere which voltage is dcdc3 outputing and there's no shunt anywhere (other than a 0 ohm resistor) to measure voltage. So I kinda have my hands tied here. (goes review schematics) actually there's 0.05 ohm sense resistor. Hopefully it's easy to access. > you might consider u-boot to use the same device tree at a later date and > having complete details about the hardware is always the norm. > > I suggest setting the voltage here to be complete even if there are no > current users. > > >>>+ edt-ft5306@38 { > >>>+ status = "okay"; > >>>+ compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; > >>>+ pinctrl-names = "default"; > >>>+ pinctrl-0 = <&edt_ft5306_ts_pins>; > >>>+ reg = <0x38>; > >>>+ interrupt-parent = <&gpio0>; > >>>+ interrupts = <31 0>; > >>>+ > >>>+ wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > >> > >>why wake-gpios? we should be using pinctrl with interrupt-extended to > >>do wakeup sequence, no? > > > >sure, can you patch the edt driver ? I'll fix the DTS after that gets > >merged > > If you really want to go down that road, so you could probably help > review the pinctrl patches I posted to enable pinctrl wakeup[1]? > > Come on, as of today, there is no ability to suspend AM437x without > doing [1], let alone talk about wakeup gpio vs interrupt-extended. and > do we really want to wakeup from suspend when touch screen is touched? > > Do you expect wake-gpio to work even after doing interrupt based > solution? I am no edt driver expert... maybe you can help me here. you missed the point entirely. This pin is not used for the touchscreen to wake SoC up, it's the other way around, see how the pin is an *output*. Pull it low and the touchscreen won't generate IRQs, won't respond to i2c accesses, etc. Pull it high, and the thing wakes up. > >>>+&mmc1 { > >>>+ status = "okay"; > >>>+ vmmc-supply = <&dcdc4>; > >>>+ bus-width = <4>; > >>>+ pinctrl-names = "default"; > >>>+ pinctrl-0 = <&mmc1_pins>; > >> > >>just for style, wonder if moving the pinctrl just after status is better? > > > >why ? makes no difference. > > it does not - I agree, except, when you look at all other nodes: > status="okay" > pinctrl > other things.. > > it is just a symmetry thing, I guess.. little bit of ocd, but sure. > >>>+ cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > >>>+}; > >>>+ > >>>+&usb2_phy1 { > >>>+ status = "okay"; > >>>+}; > >>>+ > >>>+&usb1 { > >>>+ dr_mode = "peripheral"; > >>>+ status = "okay"; > >>>+}; > >>>+ > >>>+&usb2_phy2 { > >>>+ status = "okay"; > >>>+}; > >>>+ > >>>+&usb2 { > >>>+ dr_mode = "host"; > >>>+ status = "okay"; > >>>+}; > >>none of the above need pinctrl? no regulator supplies? > > > >pins in default states, drivers don't use regulators. > > USB works without a supply? even a fixed voltage supply? that is > weird. take a look at the minicom output I posted if you don't believe. Well, to be exact, tps63010 [1] is the one which generates the regulated V5_0D which is used as VBUS_USB. The enable pin in that device is tied to the 3v3 rail (dcdc4 regulator in the PMIC as most everything else) but there's no way (otherwise) to control that thing. There's no control bus, no way to write a driver. Since the board will anyways turn off if you disable the 3v3 rail, it's pretty much pointless to figure out a hack just to add this to DTS. [1] http://www.ti.com/product/TPS63010 -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20140618231923.GA9855-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>]
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit [not found] ` <20140618231923.GA9855-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> @ 2014-06-18 23:23 ` Felipe Balbi 0 siblings, 0 replies; 17+ messages in thread From: Felipe Balbi @ 2014-06-18 23:23 UTC (permalink / raw) To: Felipe Balbi Cc: Nishanth Menon, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-lFZ/pmaqli7XmaaqVzeoHQ, Josh Elliot, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan-l0cyMroinI0, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Benoit Cousson, galak-sgV2jX0FEOL9JmXXK+q4OQ, Linux OMAP Mailing List, Linux ARM Kernel Mailing List [-- Attachment #1: Type: text/plain, Size: 1785 bytes --] Hi, (side note) On Wed, Jun 18, 2014 at 06:19:23PM -0500, Felipe Balbi wrote: > > >>>+ interrupt-controller; > > >>>+ #interrupt-cells = <2>; > > >>>+ > > >>>+ dcdc1: regulator-dcdc1 { > > >>>+ compatible = "ti,tps65218-dcdc1"; > > >>>+ /* VDD_CORE limits min of OPP50 and max of OPP100 */ > > >>>+ regulator-name = "vdd_core"; > > >>>+ regulator-min-microvolt = <912000>; > > >>>+ regulator-max-microvolt = <1144000>; > > >>>+ regulator-boot-on; > > >>>+ regulator-always-on; > > >>>+ }; > > >>>+ > > >>>+ dcdc2: regulator-dcdc2 { > > >>>+ compatible = "ti,tps65218-dcdc2"; > > >>>+ /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */ > > >>>+ regulator-name = "vdd_mpu"; > > >>>+ regulator-min-microvolt = <912000>; > > >>>+ regulator-max-microvolt = <1378000>; > > >>>+ regulator-boot-on; > > >>>+ regulator-always-on; > > >>>+ }; > > >>>+ > > >>>+ dcdc3: regulator-dcdc3 { > > >>>+ compatible = "ti,tps65218-dcdc3"; > > >>>+ regulator-name = "vdds_ddr"; > > >>no voltage ? > > > > > >has no users in kernel. Also, it comes out with default, and correct, > > >voltage. > > > > Device tree is description of hardware, not just who uses what in OS > > of interest. > > then we should start "fixing" every single DTS in the kernel because I'm > sure even LEDs and keypads are tied to some sort of supply, as is the > case with this board. No driver will use it though. > > Also, I couldn't find anywhere which voltage is dcdc3 outputing and > there's no shunt anywhere (other than a 0 ohm resistor) to measure > voltage. So I kinda have my hands tied here. > > (goes review schematics) > > actually there's 0.05 ohm sense resistor. Hopefully it's easy to access. 1.35v -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit 2014-06-18 23:19 ` Felipe Balbi [not found] ` <20140618231923.GA9855-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> @ 2014-06-19 2:26 ` Nishanth Menon [not found] ` <53A24A39.4080100-l0cyMroinI0@public.gmane.org> 1 sibling, 1 reply; 17+ messages in thread From: Nishanth Menon @ 2014-06-19 2:26 UTC (permalink / raw) To: balbi Cc: devicetree, linux, Benoit Cousson, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan, robh+dt, Josh Elliot, galak, Linux OMAP Mailing List, Linux ARM Kernel Mailing List On 06/18/2014 06:19 PM, Felipe Balbi wrote: [...] >>>>> Add support for TI's AM437x StarterKit Evaluation >>>>> Module. >>>> >>>> is there a link for this platform? >>> >>> internal only >> >> but will eventually be sold externally? I assume this is not an TI > > probably, but there's nothing public yet. > >> internal only board. > > correct assumption for all I know. Yikes.. ok.. I'd let Tony et.al make the call on this, I guess. [...] >>>>> + edt-ft5306@38 { >>>>> + status = "okay"; >>>>> + compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; >>>>> + pinctrl-names = "default"; >>>>> + pinctrl-0 = <&edt_ft5306_ts_pins>; >>>>> + reg = <0x38>; >>>>> + interrupt-parent = <&gpio0>; >>>>> + interrupts = <31 0>; >>>>> + >>>>> + wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >>>> >>>> why wake-gpios? we should be using pinctrl with interrupt-extended to >>>> do wakeup sequence, no? >>> >>> sure, can you patch the edt driver ? I'll fix the DTS after that gets >>> merged >> >> If you really want to go down that road, so you could probably help >> review the pinctrl patches I posted to enable pinctrl wakeup[1]? >> >> Come on, as of today, there is no ability to suspend AM437x without >> doing [1], let alone talk about wakeup gpio vs interrupt-extended. and >> do we really want to wakeup from suspend when touch screen is touched? >> >> Do you expect wake-gpio to work even after doing interrupt based >> solution? I am no edt driver expert... maybe you can help me here. > > you missed the point entirely. This pin is not used for the touchscreen > to wake SoC up, it's the other way around, see how the pin is an > *output*. Pull it low and the touchscreen won't generate IRQs, won't > respond to i2c accesses, etc. Pull it high, and the thing wakes up. Aaah.. My apologies.. I was confused. Thanks for clarifying. [...] >>>>> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; >>>>> +}; >>>>> + >>>>> +&usb2_phy1 { >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&usb1 { >>>>> + dr_mode = "peripheral"; >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&usb2_phy2 { >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&usb2 { >>>>> + dr_mode = "host"; >>>>> + status = "okay"; >>>>> +}; >>>> none of the above need pinctrl? no regulator supplies? >>> >>> pins in default states, drivers don't use regulators. >> >> USB works without a supply? even a fixed voltage supply? that is >> weird. > > take a look at the minicom output I posted if you don't believe. Well, > to be exact, tps63010 [1] is the one which generates the regulated V5_0D > which is used as VBUS_USB. The enable pin in that device is tied to the > 3v3 rail (dcdc4 regulator in the PMIC as most everything else) but > there's no way (otherwise) to control that thing. There's no control > bus, no way to write a driver. > > Since the board will anyways turn off if you disable the 3v3 rail, it's > pretty much pointless to figure out a hack just to add this to DTS. > > [1] http://www.ti.com/product/TPS63010 I am sure to trust you on the test log :) -> but then from dts description perspective, it is good if we describe the supplies, even as a always on fixed-regulator. We had instances like 2430SDP ethernet where... umm... we originally missed describing ethernet supply and boom, one fine morning, no more nfs filesystem - I mean, it is a one off scenario there, but describing regulators helps us atleast understand the power tree of the board a little better. Again, no strong opinions on my side, it is a good thing to do is all I feel about it. -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <53A24A39.4080100-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit [not found] ` <53A24A39.4080100-l0cyMroinI0@public.gmane.org> @ 2014-06-19 3:05 ` Felipe Balbi [not found] ` <20140619030520.GA13805-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> 0 siblings, 1 reply; 17+ messages in thread From: Felipe Balbi @ 2014-06-19 3:05 UTC (permalink / raw) To: Nishanth Menon Cc: balbi-l0cyMroinI0, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-lFZ/pmaqli7XmaaqVzeoHQ, Benoit Cousson, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan-l0cyMroinI0, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Josh Elliot, galak-sgV2jX0FEOL9JmXXK+q4OQ, Linux OMAP Mailing List, Linux ARM Kernel Mailing List [-- Attachment #1: Type: text/plain, Size: 4802 bytes --] Hi, On Wed, Jun 18, 2014 at 09:26:01PM -0500, Nishanth Menon wrote: > On 06/18/2014 06:19 PM, Felipe Balbi wrote: > [...] > >>>>>Add support for TI's AM437x StarterKit Evaluation > >>>>>Module. > >>>> > >>>>is there a link for this platform? > >>> > >>>internal only > >> > >>but will eventually be sold externally? I assume this is not an TI > > > >probably, but there's nothing public yet. > > > >>internal only board. > > > >correct assumption for all I know. > > Yikes.. ok.. I'd let Tony et.al make the call on this, I guess. would we really block a DTS just because there's no public wiki page available (yet) ? Sounds a bit extreme to me. > >>>>>+ edt-ft5306@38 { > >>>>>+ status = "okay"; > >>>>>+ compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; > >>>>>+ pinctrl-names = "default"; > >>>>>+ pinctrl-0 = <&edt_ft5306_ts_pins>; > >>>>>+ reg = <0x38>; > >>>>>+ interrupt-parent = <&gpio0>; > >>>>>+ interrupts = <31 0>; > >>>>>+ > >>>>>+ wake-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > >>>> > >>>>why wake-gpios? we should be using pinctrl with interrupt-extended to > >>>>do wakeup sequence, no? > >>> > >>>sure, can you patch the edt driver ? I'll fix the DTS after that gets > >>>merged > >> > >>If you really want to go down that road, so you could probably help > >>review the pinctrl patches I posted to enable pinctrl wakeup[1]? > >> > >>Come on, as of today, there is no ability to suspend AM437x without > >>doing [1], let alone talk about wakeup gpio vs interrupt-extended. and > >>do we really want to wakeup from suspend when touch screen is touched? > >> > >>Do you expect wake-gpio to work even after doing interrupt based > >>solution? I am no edt driver expert... maybe you can help me here. > > > >you missed the point entirely. This pin is not used for the touchscreen > >to wake SoC up, it's the other way around, see how the pin is an > >*output*. Pull it low and the touchscreen won't generate IRQs, won't > >respond to i2c accesses, etc. Pull it high, and the thing wakes up. > > Aaah.. My apologies.. I was confused. Thanks for clarifying. np > [...] > >>>>>+ cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > >>>>>+}; > >>>>>+ > >>>>>+&usb2_phy1 { > >>>>>+ status = "okay"; > >>>>>+}; > >>>>>+ > >>>>>+&usb1 { > >>>>>+ dr_mode = "peripheral"; > >>>>>+ status = "okay"; > >>>>>+}; > >>>>>+ > >>>>>+&usb2_phy2 { > >>>>>+ status = "okay"; > >>>>>+}; > >>>>>+ > >>>>>+&usb2 { > >>>>>+ dr_mode = "host"; > >>>>>+ status = "okay"; > >>>>>+}; > >>>>none of the above need pinctrl? no regulator supplies? > >>> > >>>pins in default states, drivers don't use regulators. > >> > >>USB works without a supply? even a fixed voltage supply? that is > >>weird. > > > >take a look at the minicom output I posted if you don't believe. Well, > >to be exact, tps63010 [1] is the one which generates the regulated V5_0D > >which is used as VBUS_USB. The enable pin in that device is tied to the > >3v3 rail (dcdc4 regulator in the PMIC as most everything else) but > >there's no way (otherwise) to control that thing. There's no control > >bus, no way to write a driver. > > > >Since the board will anyways turn off if you disable the 3v3 rail, it's > >pretty much pointless to figure out a hack just to add this to DTS. > > > >[1] http://www.ti.com/product/TPS63010 > > I am sure to trust you on the test log :) -> but then from dts description > perspective, it is good if we describe the supplies, even as a always on > fixed-regulator. We had instances like 2430SDP ethernet where... umm... we > originally missed describing ethernet supply and boom, one fine morning, no > more nfs filesystem - I mean, it is a one off scenario there, but describing > regulators helps us atleast understand the power tree of the board a little > better. > > Again, no strong opinions on my side, it is a good thing to do is all > I feel about it. you mean something like: V5_0D: fixedregulator@0 { compatible = "regulator-fixed"; regulator-name = "V5_0D"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; regulator-boot-on; regulator-always-on; vin-supply = <&dcdc4>; }; VBUS_USB: fixedregulator@1 { compatible = "regulator-fixed"; regulator-name = "VBUS_USB"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; regulator-boot-on; regulator-always-on; vin-supply = <&V5_0D>; }; I can add that, but note that it's *solely* to make sysfs look nice. And if that's the case, most likely *every* DTS file in tree today as incomplete. OTOH, I really consider this to be hugely unnecessary because of the fact that board will turn off if 3v3 (dcdc4) is disabled. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20140619030520.GA13805-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>]
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit [not found] ` <20140619030520.GA13805-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> @ 2014-06-19 3:17 ` Nishanth Menon 2014-06-19 4:02 ` Felipe Balbi 0 siblings, 1 reply; 17+ messages in thread From: Nishanth Menon @ 2014-06-19 3:17 UTC (permalink / raw) To: balbi-l0cyMroinI0 Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-lFZ/pmaqli7XmaaqVzeoHQ, Benoit Cousson, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan-l0cyMroinI0, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Josh Elliot, galak-sgV2jX0FEOL9JmXXK+q4OQ, Linux OMAP Mailing List, Linux ARM Kernel Mailing List On 06/18/2014 10:05 PM, Felipe Balbi wrote: > Hi, > > On Wed, Jun 18, 2014 at 09:26:01PM -0500, Nishanth Menon wrote: >> On 06/18/2014 06:19 PM, Felipe Balbi wrote: >> [...] >>>>>>> Add support for TI's AM437x StarterKit Evaluation >>>>>>> Module. >>>>>> >>>>>> is there a link for this platform? >>>>> >>>>> internal only >>>> >>>> but will eventually be sold externally? I assume this is not an TI >>> >>> probably, but there's nothing public yet. >>> >>>> internal only board. >>> >>> correct assumption for all I know. >> >> Yikes.. ok.. I'd let Tony et.al make the call on this, I guess. > > would we really block a DTS just because there's no public wiki page > available (yet) ? > > Sounds a bit extreme to me. If this is an TI internal board without anyone outside that a few select developers being able to get and work on it... I am a bit skeptical on upstream kernel support and burden for forseeable future in ensuring it is tested and continually maintained. if it an one-off.. maybe fork might be good enough.. upstream not too attractive. I mean, if it is targeted to be sold eventually, I have no objections or blocks - just make it clear in commit message. I can imagine folks wondering what the heck this is and googling without results(just like I did). [...] >>>>>>> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; >>>>>>> +}; >>>>>>> + >>>>>>> +&usb2_phy1 { >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>>> + >>>>>>> +&usb1 { >>>>>>> + dr_mode = "peripheral"; >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>>> + >>>>>>> +&usb2_phy2 { >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>>> + >>>>>>> +&usb2 { >>>>>>> + dr_mode = "host"; >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>> none of the above need pinctrl? no regulator supplies? >>>>> >>>>> pins in default states, drivers don't use regulators. >>>> >>>> USB works without a supply? even a fixed voltage supply? that is >>>> weird. >>> >>> take a look at the minicom output I posted if you don't believe. Well, >>> to be exact, tps63010 [1] is the one which generates the regulated V5_0D >>> which is used as VBUS_USB. The enable pin in that device is tied to the >>> 3v3 rail (dcdc4 regulator in the PMIC as most everything else) but >>> there's no way (otherwise) to control that thing. There's no control >>> bus, no way to write a driver. >>> >>> Since the board will anyways turn off if you disable the 3v3 rail, it's >>> pretty much pointless to figure out a hack just to add this to DTS. >>> >>> [1] http://www.ti.com/product/TPS63010 >> >> I am sure to trust you on the test log :) -> but then from dts description >> perspective, it is good if we describe the supplies, even as a always on >> fixed-regulator. We had instances like 2430SDP ethernet where... umm... we >> originally missed describing ethernet supply and boom, one fine morning, no >> more nfs filesystem - I mean, it is a one off scenario there, but describing >> regulators helps us atleast understand the power tree of the board a little >> better. >> >> Again, no strong opinions on my side, it is a good thing to do is all >> I feel about it. > > you mean something like: > > V5_0D: fixedregulator@0 { > compatible = "regulator-fixed"; > regulator-name = "V5_0D"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > regulator-boot-on; > regulator-always-on; > vin-supply = <&dcdc4>; > }; > > VBUS_USB: fixedregulator@1 { > compatible = "regulator-fixed"; > regulator-name = "VBUS_USB"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > regulator-boot-on; > regulator-always-on; > vin-supply = <&V5_0D>; > }; > > I can add that, but note that it's *solely* to make sysfs look nice. And > if that's the case, most likely *every* DTS file in tree today as > incomplete. OTOH, I really consider this to be hugely unnecessary > because of the fact that board will turn off if 3v3 (dcdc4) is disabled. > Yes - something along those lines - Again, no strong opinions on my side for these - just that it is a good thing to model in and may help drivers where can use the awareness. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit 2014-06-19 3:17 ` Nishanth Menon @ 2014-06-19 4:02 ` Felipe Balbi 0 siblings, 0 replies; 17+ messages in thread From: Felipe Balbi @ 2014-06-19 4:02 UTC (permalink / raw) To: Nishanth Menon Cc: balbi, devicetree, linux, Benoit Cousson, Tony Lindgren, Rajendra Nayak, Linux Kernel Mailing List, Darren Etheridge, r.sricharan, robh+dt, Josh Elliot, galak, Linux OMAP Mailing List, Linux ARM Kernel Mailing List [-- Attachment #1: Type: text/plain, Size: 4979 bytes --] Hi, On Wed, Jun 18, 2014 at 10:17:34PM -0500, Nishanth Menon wrote: > On 06/18/2014 10:05 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jun 18, 2014 at 09:26:01PM -0500, Nishanth Menon wrote: > >> On 06/18/2014 06:19 PM, Felipe Balbi wrote: > >> [...] > >>>>>>> Add support for TI's AM437x StarterKit Evaluation > >>>>>>> Module. > >>>>>> > >>>>>> is there a link for this platform? > >>>>> > >>>>> internal only > >>>> > >>>> but will eventually be sold externally? I assume this is not an TI > >>> > >>> probably, but there's nothing public yet. > >>> > >>>> internal only board. > >>> > >>> correct assumption for all I know. > >> > >> Yikes.. ok.. I'd let Tony et.al make the call on this, I guess. > > > > would we really block a DTS just because there's no public wiki page > > available (yet) ? > > > > Sounds a bit extreme to me. > > If this is an TI internal board without anyone outside that a few > select developers being able to get and work on it... I am a bit > skeptical on upstream kernel support and burden for forseeable future > in ensuring it is tested and continually maintained. if it an > one-off.. maybe fork might be good enough.. upstream not too attractive. dude, this is a Starter Kit after all. The probability of being sold eventually is really, really high. I just can't confirm it certainly will right now. > I mean, if it is targeted to be sold eventually, I have no objections > or blocks - just make it clear in commit message. I can imagine folks > wondering what the heck this is and googling without results(just like > I did). I'll point you to schematics and internal wiki tomorrow if you want. I'm sure there will be a public ti.com address for it though. > [...] > > >>>>>>> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > >>>>>>> +}; > >>>>>>> + > >>>>>>> +&usb2_phy1 { > >>>>>>> + status = "okay"; > >>>>>>> +}; > >>>>>>> + > >>>>>>> +&usb1 { > >>>>>>> + dr_mode = "peripheral"; > >>>>>>> + status = "okay"; > >>>>>>> +}; > >>>>>>> + > >>>>>>> +&usb2_phy2 { > >>>>>>> + status = "okay"; > >>>>>>> +}; > >>>>>>> + > >>>>>>> +&usb2 { > >>>>>>> + dr_mode = "host"; > >>>>>>> + status = "okay"; > >>>>>>> +}; > >>>>>> none of the above need pinctrl? no regulator supplies? > >>>>> > >>>>> pins in default states, drivers don't use regulators. > >>>> > >>>> USB works without a supply? even a fixed voltage supply? that is > >>>> weird. > >>> > >>> take a look at the minicom output I posted if you don't believe. Well, > >>> to be exact, tps63010 [1] is the one which generates the regulated V5_0D > >>> which is used as VBUS_USB. The enable pin in that device is tied to the > >>> 3v3 rail (dcdc4 regulator in the PMIC as most everything else) but > >>> there's no way (otherwise) to control that thing. There's no control > >>> bus, no way to write a driver. > >>> > >>> Since the board will anyways turn off if you disable the 3v3 rail, it's > >>> pretty much pointless to figure out a hack just to add this to DTS. > >>> > >>> [1] http://www.ti.com/product/TPS63010 > >> > >> I am sure to trust you on the test log :) -> but then from dts description > >> perspective, it is good if we describe the supplies, even as a always on > >> fixed-regulator. We had instances like 2430SDP ethernet where... umm... we > >> originally missed describing ethernet supply and boom, one fine morning, no > >> more nfs filesystem - I mean, it is a one off scenario there, but describing > >> regulators helps us atleast understand the power tree of the board a little > >> better. > >> > >> Again, no strong opinions on my side, it is a good thing to do is all > >> I feel about it. > > > > you mean something like: > > > > V5_0D: fixedregulator@0 { > > compatible = "regulator-fixed"; > > regulator-name = "V5_0D"; > > regulator-min-microvolt = <5000000>; > > regulator-max-microvolt = <5000000>; > > regulator-boot-on; > > regulator-always-on; > > vin-supply = <&dcdc4>; > > }; > > > > VBUS_USB: fixedregulator@1 { > > compatible = "regulator-fixed"; > > regulator-name = "VBUS_USB"; > > regulator-min-microvolt = <5000000>; > > regulator-max-microvolt = <5000000>; > > regulator-boot-on; > > regulator-always-on; > > vin-supply = <&V5_0D>; > > }; > > > > I can add that, but note that it's *solely* to make sysfs look nice. And > > if that's the case, most likely *every* DTS file in tree today as > > incomplete. OTOH, I really consider this to be hugely unnecessary > > because of the fact that board will turn off if 3v3 (dcdc4) is disabled. > > > > > Yes - something along those lines - Again, no strong opinions on my > side for these - just that it is a good thing to model in and may help > drivers where can use the awareness. if you ask me, it's just two extra instances of the fixed regulator driver for a really marginal added benefit. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2014-06-19 4:02 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 15:43 [PATCH v2 0/2] arm: dts: add support for am437x sk Felipe Balbi
2014-06-18 15:43 ` [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog Felipe Balbi
2014-06-18 15:55 ` Nishanth Menon
2014-06-18 19:25 ` Felipe Balbi
2014-06-18 21:43 ` Nishanth Menon
2014-06-18 21:51 ` Felipe Balbi
2014-06-18 21:55 ` Nishanth Menon
2014-06-18 15:43 ` [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit Felipe Balbi
2014-06-18 16:14 ` Nishanth Menon
2014-06-18 19:31 ` Felipe Balbi
[not found] ` <20140618193113.GC4570-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-06-18 21:54 ` Nishanth Menon
2014-06-18 23:19 ` Felipe Balbi
[not found] ` <20140618231923.GA9855-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-06-18 23:23 ` Felipe Balbi
2014-06-19 2:26 ` Nishanth Menon
[not found] ` <53A24A39.4080100-l0cyMroinI0@public.gmane.org>
2014-06-19 3:05 ` Felipe Balbi
[not found] ` <20140619030520.GA13805-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-06-19 3:17 ` Nishanth Menon
2014-06-19 4:02 ` Felipe Balbi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).