Re: [PATCH RFC 1/2] libahci_platform: add ahci_platform_get_of_property

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 06/19/2014 04:22 AM, zhangfei wrote:
> Hi Mark,
> 
> On 06/18/2014 10:03 PM, Mark Rutland wrote:
>> On Wed, Jun 18, 2014 at 05:54:08AM +0100, Zhangfei Gao wrote:
>>> Instead of setting hflags in different files,
>>> ahci_platform_get_of_property set hpriv->flags when ahci_platform_init_host
>>> according to property in dts.
>>
>> The AHCI_HFLAGS are a Linux implementation detail, so it would be nice
>> to have a good justification for each of these being turned into DT
>> properties.
> 
> Do you mean only add required property now?

No you should not add any properties at all using properties to set SoC specific quirks
is just wrong, if a device is not 100% ahci compatible you should use a SoC specific
compatible string for it, and set quirks in the kernel driver based on that.

Devicetree is supposed to describe hardware, in this case the quirks are a property
of the specific model of the hardware, so this should be expressed through the
compatible string. Extra properties in devicetree are meant to be used for board
specific things, like having a gpio to enable power to the sata target device.
Extra properties should not be used in the way you are proposing to use them now.

Regards,

Hans