From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes Date: Thu, 26 Jun 2014 16:28:58 +0400 Message-ID: <53AC120A.8000905@cogentembedded.com> References: <201406242157.05973.sergei.shtylyov@cogentembedded.com> <201406242159.55373.sergei.shtylyov@cogentembedded.com> <53AB89B3.9020207@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Magnus Damm , Yoshihiro Shimoda Cc: "horms@verge.net.au" , "linux-sh@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "ben.dooks@codethink.co.uk" List-Id: devicetree@vger.kernel.org Hello. On 06/26/2014 07:01 AM, Magnus Damm wrote: >>> From: Ben Dooks >>> Add device nodes for the R8A7790 internal PCI bridge devices. >>> Signed-off-by: Ben Dooks >>> Reviewed-by: Ian Molton >>> [Sergei: added several properties to the PCI bridge nodes] >>> Signed-off-by: Sergei Shtylyov >> Thank you for the patch! >> I tested this patch on my lager board and a usb memory, and it works. >> Tested-by: Yoshihiro Shimoda > Thanks for testing. Just one quick question from my side: Which USB > port did you test? > I somehow assumed that at least the majority of the USB ports on R-Car > Gen2 require a USB PHY device driver to work? In fact, channel #2 also works without the PHY driver as the default UGCTRL2 setting route USB2 pins to OHCI/EHCI. > Cheers, > / magnus WBR, Sergei