* [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
@ 2014-06-26 13:44 Rickard Strandqvist
2014-06-27 6:47 ` Patrice Chotard
[not found] ` <1403790272-11635-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2014-06-26 13:44 UTC (permalink / raw)
To: Srinivas Kandagatla, Maxime Coquelin
Cc: Rickard Strandqvist, Patrice Chotard, Linus Walleij, Grant Likely,
Rob Herring, linux-arm-kernel, kernel, linux-kernel, devicetree
Remove variable that are never used
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/pinctrl/pinctrl-st.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1bd6363bc9..d3bd687 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
const __be32 *list;
struct property *pp;
struct st_pinconf *conf;
- phandle phandle;
struct device_node *pins;
- u32 pin;
int i = 0, npins = 0, nr_props;
pins = of_get_child_by_name(np, "st,pins");
@@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
conf = &grp->pin_conf[i];
/* bank & offset */
- phandle = be32_to_cpup(list++);
- pin = be32_to_cpup(list++);
+ be32_to_cpup(list++);
+ be32_to_cpup(list++);
conf->pin = of_get_named_gpio(pins, pp->name, 0);
conf->name = pp->name;
grp->pins[i] = conf->pin;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
2014-06-26 13:44 [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used Rickard Strandqvist
@ 2014-06-27 6:47 ` Patrice Chotard
[not found] ` <1403790272-11635-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Patrice Chotard @ 2014-06-27 6:47 UTC (permalink / raw)
To: Rickard Strandqvist, Srinivas Kandagatla, Maxime Coquelin
Cc: Linus Walleij, Grant Likely, Rob Herring, linux-arm-kernel,
kernel, linux-kernel, devicetree
Hi Rickard
On 06/26/2014 03:44 PM, Rickard Strandqvist wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..d3bd687 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> const __be32 *list;
> struct property *pp;
> struct st_pinconf *conf;
> - phandle phandle;
> struct device_node *pins;
> - u32 pin;
> int i = 0, npins = 0, nr_props;
>
> pins = of_get_child_by_name(np, "st,pins");
> @@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> conf = &grp->pin_conf[i];
>
> /* bank & offset */
> - phandle = be32_to_cpup(list++);
> - pin = be32_to_cpup(list++);
> + be32_to_cpup(list++);
> + be32_to_cpup(list++);
> conf->pin = of_get_named_gpio(pins, pp->name, 0);
> conf->name = pp->name;
> grp->pins[i] = conf->pin;
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <1403790272-11635-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>]
* Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
[not found] ` <1403790272-11635-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
@ 2014-07-07 15:54 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-07-07 15:54 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Srinivas Kandagatla, Maxime Coquelin, Patrice Chotard,
Grant Likely, Rob Herring,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Thu, Jun 26, 2014 at 3:44 PM, Rickard Strandqvist
<rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org> wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-07 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 13:44 [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used Rickard Strandqvist
2014-06-27 6:47 ` Patrice Chotard
[not found] ` <1403790272-11635-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
2014-07-07 15:54 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).